From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 0E9043858D28 for ; Wed, 6 Sep 2023 02:10:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0E9043858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1693966233; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UTpyvLDEFTJtt4/DjUdy7m4WIDD5WwfeQ07JaN6gSqI=; b=IkN61yvRa8/LIL2l+lu6WIEqeN8yDchcdPXMElqiXoFkkJJN7zdazEyZ8wveJICMoids87 MAvnGMDuePJIObAPtF6/QM+jEmLDyyaKs7Efd2lGYEegoUYBCKdAj6l5HcmbwNT1dCzsz0 r6onNllf6Wty3YLq9EJpF3U8Ugd7xv4= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-561-9rx2lUo9ORqbn6ip4o8TEg-1; Tue, 05 Sep 2023 22:10:30 -0400 X-MC-Unique: 9rx2lUo9ORqbn6ip4o8TEg-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 80F6D10264D6; Wed, 6 Sep 2023 02:10:30 +0000 (UTC) Received: from f37-zws-nv (unknown [10.22.16.35]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 02513493110; Wed, 6 Sep 2023 02:10:29 +0000 (UTC) Date: Tue, 5 Sep 2023 19:10:28 -0700 From: Kevin Buettner To: "Ijaz, Abdul B via Gdb-patches" Cc: "Ijaz, Abdul B" , "tom@tromey.com" Subject: Re: [PING 6][PATCH v2 0/4] Adapt Fortran testsuite for ifort Message-ID: <20230905191028.40239535@f37-zws-nv> In-Reply-To: References: Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_ASCII_DIVIDERS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Abdul, Tom had some comments on patch 3, but said that the rest looked good. See: https://sourceware.org/pipermail/gdb-patches/2022-August/191607.html I've looked over the patch 3 from the v2 series (in which you addressed Tom's concern). It looks good to me. Therefore... Approved-by: Kevin Buettner On Sun, 3 Sep 2023 19:11:12 +0000 "Ijaz, Abdul B via Gdb-patches" wrote: > Ping! > > Thanks, > Abdul Basit > ________________________________________ > From: Kempke, Nils-Christian > Sent: Fri Oct 21, 2022 08:15:08 GMT 2022 > To: mailto:gdb-patches@sourceware.org ; Kempke, Nils-Christian > Cc: mailto:tom@tromey.com > Subject: Re: [PING 5][PATCH v2 0/4] Adapt Fortran testsuite for ifort > Ping! > > Thanks, > Nils > ________________________________ > From: Kempke, Nils-Christian > Sent: Thursday, October 13, 2022 10:52 AM > To: mailto:gdb-patches@sourceware.org ; Kempke, Nils-Christian > Cc: mailto:tom@tromey.com > Subject: Re: [PING 4][PATCH v2 0/4] Adapt Fortran testsuite for ifort > > Ping! > > Thanks, > Nils > > ________________________________ > From: Gdb-patches on behalf of Kempke, Nils-Christian via Gdb-patches > Sent: Wednesday, October 5, 2022 10:23 PM > To: mailto:gdb-patches@sourceware.org > Cc: mailto:tom@tromey.com > Subject: Re: [PING 3][PATCH v2 0/4] Adapt Fortran testsuite for ifort > > Ping! > > Thanks, > Nils > ________________________________ > From: Kempke, Nils-Christian > Sent: Monday, September 26, 2022 4:02 PM > To: mailto:gdb-patches@sourceware.org ; Kempke, Nils-Christian > Cc: mailto:tom@tromey.com > Subject: Re: [PING 2][PATCH v2 0/4] Adapt Fortran testsuite for ifort > > Ping! > > Thanks, > Nils > ________________________________ > From: Gdb-patches on behalf of Kempke, Nils-Christian via Gdb-patches > Sent: Monday, September 19, 2022 12:18 PM > To: mailto:gdb-patches@sourceware.org > Cc: mailto:tom@tromey.com > Subject: Re: [PING][PATCH v2 0/4] Adapt Fortran testsuite for ifort > > Ping! > > Thanks, > Nils > ________________________________ > From: Kempke, Nils-Christian > Sent: Wednesday, August 31, 2022 11:36 AM > To: mailto:gdb-patches@sourceware.org > Cc: mailto:tom@tromey.com ; Kempke, Nils-Christian > Subject: [PATCH v2 0/4] Adapt Fortran testsuite for ifort > > Hi! > > Please find attached v2 of this series. > > V1 can be found here: > > https://sourceware.org/pipermail/gdb-patches/2022-June/190013.html > > V2 incorporates Tom's comment on patch 3/4 here: > > https://sourceware.org/pipermail/gdb-patches/2022-August/191606.html > > so changes from v1 to v2 only concern patch 3: > > * Patch 1: unchanged. > * Patch 2: unchanged. > * Patch 3: Remove fortran_runto_main for the two tests as well as the > first breakpoint setting + hitting and instead use runto to directly > run to the first breakpoint location. > * Patch 4: unchanged. > > Tom has approved of Patch 1, 2, and 4 otherwise, but if anyone has a > comment, they are always welcome! > > Cheers! > Nils > > Nils-Christian Kempke (4): > testsuite, fortran: make mixed-lang-stack less compiler dependent > testsuite, fortran: Remove self assignment non-statements > testsuite, fortran: adapt tests for ifort's 'start' behavior > testsuite, fortran: make kfail gfortran specific > > gdb/testsuite/gdb.fortran/array-slices-bad.exp | 13 +++++-------- > gdb/testsuite/gdb.fortran/function-calls.exp | 4 +++- > gdb/testsuite/gdb.fortran/library-module-lib.f90 | 2 +- > gdb/testsuite/gdb.fortran/library-module-main.f90 | 2 +- > gdb/testsuite/gdb.fortran/mixed-lang-stack.exp | 9 ++++++++- > gdb/testsuite/gdb.fortran/module.f90 | 11 ++++++----- > gdb/testsuite/gdb.fortran/vla-type.exp | 11 +++-------- > 7 files changed, 27 insertions(+), 25 deletions(-) > > -- > 2.25.1 > > > Intel Deutschland GmbH > Registered Address: Am Campeon 10, 85579 Neubiberg, Germany > Tel: +49 89 99 8853-0, www.intel.de > Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva > Chairperson of the Supervisory Board: Nicole Lau > Registered Office: Munich > Commercial Register: Amtsgericht Muenchen HRB 186928