From: Markus Metzger <markus.t.metzger@intel.com>
To: gdb-patches@sourceware.org
Cc: vries@gcc.gnu.org
Subject: [PATCH 2/2] gdb: c++ify btrace_target_info
Date: Wed, 6 Sep 2023 07:47:27 +0000 [thread overview]
Message-ID: <20230906074727.426831-2-markus.t.metzger@intel.com> (raw)
In-Reply-To: <20230906074727.426831-1-markus.t.metzger@intel.com>
Following the example of private_thread_info and private_inferior, turn
struct btrace_target_info into a small class hierarchy.
Fixes PR gdb/30751.
---
gdb/nat/linux-btrace.c | 57 ++++++++++++++++++++++++++++----------
gdb/nat/linux-btrace.h | 12 +++++++-
gdb/remote.c | 55 ++++++++++++++++++++++++++++--------
gdbsupport/btrace-common.h | 5 +++-
4 files changed, 101 insertions(+), 28 deletions(-)
diff --git a/gdb/nat/linux-btrace.c b/gdb/nat/linux-btrace.c
index c5b3f1c93cf..3960d462e67 100644
--- a/gdb/nat/linux-btrace.c
+++ b/gdb/nat/linux-btrace.c
@@ -277,8 +277,9 @@ perf_event_sample_ok (const struct perf_event_sample *sample)
part at the end and its upper part at the beginning of the buffer. */
static std::vector<btrace_block> *
-perf_event_read_bts (struct btrace_target_info* tinfo, const uint8_t *begin,
- const uint8_t *end, const uint8_t *start, size_t size)
+perf_event_read_bts (struct linux_btrace_target_info* tinfo,
+ const uint8_t *begin, const uint8_t *end,
+ const uint8_t *start, size_t size)
{
std::vector<btrace_block> *btrace = new std::vector<btrace_block>;
struct perf_event_sample sample;
@@ -447,6 +448,28 @@ diagnose_perf_event_open_fail ()
error (_("Failed to start recording: %s"), safe_strerror (errno));
}
+/* Get the linux version of a btrace_target_info. */
+
+static linux_btrace_target_info *
+get_linux_btrace_target_info (btrace_target_info *gtinfo)
+{
+ if (gtinfo == nullptr)
+ return nullptr;
+
+ return gdb::checked_static_cast<linux_btrace_target_info *> (gtinfo);
+}
+
+/* Get the linux version of a btrace_target_info - const version. */
+
+static const linux_btrace_target_info *
+get_linux_btrace_target_info (const btrace_target_info *gtinfo)
+{
+ if (gtinfo == nullptr)
+ return nullptr;
+
+ return gdb::checked_static_cast<const linux_btrace_target_info *> (gtinfo);
+}
+
/* Enable branch tracing in BTS format. */
static struct btrace_target_info *
@@ -460,9 +483,8 @@ linux_enable_bts (ptid_t ptid, const struct btrace_config_bts *conf)
if (!cpu_supports_bts ())
error (_("BTS support has been disabled for the target cpu."));
- gdb::unique_xmalloc_ptr<btrace_target_info> tinfo
- (XCNEW (btrace_target_info));
- tinfo->ptid = ptid;
+ std::unique_ptr<linux_btrace_target_info> tinfo
+ { new linux_btrace_target_info (ptid) };
tinfo->conf.format = BTRACE_FORMAT_BTS;
bts = &tinfo->variant.bts;
@@ -612,9 +634,8 @@ linux_enable_pt (ptid_t ptid, const struct btrace_config_pt *conf)
if (pid == 0)
pid = ptid.pid ();
- gdb::unique_xmalloc_ptr<btrace_target_info> tinfo
- (XCNEW (btrace_target_info));
- tinfo->ptid = ptid;
+ std::unique_ptr<linux_btrace_target_info> tinfo
+ { new linux_btrace_target_info (ptid) };
tinfo->conf.format = BTRACE_FORMAT_PT;
pt = &tinfo->variant.pt;
@@ -755,10 +776,13 @@ linux_disable_pt (struct btrace_tinfo_pt *tinfo)
/* See linux-btrace.h. */
enum btrace_error
-linux_disable_btrace (struct btrace_target_info *tinfo)
+linux_disable_btrace (struct btrace_target_info *gtinfo)
{
enum btrace_error errcode;
+ linux_btrace_target_info *tinfo
+ = get_linux_btrace_target_info (gtinfo);
+
errcode = BTRACE_ERR_NOT_SUPPORTED;
switch (tinfo->conf.format)
{
@@ -775,7 +799,7 @@ linux_disable_btrace (struct btrace_target_info *tinfo)
}
if (errcode == BTRACE_ERR_NONE)
- xfree (tinfo);
+ delete gtinfo;
return errcode;
}
@@ -785,7 +809,7 @@ linux_disable_btrace (struct btrace_target_info *tinfo)
static enum btrace_error
linux_read_bts (struct btrace_data_bts *btrace,
- struct btrace_target_info *tinfo,
+ struct linux_btrace_target_info *tinfo,
enum btrace_read_type type)
{
struct perf_event_buffer *pevent;
@@ -888,7 +912,7 @@ linux_fill_btrace_pt_config (struct btrace_data_pt_config *conf)
static enum btrace_error
linux_read_pt (struct btrace_data_pt *btrace,
- struct btrace_target_info *tinfo,
+ struct linux_btrace_target_info *tinfo,
enum btrace_read_type type)
{
struct perf_event_buffer *pt;
@@ -921,9 +945,12 @@ linux_read_pt (struct btrace_data_pt *btrace,
enum btrace_error
linux_read_btrace (struct btrace_data *btrace,
- struct btrace_target_info *tinfo,
+ struct btrace_target_info *gtinfo,
enum btrace_read_type type)
{
+ linux_btrace_target_info *tinfo
+ = get_linux_btrace_target_info (gtinfo);
+
switch (tinfo->conf.format)
{
case BTRACE_FORMAT_NONE:
@@ -951,8 +978,10 @@ linux_read_btrace (struct btrace_data *btrace,
/* See linux-btrace.h. */
const struct btrace_config *
-linux_btrace_conf (const struct btrace_target_info *tinfo)
+linux_btrace_conf (const struct btrace_target_info *gtinfo)
{
+ const linux_btrace_target_info *tinfo
+ = get_linux_btrace_target_info (gtinfo);
return &tinfo->conf;
}
diff --git a/gdb/nat/linux-btrace.h b/gdb/nat/linux-btrace.h
index ab69647c591..1dff977cb44 100644
--- a/gdb/nat/linux-btrace.h
+++ b/gdb/nat/linux-btrace.h
@@ -23,6 +23,7 @@
#define NAT_LINUX_BTRACE_H
#include "gdbsupport/btrace-common.h"
+#include "gdbsupport/gdb-checked-static-cast.h"
#if HAVE_LINUX_PERF_EVENT_H
# include <linux/perf_event.h>
#endif
@@ -81,7 +82,7 @@ struct btrace_tinfo_pt
#endif /* HAVE_LINUX_PERF_EVENT_H */
/* Branch trace target information per thread. */
-struct btrace_target_info
+struct linux_btrace_target_info : public btrace_target_info
{
/* The ptid of this thread. */
ptid_t ptid;
@@ -100,6 +101,15 @@ struct btrace_target_info
struct btrace_tinfo_pt pt;
} variant;
#endif /* HAVE_LINUX_PERF_EVENT_H */
+
+
+ linux_btrace_target_info (ptid_t _ptid, const struct btrace_config &_conf)
+ : ptid (_ptid), conf (_conf), variant ({})
+ {}
+
+ linux_btrace_target_info (ptid_t _ptid)
+ : ptid (_ptid), conf ({}), variant ({})
+ {}
};
/* See to_enable_btrace in target.h. */
diff --git a/gdb/remote.c b/gdb/remote.c
index 55f2fc3b6b5..043781cea06 100644
--- a/gdb/remote.c
+++ b/gdb/remote.c
@@ -14423,15 +14423,45 @@ parse_xml_btrace_conf (struct btrace_config *conf, const char *xml)
#endif /* !defined (HAVE_LIBEXPAT) */
}
-struct btrace_target_info
+struct remote_btrace_target_info : public btrace_target_info
{
/* The ptid of the traced thread. */
ptid_t ptid;
/* The obtained branch trace configuration. */
struct btrace_config conf;
+
+ remote_btrace_target_info (ptid_t _ptid, const struct btrace_config &_conf)
+ : ptid (_ptid), conf (_conf)
+ {}
+
+ remote_btrace_target_info (ptid_t _ptid)
+ : ptid (_ptid), conf ({})
+ {}
};
+/* Get the remote version of a btrace_target_info. */
+
+static remote_btrace_target_info *
+get_remote_btrace_target_info (btrace_target_info *gtinfo)
+{
+ if (gtinfo == nullptr)
+ return nullptr;
+
+ return gdb::checked_static_cast<remote_btrace_target_info *> (gtinfo);
+}
+
+/* Get the remote version of a btrace_target_info - const version. */
+
+static const remote_btrace_target_info *
+get_remote_btrace_target_info (const btrace_target_info *gtinfo)
+{
+ if (gtinfo == nullptr)
+ return nullptr;
+
+ return gdb::checked_static_cast<const remote_btrace_target_info *> (gtinfo);
+}
+
/* Reset our idea of our target's btrace configuration. */
static void
@@ -14502,7 +14532,7 @@ remote_target::btrace_sync_conf (const btrace_config *conf)
/* Read TP's btrace configuration from the target and store it into CONF. */
static void
-btrace_read_config (thread_info *tp, struct btrace_config *conf)
+btrace_read_config (thread_info *tp, btrace_config *conf)
{
/* target_read_stralloc relies on INFERIOR_PTID. */
scoped_restore_current_thread restore_thread;
@@ -14564,9 +14594,8 @@ remote_target::remote_btrace_maybe_reopen ()
btrace_format_string (rs->btrace_config.format));
}
- tp->btrace.target = XCNEW (struct btrace_target_info);
- tp->btrace.target->ptid = tp->ptid;
- tp->btrace.target->conf = rs->btrace_config;
+ tp->btrace.target
+ = new remote_btrace_target_info { tp->ptid, rs->btrace_config };
}
}
@@ -14576,7 +14605,7 @@ struct btrace_target_info *
remote_target::enable_btrace (thread_info *tp,
const struct btrace_config *conf)
{
- struct btrace_target_info *tinfo = NULL;
+ struct remote_btrace_target_info *tinfo = NULL;
struct packet_config *packet = NULL;
struct remote_state *rs = get_remote_state ();
char *buf = rs->buf.data ();
@@ -14620,8 +14649,7 @@ remote_target::enable_btrace (thread_info *tp,
target_pid_to_str (ptid).c_str ());
}
- tinfo = XCNEW (struct btrace_target_info);
- tinfo->ptid = ptid;
+ tinfo = new remote_btrace_target_info { ptid };
/* If we fail to read the configuration, we lose some information, but the
tracing itself is not impacted. */
@@ -14641,7 +14669,7 @@ remote_target::enable_btrace (thread_info *tp,
/* Disable branch tracing. */
void
-remote_target::disable_btrace (struct btrace_target_info *tinfo)
+remote_target::disable_btrace (struct btrace_target_info *gtinfo)
{
struct remote_state *rs = get_remote_state ();
char *buf = rs->buf.data ();
@@ -14650,6 +14678,7 @@ remote_target::disable_btrace (struct btrace_target_info *tinfo)
if (m_features.packet_support (PACKET_Qbtrace_off) != PACKET_ENABLE)
error (_("Target does not support branch tracing."));
+ remote_btrace_target_info *tinfo = get_remote_btrace_target_info (gtinfo);
set_general_thread (tinfo->ptid);
buf += xsnprintf (buf, endbuf - buf, "%s",
@@ -14667,7 +14696,7 @@ remote_target::disable_btrace (struct btrace_target_info *tinfo)
target_pid_to_str (tinfo->ptid).c_str ());
}
- xfree (tinfo);
+ delete gtinfo;
}
/* Teardown branch tracing. */
@@ -14676,7 +14705,7 @@ void
remote_target::teardown_btrace (struct btrace_target_info *tinfo)
{
/* We must not talk to the target during teardown. */
- xfree (tinfo);
+ delete tinfo;
}
/* Read the branch trace. */
@@ -14723,8 +14752,10 @@ remote_target::read_btrace (struct btrace_data *btrace,
}
const struct btrace_config *
-remote_target::btrace_conf (const struct btrace_target_info *tinfo)
+remote_target::btrace_conf (const struct btrace_target_info *gtinfo)
{
+ const remote_btrace_target_info *tinfo
+ = get_remote_btrace_target_info (gtinfo);
return &tinfo->conf;
}
diff --git a/gdbsupport/btrace-common.h b/gdbsupport/btrace-common.h
index e287c93a6c1..7ae865b3978 100644
--- a/gdbsupport/btrace-common.h
+++ b/gdbsupport/btrace-common.h
@@ -214,7 +214,10 @@ struct btrace_data
};
/* Target specific branch trace information. */
-struct btrace_target_info;
+struct btrace_target_info
+{
+ virtual ~btrace_target_info () {}
+};
/* Enumeration of btrace read types. */
--
2.34.1
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
next prev parent reply other threads:[~2023-09-06 7:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-06 7:47 [PATCH 1/2] gdb, btrace: move xml parsing into remote.c Markus Metzger
2023-09-06 7:47 ` Markus Metzger [this message]
2023-09-06 13:21 ` [PATCH 2/2] gdb: c++ify btrace_target_info Simon Marchi
2023-09-07 10:42 ` Metzger, Markus T
2023-09-07 13:54 ` Simon Marchi
2023-09-08 9:32 ` Metzger, Markus T
2023-09-06 12:46 ` [PATCH 1/2] gdb, btrace: move xml parsing into remote.c Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230906074727.426831-2-markus.t.metzger@intel.com \
--to=markus.t.metzger@intel.com \
--cc=gdb-patches@sourceware.org \
--cc=vries@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).