From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x230.google.com (mail-oi1-x230.google.com [IPv6:2607:f8b0:4864:20::230]) by sourceware.org (Postfix) with ESMTPS id 7A3D63858C2A for ; Tue, 12 Sep 2023 16:27:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7A3D63858C2A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-oi1-x230.google.com with SMTP id 5614622812f47-3ab244f2c89so4399455b6e.3 for ; Tue, 12 Sep 2023 09:27:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1694536071; x=1695140871; darn=sourceware.org; h=to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=WINxR41CFCyFwRK4hqSkmIHqrE1t4+iPgaxOKzRnVHk=; b=eNnxFUSSCW+xB4DSetSCFnGm3cWj+0X1FzGXSYov2uT1H4XeQSRQ9mG+9FTe1aEp6p BzQFWg0TxBujlp/y6LU694XOuti1IE4RNrxpmljgcQ3wxvo31lh5lyDi/muYGa4+osFU LqElNSAQ6g+XJxtmgvs51Gt83pnwAX9Iqrh3MaPMKDjsJBUIJY1HREyf0dj3lO94x4bp n9Q4ETCXwxEMkpr3yUtOo3Zz7oX3ntIpqJPAp0EMV/BYd4SEasZNKjz6mf4o7+Mb9v1Y tZC7RPrYy3ce90TZbiDlJ14kEOSbLewED6my8pEWghcK2Ge0mhvO5aUlgRRsud9h66Su ixyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694536071; x=1695140871; h=to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WINxR41CFCyFwRK4hqSkmIHqrE1t4+iPgaxOKzRnVHk=; b=d3hvLGiy1pU5vLv+h2nargxqMaCUTcOh9lcWRmyYF63q0W24VLhy0pItqATg9wEDBl IZ1M2taQwmPKYf5yeEaj+BLdzBCE/yswy+In9b6Bw710c1mqm8/0lM/NLTcmS9P3rNtf UtVD8gA3fPj/RG5vUb3HI1/iTTr5iKWgic5/BtWiGw4s3DlF40UbqLs2Jf3zyVBfckfT GihLD76DvhPwnlnX1oLA7CIkqkb7vbBLqFz9sU4WSnb9HbV3zHlgNrF95LThiqw0CyWq d2wG6HNI1HdDIrWdzhEsmiBZL91mOIlwC9BrH0/j9RC/Cm8OAQYRxX2znm8BVmWuCSs7 SNJw== X-Gm-Message-State: AOJu0Yx1o1FR1xuKwobf4Gy+kiOhupFfZSjRwKPjJJA0l+vi7x0Q7vtS mfcEdGLaCD3YNaPdlDo04paUpS5i8qG0XsiTAvrgDg== X-Google-Smtp-Source: AGHT+IEqhsgXHOCJDMIC8viOAs2sSZ3CwHCOWubbLoAqbXA/5cvE7nwcheWgCFxq5nVoW7KXQn3wYQ== X-Received: by 2002:a05:6870:56ac:b0:1bb:7d24:eabb with SMTP id p44-20020a05687056ac00b001bb7d24eabbmr67849oao.0.1694536070870; Tue, 12 Sep 2023 09:27:50 -0700 (PDT) Received: from localhost.localdomain (71-211-130-31.hlrn.qwest.net. [71.211.130.31]) by smtp.gmail.com with ESMTPSA id l1-20020a02cd81000000b0042b91ec7e31sm2872324jap.3.2023.09.12.09.27.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Sep 2023 09:27:50 -0700 (PDT) From: Tom Tromey Date: Tue, 12 Sep 2023 10:27:48 -0600 Subject: [PATCH 1/6] Fix latent bug in ser_windows_send_break MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20230912-serial-exceptions-v1-1-af5097485390@adacore.com> References: <20230912-serial-exceptions-v1-0-af5097485390@adacore.com> In-Reply-To: <20230912-serial-exceptions-v1-0-af5097485390@adacore.com> To: gdb-patches@sourceware.org X-Mailer: b4 0.12.3 X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: The ClearCommBreak documentation says: If the function fails, the return value is zero. ser_windows_send_break inverts this check. This has never been noticed because the caller doesn't check the result. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30770 --- gdb/ser-mingw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/ser-mingw.c b/gdb/ser-mingw.c index c0aa5d8d0b9..806f3999385 100644 --- a/gdb/ser-mingw.c +++ b/gdb/ser-mingw.c @@ -137,7 +137,7 @@ ser_windows_send_break (struct serial *scb) /* Delay for 250 milliseconds. */ Sleep (250); - if (ClearCommBreak (h)) + if (ClearCommBreak (h) == 0) return -1; return 0; -- 2.40.1