From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-VI1-obe.outbound.protection.outlook.com (mail-vi1eur03on2093.outbound.protection.outlook.com [40.107.103.93]) by sourceware.org (Postfix) with ESMTPS id 148653858D20 for ; Wed, 13 Sep 2023 11:41:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 148653858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=xmos.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=xmos.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G5CKsgaHHJWpNAGAgHPIf4O3v9Q4SRC8JKfa53xJMTqVWd6oYwBFRxn6FbY0f5DhUuVPc7blnXTang/bjbRmV+O/42YQYPNT0NtLyIEduJe0QlWfL1GRK16EURtVkJXkBDgcTlDogcblQkkvO4Sodz39pTj1TEO1QbKtU/Kol8fKiTwoxCcysS5ekm/1Z5Z8qF6HBX8nrs1g+ZxlHiwZghv7abTBQtODcxjN5JR4vhzEiU8eRXCwwJHvebuxHWGdqU7VjBcGtpfpC+sjJDqnT0YKultVzEz9/BP8DkRdx5rmMK17dsU5cHwKdhfZGFQM+vTrBC8iwbmIUpxSqE8uPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SQHZIUiUh84Bml/Q0UD0YpDKP03ZG5O3AW/JVCtWH6U=; b=HzmKCkKoXAvO21bTv9lAONLo7FSTKJEJJ+CM891N2pu6E2GBkYRNaAjyKOpbWtXvzIXOWM+sVstZ2N+2HwlPR8GkOs03srIF5VHr6rd7EaSubdnSXpAyWY1PCPa4vikoYo6VEYr3Qp17iEK+CB8D1mkQ4vdUlQDGO5iVIcXex/xQtXWzl0VNgDIfFfhwpDH35gQk1kOkJzI9QrqCNC3oEsM2xdNQ/KCnao7y/cw/bVhMhXBLCEwNt5Lbd6R0d8IJjvDTLauEH2Xd9VwjQgAc2Q+H0bSQmkZreXiJuo+fJqaq/iKyS5DwK9118RHSuUTnmoYmDCBXpFz5hGV8oAowdA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=xmos.com; dmarc=pass action=none header.from=xmos.com; dkim=pass header.d=xmos.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xmos1.onmicrosoft.com; s=selector2-xmos1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SQHZIUiUh84Bml/Q0UD0YpDKP03ZG5O3AW/JVCtWH6U=; b=I5IKrOqrWwscNlfdZOmBjgbXZg3KlT67ZLHYTkE3X1dUFOWm4Kmu/O1syz6YbJQ6hyuP7tEhyhJLy5pLqeqhDyEnu+DIyXCm3JqA6H0Zo/GEv/bieogyIG6WoFQmk0VQNfIzFFHU84mwVvk+7BhD55z9AZ4Ar48wPTWe+bNJL5w= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=xmos.com; Received: from PAXPR09MB5583.eurprd09.prod.outlook.com (2603:10a6:102:280::6) by DU0PR09MB6298.eurprd09.prod.outlook.com (2603:10a6:10:415::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6768.30; Wed, 13 Sep 2023 11:41:34 +0000 Received: from PAXPR09MB5583.eurprd09.prod.outlook.com ([fe80::90eb:46ec:ecc8:bf06]) by PAXPR09MB5583.eurprd09.prod.outlook.com ([fe80::90eb:46ec:ecc8:bf06%4]) with mapi id 15.20.6768.029; Wed, 13 Sep 2023 11:41:34 +0000 From: Ciaran Woodward To: gdb-patches@sourceware.org Cc: luis.machado@arm.com, aburgess@redhat.com, Ciaran Woodward Subject: [PATCH v2] gdb/tdesc: Don't assign custom-group tdesc registers to 'general' Date: Wed, 13 Sep 2023 12:41:26 +0100 Message-Id: <20230913114126.23101-1-ciaranwoodward@xmos.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230907170752.28639-1-ciaranwoodward@xmos.com> References: <20230907170752.28639-1-ciaranwoodward@xmos.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: DUZPR01CA0053.eurprd01.prod.exchangelabs.com (2603:10a6:10:469::11) To PAXPR09MB5583.eurprd09.prod.outlook.com (2603:10a6:102:280::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR09MB5583:EE_|DU0PR09MB6298:EE_ X-MS-Office365-Filtering-Correlation-Id: 3c1fbcb5-0e2c-424b-f222-08dbb44e61e2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rdxCugWbxTZ5ZCHjkrOZ9r6l/YKlxZQJWf/UTT9dtkL93K0wWSWbVJvivtSYsq2MQqvgQV9WKNoJNH34AsuPL8eIiFizMDSg6QLwQPx0nMO0eTua9xjD795vDIbkKrPj8Wm7FT6UOLj4m8FkBeMB7H3VzPaT1+QNCK+wxGUyKxJexELLDGKoJV6UgBz/0u9CBcVGNpyY3rncDV1zq+zvOJZiXIVOSAbewZYIZ5aYYJGQ4lP/0lTuAO6Vdy5W4GhbA116s2/Qb4pi5kxAu0KJ4lw52xbU1TMo4XUAbODvZy2Uk6ebVyWP/n+jI9v6WLtRP2gqLYYOiES5ER6uCSkh2geXPlg75p0G6BPhMt0LwLEmiNNwYmnd7mJKuafw3dujq+oaFK7QIBV2Scd85RA/G9mPk7gdbFbpVtgesKB6HaIaUHl9dg9hZ8gZPjBRMUfBhs5HhcBF3rEV03oDeLGiJoFOf1l3uS9mg6kVTVWP30qEhnmQUcD6NS6p6fQ2dU7hTQDfmLLQ07AuQAJQBXxyDndry2LGmOfVLg9MWGfBIAyGdXFPgLn12ss/FUKj26Du1zuMKjI9cvToO4Z3TZTfVI7YFvh7ONemBVvFiwuJnOIVkp621k6fqXvsS57H9uHp X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR09MB5583.eurprd09.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(396003)(376002)(346002)(366004)(136003)(39840400004)(451199024)(1800799009)(186009)(52116002)(2906002)(38350700002)(38100700002)(36756003)(86362001)(6512007)(6486002)(478600001)(8936002)(66946007)(2616005)(6916009)(41300700001)(66476007)(66556008)(6506007)(316002)(107886003)(4326008)(8676002)(5660300002)(83380400001)(1076003)(6666004)(26005);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?7uRfrYVFYfB0bALDkWDQxO+quqqaeTSjOl5TVXFiLCIDddCyKP8REexshNBq?= =?us-ascii?Q?Ym46YGX+nJzKo0+tGeoHZEbbqeNZO86/DI2o1PGLckmz4vWTXw9Wy292k7ZN?= =?us-ascii?Q?hXEVZ5wMrUIGUDuSp6AsaKMP/Z80TPQf15XPoZ7X4GrkVg5UIzO8d+Ip1hU9?= =?us-ascii?Q?EpNJON5fEqiX+5PX8P50RhZ8Hu7hSphrO9f8fuu4kqmwrlMG3DND7mrdGb4+?= =?us-ascii?Q?PPUypzpFYka4Kgyd5BC4563+q5SUOMLcBKid7czt4HJnM5xwzofHDFeaSAXq?= =?us-ascii?Q?aHHwWoweV1ZjvVEEHAdXR89a7EOCTuJHbWkqa0WWUebgqr2Z0aiJjjnvtRFE?= =?us-ascii?Q?XDgbAkwPAI5f4RFD96BLY2GOoqA4OKHbmYdbsuK/JTefWt0G1Wk34qBjjmgx?= =?us-ascii?Q?fYLX6+oZorhOt2s5YIQjW6zf2qgaHU2Y3WBYnUr3HNGCyALD2CwW2U2CHetS?= =?us-ascii?Q?i/b1Qu8KcbF7rFWbAsFMJjHY9eQ34LotCIrWR/LFOHzin84im8LphJco6tn6?= =?us-ascii?Q?HBNasqMrq22lSEONci1n8AldkEwyY86lC2g+OpUn6dskvnuPvOXSc3xQ4wxb?= =?us-ascii?Q?w7LqsiYDTcD4fImsFl2YcDom/XF0WRCd2g6klL8g3usjvIhOJbgcc5XVZnFf?= =?us-ascii?Q?B9OzZpIAAuwWRRS4FrM555KLWSSe/VUj/pO0lrZ3kaSue6EGvog5I8qQKAwH?= =?us-ascii?Q?brKflJegT08jcDsCmXOwpeaXUZEULHfEdsmKvaQ5YrIsGoWv9OmmVdnbtBk1?= =?us-ascii?Q?Ud7pe9JyFxChHF+eIkcExJO1jtpAw4E3zgMIWnez68+61pwhjatqXsgpz+Ht?= =?us-ascii?Q?3T6yhI3ago/xIgTiUlE4+QmcGfThE+z91BWnMIAMKbpZpXlvjDVlwrJPJ3Jc?= =?us-ascii?Q?/OVeF0qxSIzNDM/VTC3V92EZwqHzh2wDgZt2HgUJxu1X5b1+355FkDpjTfLA?= =?us-ascii?Q?v4bkgCwy/kJDu+T7PI1+rKMiGEctdzVRfdUy4higjAShofg0UHimJya2gb06?= =?us-ascii?Q?+ND+giZfN37c/2hFV0nPVFSG3H34SamPUhAphA/2BKJkm6M3EuOhzK3y+7Li?= =?us-ascii?Q?J+P4YjIdtcHMCjPlj1KjrcGOZ1aI5ab8/VOtc17JCinE/GuniBmKLsk4JJDg?= =?us-ascii?Q?jfcRHxhTZheEn10u99212Gft2b0Dxz/rZfmCGP6uZGQWe1FOAWjj5M3nmW4g?= =?us-ascii?Q?340hU/gTTgWqB+9H47txOC8kNDwR0tMzP48oBdMXVEGcloFOfdnzX0Nx3yBR?= =?us-ascii?Q?0WHJnGGHsVvQ5zQrTAxKuxyAyvQwd+wInSR5/oZoviEqZKoOn+gVQlQa//rh?= =?us-ascii?Q?KsUQC9ZdVmDUQU7E4sQjACgvnHxONZLJzK375tOHqI44JLR0LYpFY3tsEe3n?= =?us-ascii?Q?K2cInxKD7wm4F7gPKj4rTzutEQLWyWYdKd9Rgh1OnIKdQiMO4Xslmhu1F4AN?= =?us-ascii?Q?5TU41QL0D4SpYs9SoTOfuHvQT+vUJXb7t7zK17W+rZhsLUSEGzRrM4hBBJQh?= =?us-ascii?Q?pxUOMu6o7FMTWP9GFAcmx02ZyyIacWqQgJuLmB0300d8sywPkSwHvM49Fxuh?= =?us-ascii?Q?ocWKqvKwZZ38CmlrS4lK3KfFYb0zq5V6PXBOdbjJmDnDiIsaWLi29qwZzZaj?= =?us-ascii?Q?bw=3D=3D?= X-OriginatorOrg: xmos.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3c1fbcb5-0e2c-424b-f222-08dbb44e61e2 X-MS-Exchange-CrossTenant-AuthSource: PAXPR09MB5583.eurprd09.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Sep 2023 11:41:34.7399 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 975ecfb1-4080-42d2-a01d-4a4d0707a539 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yRO7NXR7qxSHzhBgB/12JyDCo+iP3b24Qt95V24mbkvf96UcjZq2vs7O0RbcX6QR+5JdCGgq37T13RwK5a1CuA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR09MB6298 X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: The 'Target Description' mechanism in GDB enables the target to supply the full set of registers available on the system to gdb in an XML format. This format enables setting the 'group' of each register, such that they can be queried using the 'info registers ' mechanism. However prior to this change, even if a register was explicitly assigned to a group, it would still show up in the 'info registers general' report. This is unexpected, and also disagrees with the comment above the tdesc_register_in_reggroup_p function, which says that '-1' should be returned if the register group is not-known, not the register group is known, but differs. There was a previous change that did address this issue in aa66aac47b4dd38f9524ddb5546c08cc09930d37 but it also caused registers with *no* group in the target description to be removed from 'general', so it was reverted in 440cf44eb0f70830b8d8ac35289f84129c7a35c1 as that behaviour was used by some targets. The change in this commit enhances the usefulness of the tdesc 'group' attribute for adding system configuration registers, of which there may be hundreds - very inconvenient to request and print on every 'info registers' call. --- gdb/target-descriptions.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/gdb/target-descriptions.c b/gdb/target-descriptions.c index cdedf88c793..6eb626b9c5a 100644 --- a/gdb/target-descriptions.c +++ b/gdb/target-descriptions.c @@ -954,13 +954,17 @@ tdesc_register_in_reggroup_p (struct gdbarch *gdbarch, int regno, { struct tdesc_reg *reg = tdesc_find_register (gdbarch, regno); - if (reg != NULL && !reg->group.empty () - && (reg->group == reggroup->name ())) + if (reg != NULL) + { + if (reggroup == all_reggroup) return 1; - if (reg != NULL - && (reggroup == save_reggroup || reggroup == restore_reggroup)) - return reg->save_restore; + if (reggroup == save_reggroup || reggroup == restore_reggroup) + return reg->save_restore; + + if (reg != NULL && !reg->group.empty ()) + return (reg->group == reggroup->name ()); + } return -1; } -- 2.25.1