From: Lancelot Six <lancelot.six@amd.com>
To: <gdb-patches@sourceware.org>
Cc: <lsix@lancelotsix.com>, Laurent Morichetti <laurent.morichetti@amd.com>
Subject: [PATCH] gdb/amdgpu: Silence wave termination messages
Date: Fri, 15 Sep 2023 10:52:43 +0000 [thread overview]
Message-ID: <20230915105243.3377965-1-lancelot.six@amd.com> (raw)
From: Laurent Morichetti <laurent.morichetti@amd.com>
Hi,
Here is a patch originally written by Laurent Morichetti fixing a
regression in the amd-dbgapi-target I am submitting on his behalf.
Best,
Lancelot.
After commit 9d7d58e7262, the amdgpu target started printing
"thread exited" messages when pruning waves that had terminated.
...
[AMDGPU Wave ?:?:?:2045 (?,?,?)/? exited]
[AMDGPU Wave ?:?:?:2046 (?,?,?)/? exited]
[AMDGPU Wave ?:?:?:2047 (?,?,?)/? exited]
[AMDGPU Wave ?:?:?:2048 (?,?,?)/? exited]
...
The issue was that before commit 9d7d58e7262, delete_thread was silent
by default due to a bug that the commit fixed.
Replaced the amdgpu target call to delete_thread with a call to
delete_thread_silent.
Change-Id: Ie5d5a4c5be851f092d2315b2afa6a36a30a05245
---
gdb/amd-dbgapi-target.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gdb/amd-dbgapi-target.c b/gdb/amd-dbgapi-target.c
index 22c269b7992..8eafceac569 100644
--- a/gdb/amd-dbgapi-target.c
+++ b/gdb/amd-dbgapi-target.c
@@ -1634,7 +1634,7 @@ amd_dbgapi_target::update_thread_list ()
auto it = threads.find (tp->ptid.tid ());
if (it == threads.end ())
- delete_thread (tp);
+ delete_thread_silent (tp);
else
threads.erase (it);
}
base-commit: 38cc67cc00dc7385991e2658a1b4213d5ba3c4f0
--
2.34.1
next reply other threads:[~2023-09-15 10:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-15 10:52 Lancelot Six [this message]
2023-09-15 15:41 ` Simon Marchi
2023-09-15 16:22 ` Six, Lancelot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230915105243.3377965-1-lancelot.six@amd.com \
--to=lancelot.six@amd.com \
--cc=gdb-patches@sourceware.org \
--cc=laurent.morichetti@amd.com \
--cc=lsix@lancelotsix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).