From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=/jfd=E7=lancelotsix.com=lsix@sourceware.org>
Received: from lndn.lancelotsix.com (lndn.lancelotsix.com [51.195.220.111])
	by sourceware.org (Postfix) with ESMTPS id 7BE373858D35
	for <gdb-patches@sourceware.org>; Fri, 15 Sep 2023 17:21:29 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7BE373858D35
Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=lancelotsix.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=lancelotsix.com
Received: from octopus (cust120-dsl54.idnet.net [212.69.54.120])
	by lndn.lancelotsix.com (Postfix) with ESMTPSA id 5BC1F80910;
	Fri, 15 Sep 2023 17:21:28 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=lancelotsix.com;
	s=2021; t=1694798488;
	bh=Dx5wn+dyVjXu8jzqueKlb2ck5h/Q3ZT986P4QCGNOz0=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=m0sEfBmYk46fj2T46a3px3VmjILzYJmtjRiARELBMWJOQ8JUPJ/SSZvL/bSt61Jn1
	 D7iMAT3Z6joPxCkz5xwzMHGvOtjFkbbuYSoNe8gA8mGt/o5UW8mufyhGa0NDNK4YlB
	 dfp2jdCEytxw5qADw6dPXMRqzmhVbW0wbzBvg56POaBiI56sq8uYxQqHENrLZrpm5g
	 T87haTngeIUeLYuFGlqIyXiUFH49k5/5IW0ILTRky9yOH/E0iLWiHUA+I/u9pzyXCP
	 5xWOEung2e/1BfY7ABuiu89vdcQ5RMZdAzwq1n51MJ4npAwipm2evIe8AzSntJMFua
	 Xy/RU9cl0N9lw==
Date: Fri, 15 Sep 2023 18:19:55 +0100
From: Lancelot SIX <lsix@lancelotsix.com>
To: Simon Marchi <simon.marchi@efficios.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v3 2/3] gdb/testsuite: add linux target check in
 allow_hipcc_tests
Message-ID: <20230915171955.x5azvjkeavyydjls@octopus>
References: <20230915145249.22318-1-simon.marchi@efficios.com>
 <20230915145249.22318-2-simon.marchi@efficios.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20230915145249.22318-2-simon.marchi@efficios.com>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6.2 (lndn.lancelotsix.com [0.0.0.0]); Fri, 15 Sep 2023 17:21:28 +0000 (UTC)
X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gdb-patches.sourceware.org>

On Fri, Sep 15, 2023 at 10:52:12AM -0400, Simon Marchi via Gdb-patches wrote:
> ROCm / HIP tests should only run on Linux for now, existing gdb.rocm
> tests miss such a check.  Add an "istarget linux" check in
> allow_hipcc_tests.
> 
> Change-Id: I71f69e510a754f2fdadc32de53b923ebb9835ab5
> ---
>  gdb/testsuite/lib/rocm.exp | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/gdb/testsuite/lib/rocm.exp b/gdb/testsuite/lib/rocm.exp
> index 98a3b308228d..791f1b403bb7 100644
> --- a/gdb/testsuite/lib/rocm.exp
> +++ b/gdb/testsuite/lib/rocm.exp
> @@ -67,6 +67,10 @@ gdb_caching_proc allow_hipcc_tests {} {
>  	return {0 "remote debugging"}
>      }
>  
> +    if {![istarget "*-linux*"]} {
> +	return {0 "target platform is not Linux"}
> +    }
> +

Hi,

This looks good to me.

As this is a rocm-specific part, I think I can now add:
Approved-By: Lancelot Six <lancelot.six@amd.com>

Thanks,
Lancelot.


>      # Ensure that GDB is built with amd-dbgapi support.
>      set output [remote_exec host $::GDB "$::INTERNAL_GDBFLAGS --configuration"]
>      if { [string first "--with-amd-dbgapi" $output] == -1 } {
> -- 
> 2.42.0
>