From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x135.google.com (mail-il1-x135.google.com [IPv6:2607:f8b0:4864:20::135]) by sourceware.org (Postfix) with ESMTPS id 94A1A3858D32 for ; Mon, 18 Sep 2023 14:25:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 94A1A3858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-il1-x135.google.com with SMTP id e9e14a558f8ab-34fe2814b0dso3341255ab.3 for ; Mon, 18 Sep 2023 07:25:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1695047137; x=1695651937; darn=sourceware.org; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:from:to:cc:subject:date:message-id:reply-to; bh=93N739AAFLX1q5zF7hslXMV0hSKfdMCwKYJhBPIoKNc=; b=KHwglTD1hOHrM4I/3iAgXwzTP6YrKaTiUYLr+R/c2S/vsO4CEGAJV3XuyjPaVXzo8I xuDNUQc/mhytqHAkC/hhiRosnTo0vAaa0oAhQy/ffzx8f2EbOQ97KWHgXQCWGBy4/dVr N/GIiCRXK6FcoalSbUwZ0BwCGx3JmndVDjN7jpFWOVdrDicHZyTY3bT8qVafTHYgYB0m Cu31pNK9r5HAPdCqP36pf2dqUugC5+5yrNoeHUug9LHyhTL+LNHNpxV+XgJNSN08M9bz iJtJ3u5hMCLOXK/RBl4zwAScWLu864hWQR7ecOZe7UpGXpV26DToYecbnx7AZELCZ0ms Ncig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695047137; x=1695651937; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=93N739AAFLX1q5zF7hslXMV0hSKfdMCwKYJhBPIoKNc=; b=aK1N/yR+5NP4PlzKgjTa0i2aLP4Bsx09aihugtHj4G57ka9ETjBf87OAocU3mtbPto oKLcIp8Ke3dEA8Ff/WadhwttMOg7T/qQ+WYBbI/8icZfYfn+6YmoJ9777LohkliJNBC6 rZcCDiQAsUY80eU4KulQttVZU2l8DtDOWa7W/KthP7x8H6nKPWqxCdctXII9FsAVdkk/ YSredpKge/TduCbvbxqQ6A6IfjflEVY0rU9sjrbopqQfGCkSLNlATUZVg2o5gKfnfegO nVUaQvLkoH+zGW7h4TOYj83yn0xmMZDBumnu3uNp9JrxBwaOj/o8sZKU1kjrm/ajxGWS 5MfQ== X-Gm-Message-State: AOJu0YzNzE1AYucRuuXIa4c+qWZknr6wnNZ0X38/drnhV0+vS20zDlbb TqaT/lrZgRG1Uk1LQ4Gl/HJrOr1igtj01vqREAhSpA== X-Google-Smtp-Source: AGHT+IGODJDKSYHVqbK26G6TkPDYYK3Xrx1usxa2TjA+WXEAP0s5vYBZrJMhHomJlLwRP4J4jaRPYw== X-Received: by 2002:a05:6e02:1a4b:b0:34c:a166:9866 with SMTP id u11-20020a056e021a4b00b0034ca1669866mr12962495ilv.4.1695047136898; Mon, 18 Sep 2023 07:25:36 -0700 (PDT) Received: from localhost.localdomain (71-211-130-31.hlrn.qwest.net. [71.211.130.31]) by smtp.gmail.com with ESMTPSA id p26-20020a056638217a00b00439ca0123f8sm1345222jak.44.2023.09.18.07.25.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Sep 2023 07:25:36 -0700 (PDT) From: Tom Tromey Subject: [PATCH v2 0/4] Use checked_static_cast for breakpoint casts Date: Mon, 18 Sep 2023 08:25:34 -0600 Message-Id: <20230918-watchpoint-casts-v2-0-f636ec38fdc4@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAN5dCGUC/32NQQ6DIBBFr2JYl0YE2tiV92hcjONYZiEYILaN8 e5FD9DlS/77bxOJIlMSj2oTkVZOHHyB5lIJdOBfJHksLJq60XWrrHxDRrcE9lkipJzkaDRaC/d BaRJFWyJN/Dkvn33hARLJIYJHdxzNRaJ4DB2nHOL3TK/qmP+prErWEsw0aYvtzRjqYAQMka4YZ tHv+/4DNEpR48sAAAA= To: gdb-patches@sourceware.org Cc: Simon Marchi X-Mailer: b4 0.12.3 X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: While reviewing a patch, I noticed some unchecked casts to watchpoint. This series replaces all the unchecked breakpoint casts I could find with checked casts. Regression tested on x86-64 Fedora 36. --- Changes in v2: - Removed redudant 'struct' keywords and lowered some definitions - Link to v1: https://inbox.sourceware.org/gdb-patches/20230915-watchpoint-casts-v1-0-a4ff35c9644e@adacore.com --- Tom Tromey (4): Use gdb::checked_static_cast for watchpoints Use gdb::checked_static_cast for tracepoints Use gdb::checked_static_cast for code_breakpoint Use gdb::checked_static_cast for catchpoints gdb/ada-lang.c | 2 +- gdb/break-catch-sig.c | 10 +- gdb/break-catch-syscall.c | 4 +- gdb/breakpoint.c | 339 +++++++++++++++++++++++---------------------- gdb/elfread.c | 2 +- gdb/guile/scm-breakpoint.c | 3 +- gdb/mi/mi-cmd-break.c | 9 +- gdb/python/py-breakpoint.c | 3 +- gdb/remote.c | 11 +- gdb/target-debug.h | 2 + gdb/target-delegates.c | 16 +-- gdb/target.c | 2 +- gdb/target.h | 4 +- gdb/tracefile-tfile.c | 4 +- gdb/tracepoint.c | 25 ++-- gdb/tracepoint.h | 4 +- 16 files changed, 224 insertions(+), 216 deletions(-) --- base-commit: cf2ab5ef0b716dea512d85276c484fce758fa5d4 change-id: 20230915-watchpoint-casts-d43c55a7b13e Best regards, -- Tom Tromey