From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd2b.google.com (mail-io1-xd2b.google.com [IPv6:2607:f8b0:4864:20::d2b]) by sourceware.org (Postfix) with ESMTPS id 9D30E3858C78 for ; Mon, 18 Sep 2023 14:25:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9D30E3858C78 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-io1-xd2b.google.com with SMTP id ca18e2360f4ac-79565370aa3so173985239f.0 for ; Mon, 18 Sep 2023 07:25:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1695047139; x=1695651939; darn=sourceware.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=1nHSkmX5LM/xUGGyoZh7udhgEMxP7wuJYHjAUA4pBbs=; b=PnPQhyxOYPhBKQGsZ7w1P8gNvyDCCO9pmSQ5lbtp2FrVQTZ1VAGJc3/dQ/958o8yzv 3cx8UCD04OG6l+5ZXGSUyNbL5X2FFPRUiOxObN9+t4TDnrM08CJUkoWaWgvAiMvS1Inh 5EOKh4Bvq4IvZvoWrncjnO/c1nQ6ZXV+cTtX0JAPEeWJF8SvI9rVDZRVZY/KM3pjEnUE +gx1fQbK1WQ0twsLjuUy15AOyRuSQ7rodyK5qHCtuohDyppFSn+RlyiL5nZIgppTzExi 6Wshei9pkBg/RfrSZC9ZcstOes2xJqGo9sZaYusTeIrdS2bhvEIiMklpuDilDNvjoZFN KJvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695047139; x=1695651939; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1nHSkmX5LM/xUGGyoZh7udhgEMxP7wuJYHjAUA4pBbs=; b=DYUq6WVi1+Z0BKEaSufVRkpZrBBjE/wOZXofITeYwae932EiC4uta+hP6Vci7AVnwC j7Q44ErowvgAdM6yTH6au7KFqAHWc1Pxk/qL/wZoW+gsvEuKe3odRUnJY3zarZ7l3ejB q2T6qchA4NnVoUpJCrw9vD1q/Rkb2MFDxyPA1NzJjsyXaGwxNQcW/7WAfjildMU+S/Xg eU1E5zvu0zGk30g9Kibb3rjciENc7VVBf43VbmhyVYBD85niWs8mS9h1uwjLYR01kfVN kdUbUvajsmkBootuUgtsFG1qPgPeyKorq1uEOyRDF/kZ4cbhqsfnJAcFqUGF8ezH3M1O gRgA== X-Gm-Message-State: AOJu0YytVs1d1pS20TJWJ1fEpKETiC5SPDm6qhwtulYTmkg4Hf0dg2VC I5R+xywXimeHkG46xAi11nu1+z0Q1g8l/w71cLhg+Q== X-Google-Smtp-Source: AGHT+IF8X6TNTRRw03n8AuPpisHeeMfArADnFPh1WDkLxHJOM9TusB5Rt68BsZ2szADAfq/b+rtWIw== X-Received: by 2002:a5d:944f:0:b0:79a:bbd2:8f5a with SMTP id x15-20020a5d944f000000b0079abbd28f5amr10396709ior.12.1695047138955; Mon, 18 Sep 2023 07:25:38 -0700 (PDT) Received: from localhost.localdomain (71-211-130-31.hlrn.qwest.net. [71.211.130.31]) by smtp.gmail.com with ESMTPSA id p26-20020a056638217a00b00439ca0123f8sm1345222jak.44.2023.09.18.07.25.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Sep 2023 07:25:38 -0700 (PDT) From: Tom Tromey Date: Mon, 18 Sep 2023 08:25:37 -0600 Subject: [PATCH v2 3/4] Use gdb::checked_static_cast for code_breakpoint MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20230918-watchpoint-casts-v2-3-f636ec38fdc4@adacore.com> References: <20230918-watchpoint-casts-v2-0-f636ec38fdc4@adacore.com> In-Reply-To: <20230918-watchpoint-casts-v2-0-f636ec38fdc4@adacore.com> To: gdb-patches@sourceware.org Cc: Simon Marchi X-Mailer: b4 0.12.3 X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This replaces some casts to 'code_breakpoint *' with checked_static_cast. Approved-By: Simon Marchi --- gdb/breakpoint.c | 6 ++++-- gdb/elfread.c | 2 +- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c index a87460d2ea2..8f3d4f3b434 100644 --- a/gdb/breakpoint.c +++ b/gdb/breakpoint.c @@ -6170,10 +6170,12 @@ bpstat_run_callbacks (bpstat *bs_head) handle_jit_event (bs->bp_location_at->address); break; case bp_gnu_ifunc_resolver: - gnu_ifunc_resolver_stop ((code_breakpoint *) b); + gnu_ifunc_resolver_stop + (gdb::checked_static_cast (b)); break; case bp_gnu_ifunc_resolver_return: - gnu_ifunc_resolver_return_stop ((code_breakpoint *) b); + gnu_ifunc_resolver_return_stop + (gdb::checked_static_cast (b)); break; } } diff --git a/gdb/elfread.c b/gdb/elfread.c index 55e3e47ceca..8704b52f35b 100644 --- a/gdb/elfread.c +++ b/gdb/elfread.c @@ -1033,7 +1033,7 @@ elf_gnu_ifunc_resolver_return_stop (code_breakpoint *b) "gnu-indirect-function breakpoint type %d"), (int) b->type); } - b = (code_breakpoint *) b_next; + b = gdb::checked_static_cast (b_next); } gdb_assert (b->type == bp_gnu_ifunc_resolver); gdb_assert (b->has_single_location ()); -- 2.40.1