From: Tom Tromey <tom@tromey.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tom@tromey.com>
Subject: [PATCH] More type safety for symbol_search
Date: Sun, 17 Sep 2023 18:00:13 -0600 [thread overview]
Message-ID: <20230918000013.1821776-1-tom@tromey.com> (raw)
This patch changes class symbol_search to store a block_enum rather
than an int.
Regression tested on x86-64 Fedora 38.
---
gdb/symtab.h | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/gdb/symtab.h b/gdb/symtab.h
index 8f587807ff9..365743384e1 100644
--- a/gdb/symtab.h
+++ b/gdb/symtab.h
@@ -2479,7 +2479,7 @@ extern symbol *find_function_alias_target (bound_minimal_symbol msymbol);
the following structs is returned. */
struct symbol_search
{
- symbol_search (int block_, struct symbol *symbol_)
+ symbol_search (block_enum block_, struct symbol *symbol_)
: block (block_),
symbol (symbol_)
{
@@ -2487,7 +2487,7 @@ struct symbol_search
msymbol.objfile = nullptr;
}
- symbol_search (int block_, struct minimal_symbol *minsym,
+ symbol_search (block_enum block_, struct minimal_symbol *minsym,
struct objfile *objfile)
: block (block_),
symbol (nullptr)
@@ -2506,9 +2506,9 @@ struct symbol_search
return compare_search_syms (*this, other) == 0;
}
- /* The block in which the match was found. Could be, for example,
- STATIC_BLOCK or GLOBAL_BLOCK. */
- int block;
+ /* The block in which the match was found. Either STATIC_BLOCK or
+ GLOBAL_BLOCK. */
+ block_enum block;
/* Information describing what was found.
--
2.41.0
next reply other threads:[~2023-09-18 0:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-18 0:00 Tom Tromey [this message]
2023-09-18 0:47 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230918000013.1821776-1-tom@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).