From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lndn.lancelotsix.com (lndn.lancelotsix.com [51.195.220.111]) by sourceware.org (Postfix) with ESMTPS id AED8D3858C66 for ; Mon, 18 Sep 2023 12:34:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AED8D3858C66 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=lancelotsix.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=lancelotsix.com Received: from octopus (cust120-dsl54.idnet.net [212.69.54.120]) by lndn.lancelotsix.com (Postfix) with ESMTPSA id 86CD485C03; Mon, 18 Sep 2023 12:34:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=lancelotsix.com; s=2021; t=1695040463; bh=r3wvc4RoxVPu+tjWNFWBh2fEr1Zvbk8ORhdSWtAV12E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rmt90SSGNrAaiyN6mzHrQElWFXpJkIVPO5xrjHxkHS2lE7wv/UBknOBau+91PFoJV IEl4qne8ypFJYns2yvPLd1UmcXYSWqSg35gbrzRQvk8/MvH0eTPGtS9F3tPQ44IhLp /JGDx8GzMWYDZyRR5KKTzchD46k4K6XjgFmYpFw5lVTxC3beyTMmujGNSV8OZiN1Sd CmMgn91YWUYcy2tQpE+4oD72+It95+np5O6KvUW2HaIhbPRGY+H1fk5MxCRtHW+MI4 vYUbFIffozNnzz5jCndcQoXdfk9thsvJp+OKy+bXV3ep68flranP37ZrwMRBzbLR2u yWHA+T7Mp5wVA== Date: Mon, 18 Sep 2023 13:34:18 +0100 From: Lancelot SIX To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 0/7] Rewrite gdb_bfd_openr_iovec to be type-safe Message-ID: <20230918123418.ddskjvzffqvfhisl@octopus> References: <20230824-gdb-bfd-vec-v1-0-850e4e907ed1@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230824-gdb-bfd-vec-v1-0-850e4e907ed1@adacore.com> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6.2 (lndn.lancelotsix.com [0.0.0.0]); Mon, 18 Sep 2023 12:34:23 +0000 (UTC) X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Tom, I have sent a couple of remarks on patch 1 & patch 6. I quickly went through the other patches of the series and did not notice any issue. Best, Lancelot. On Thu, Aug 24, 2023 at 11:12:17AM -0600, Tom Tromey via Gdb-patches wrote: > This series rewrites gdb_bfd_openr_iovec to be type-safe. > > Note that I can't really test the solib-rocm.c changes, this was done > as a best effort. > > Regression tested on x86-64 Fedora 36. > > --- > Tom Tromey (7): > Introduce type-safe variant of gdb_bfd_openr_iovec > Small constructor change to target_buffer > Convert mem_bfd_iovec to new type-safe gdb_bfd_openr_iovec > Convert target fileio to new type-safe gdb_bfd_openr_iovec > Convert minidebug to new type-safe gdb_bfd_openr_iovec > Convert solib-rocm to new type-safe gdb_bfd_openr_iovec > Remove old gdb_bfd_openr_iovec > > gdb/gdb_bfd.c | 211 +++++++++++++++++++++++++++---------------------------- > gdb/gdb_bfd.h | 43 ++++++++---- > gdb/minidebug.c | 98 +++++++++++--------------- > gdb/solib-rocm.c | 39 +++------- > 4 files changed, 182 insertions(+), 209 deletions(-) > --- > base-commit: 1f08d324601ef7fd4cce3cff8f8db4a774791828 > change-id: 20230824-gdb-bfd-vec-ba7f6c1139bb > > Best regards, > -- > Tom Tromey >