From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=8cWO=FD=lancelotsix.com=lsix@sourceware.org>
Received: from lndn.lancelotsix.com (lndn.lancelotsix.com [51.195.220.111])
	by sourceware.org (Postfix) with ESMTPS id 1F6553856DF4
	for <gdb-patches@sourceware.org>; Tue, 19 Sep 2023 13:20:30 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1F6553856DF4
Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=lancelotsix.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=lancelotsix.com
Received: from octopus (cust120-dsl54.idnet.net [212.69.54.120])
	by lndn.lancelotsix.com (Postfix) with ESMTPSA id 9965D813EC;
	Tue, 19 Sep 2023 13:20:28 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=lancelotsix.com;
	s=2021; t=1695129628;
	bh=eFyzR52Z3uHNGueC3RvagYrirCC2jelka1ssfNmtg7I=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=IcA96C2NVpHzB57vvgBZzXmzswqoSiAqcj58nsuIVSXSY376Mxwk3vaulw/xUswXa
	 5l9d1fJeLuRhnCW760EdFaX7JedpXXLRPe7qslF3ETn6ESul3AhcwZIgV0I0u753qG
	 9Xb/nsTXA8eYCp/b+Spc4BuKZZhyNzO75vml88JWxbEhfByrceEfXjMFdU/8/wsB6u
	 rPYF9728QQW+YGjyjofBHpIq7ppg6dNMEszjdnhVoGosWpSXAeiwn9tYrGHFw9cwDo
	 5p3cRKPaLUTXMGTyWr7P7V58WyqA1lM9sERXSOzUXCohfu6BFtPosIDtpJxaAtfBfZ
	 2SBzSNykcYdTQ==
Date: Tue, 19 Sep 2023 14:20:23 +0100
From: Lancelot SIX <lsix@lancelotsix.com>
To: "Ijaz, Abdul B" <abdul.b.ijaz@intel.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
	"pedro@palves.net" <pedro@palves.net>
Subject: Re: [PATCH v3 2/2] gdb: add shadowed field in
 '-stack-list-locals/variables' mi commands
Message-ID: <20230919132023.3bd56n7v3x7hgsph@octopus>
References: <20230918164738.17082-1-abdul.b.ijaz@intel.com>
 <20230918164738.17082-3-abdul.b.ijaz@intel.com>
 <20230918225323.n526b3ubkkzvzsbe@octopus>
 <SA1PR11MB6846347FB0BEDB381FE38EC1CBFAA@SA1PR11MB6846.namprd11.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <SA1PR11MB6846347FB0BEDB381FE38EC1CBFAA@SA1PR11MB6846.namprd11.prod.outlook.com>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6.2 (lndn.lancelotsix.com [0.0.0.0]); Tue, 19 Sep 2023 13:20:28 +0000 (UTC)
X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gdb-patches.sourceware.org>

On Tue, Sep 19, 2023 at 11:41:47AM +0000, Ijaz, Abdul B wrote:
> Hi Lancelot,
> 
> Thanks for the feedback, will apply the changes similar to previous patch in V4 Patch series and will use " ("shadowed", "True");"  to be consistent with other fields.
> 

Hi,

I was not sure if "True" or "true" should be used.  Looking around (with
`git grep "field_string" | grep -i true` show that "true" is usualy used
(see gdb/mi/mi-cmd-var.c and gdb/mi/mi-cmd-info.c).

Best,
Lancelot.