From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 043C13858C27 for ; Fri, 22 Sep 2023 01:34:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 043C13858C27 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695346465; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=59PoB4GSkCNptQfdGriArm2nAFfR4m/RtO6jzRHgyDU=; b=fPkPW6J4nxWbM9u23IZ0mVQXC32957+89bSKrKEuJTPuMIRc36BRbn0GA8QN0yFLkzs5VP WmD/t/r0cEFBn9wiyOg2nvC1Gy3Pn3xuCWggzN+bplndaocftvQQAmREdczZ3ahViO02C5 ODxti6v6BYaeCk30HhACUWFEEkDjfSE= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-212-Qk9kOyjHP9qzF_r9KvXkuA-1; Thu, 21 Sep 2023 21:34:22 -0400 X-MC-Unique: Qk9kOyjHP9qzF_r9KvXkuA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A7F363800A17; Fri, 22 Sep 2023 01:34:21 +0000 (UTC) Received: from f37-zws-nv (unknown [10.22.32.95]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5E869C15BB8; Fri, 22 Sep 2023 01:34:21 +0000 (UTC) Date: Thu, 21 Sep 2023 18:34:19 -0700 From: Kevin Buettner To: Tom Tromey via Gdb-patches Cc: Tom Tromey Subject: Re: [PATCH] Remove keywords from target debug printer names Message-ID: <20230921183419.42e94c7c@f37-zws-nv> In-Reply-To: <20230919170534.3918313-1-tromey@adacore.com> References: <20230919170534.3918313-1-tromey@adacore.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, 19 Sep 2023 11:05:34 -0600 Tom Tromey via Gdb-patches wrote: > I recently checked in a patch that removed the use of the "struct" > keyword in some spots. Doing this pointed out that the target > delegate code preserves this keyword -- but, with C++, it does not > really need to. This patch changes make-target-delegates.py to remove > these keywords, and updates target-debug.h to follow. This pointed > out that there was already one redudancy: both > target_debug_print_struct_inferior_p and target_debug_print_inferior_p > existed. > > Tested by rebuilding. LGTM. Reviewed-by: Kevin Buettner