From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=xm6u=FK=redhat.com=kevinb@sourceware.org>
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124])
	by sourceware.org (Postfix) with ESMTPS id 3FFF83858D3C
	for <gdb-patches@sourceware.org>; Tue, 26 Sep 2023 00:16:32 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3FFF83858D3C
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1695687391;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=+v4f2cDr8xMJ4mz0dYehtzBOOT1v5KHQ49kWEg6P2QY=;
	b=RTX+uHuZcJ0uR+kBxzToPVUmMMdXydpT/ZDFHUiM6w7b/CBR6KhHN3CL8IQPJZUCUxpi+H
	bTAJ3p2386FLuRfWgu78ZY5+EJCMEf+tnoi9Z0VIPQaSfdp1J9aE0YlB42PVsETD/gZ7Yv
	zblJ2cr7XPW9pcPBLgDRgXC6ItlbJUI=
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
 [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-370-rp7-sMFQOMq2qBIVuF9_4w-1; Mon, 25 Sep 2023 20:16:26 -0400
X-MC-Unique: rp7-sMFQOMq2qBIVuF9_4w-1
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1D27D85A5A8;
	Tue, 26 Sep 2023 00:16:26 +0000 (UTC)
Received: from f37-zws-nv (unknown [10.22.32.95])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id BBD712026D4B;
	Tue, 26 Sep 2023 00:16:25 +0000 (UTC)
Date: Mon, 25 Sep 2023 17:16:23 -0700
From: Kevin Buettner <kevinb@redhat.com>
To: Lancelot SIX <lsix@lancelotsix.com>
Cc: gdb-patches@sourceware.org, Jan Kratochvil <jan@jankratochvil.net>
Subject: Re: [PATCH] gdb/testsuite: Add relative versus absolute
 LD_LIBRARY_PATH test
Message-ID: <20230925171623.7acfa2c5@f37-zws-nv>
In-Reply-To: <20230925095710.k3xektglqa3z5v2g@octopus>
References: <20230922012236.3254533-2-kevinb@redhat.com>
	<20230925095710.k3xektglqa3z5v2g@octopus>
Organization: Red Hat
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gdb-patches.sourceware.org>

On Mon, 25 Sep 2023 10:57:10 +0100
Lancelot SIX <lsix@lancelotsix.com> wrote:

> > +extern __thread int var;  
> 
> I think you could replace __thread (a GCC___extension) with thread_local
> which was introduced in C11 (available in the <threads.h> header)[1].
> 
> This could require adding -std=c11 to additional_flags in the .exp file
> (not sure which C standard is picked by default by different versions of
> GCC).

I've made this change for v2.  In my testing on Fedora 38, it didn't seem
that additonal_flags=-std=c11 was required for gcc, but I made this change
anyway.  (I'd guess that it might be necessary for some older version of
gcc.)  Also, I found that testing with CC_FOR_TARGET=clang didn't work
(but not due to adding -std=c11), so I fixed that problem too.

Thanks for this suggestion!

Kevin