public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Kevin Buettner <kevinb@redhat.com>
To: Tom de Vries via Gdb-patches <gdb-patches@sourceware.org>
Cc: Tom de Vries <tdevries@suse.de>
Subject: Re: [PATCH] [gdb/testsuite] Add nopie to gdb.base/unwind-on-each-insn-amd64-2.exp
Date: Wed, 27 Sep 2023 19:10:45 -0700	[thread overview]
Message-ID: <20230927191045.61290109@f37-zws-nv> (raw)
In-Reply-To: <20230927072410.7000-1-tdevries@suse.de>

On Wed, 27 Sep 2023 09:24:10 +0200
Tom de Vries via Gdb-patches <gdb-patches@sourceware.org> wrote:

> When running test-case gdb.base/unwind-on-each-insn-amd64-2.exp with target
> board unix/-fPIE/-pie, I run into:
> ...
> gdb compile failed, ld: unwind-on-each-insn-amd64-21.o: relocation \
>   R_X86_64_32S against `.text' can not be used when making a PIE object; \
>   recompile with -fPIE
> ld: failed to set dynamic section sizes: bad value
> ...
> 
> Fix this by hardcoding nopie in the test-case, and for good measure in the
> other test-cases that source unwind-on-each-insn.exp.tcl and use a .s file.

Looks reasonable to me.

Approved-by: Kevin Buettner <kevinb@redhat.com>


      reply	other threads:[~2023-09-28  2:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-27  7:24 Tom de Vries
2023-09-28  2:10 ` Kevin Buettner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230927191045.61290109@f37-zws-nv \
    --to=kevinb@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).