From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 62DCB3858C31 for ; Mon, 2 Oct 2023 06:53:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 62DCB3858C31 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 7AA41215D5 for ; Mon, 2 Oct 2023 06:53:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1696229612; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=It5PeaYj3VPxvkrxoYZaUGhCq6zoQWO9VHV8Gb50HUI=; b=d2fCi8A+2xpqxsw/h58voOz0stnk7aLE2S4c2rZL42KjWW1cxurs+Ss57XjSacux4Bjyjz 0yA13haP7afRR+rHJU3nfOe4tvp3P0Ngp5IZ8ebmfWghKd925WzxguFs24/ab6kFJ4WG7V 5yPl8CpJFZCmoFA7gej93cM520XXMD8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1696229612; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=It5PeaYj3VPxvkrxoYZaUGhCq6zoQWO9VHV8Gb50HUI=; b=pnfFoJ4YJEkFE3WqOCFqLjpTNIfnIkvOTGqG7nlBqlBzjsMXkgBNAmZ6C2Ak+LzOksGHlm +mCGGqAPdUnUzWCw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6808A13456 for ; Mon, 2 Oct 2023 06:53:32 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id BBpKGOxoGmWHcQAAMHmgww (envelope-from ) for ; Mon, 02 Oct 2023 06:53:32 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH] [gdb/testsuite] Handle older gcc in gdb.ada/import.exp Date: Mon, 2 Oct 2023 08:53:36 +0200 Message-Id: <20231002065336.16778-1-tdevries@suse.de> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: When running test-case gdb.ada/import.exp with gcc 7, most test fail: ... FAIL: gdb.ada/import.exp: print imported_var_ada FAIL: gdb.ada/import.exp: print local_imported_var FAIL: gdb.ada/import.exp: print pkg.imported_var_ada FAIL: gdb.ada/import.exp: print pkg.exported_var_ada FAIL: gdb.ada/import.exp: print exported_var_ada FAIL: gdb.ada/import.exp: gdb_breakpoint: set breakpoint at pkg.imported_func_ada FAIL: gdb.ada/import.exp: gdb_breakpoint: set breakpoint at imported_func_ada FAIL: gdb.ada/import.exp: gdb_breakpoint: set breakpoint at local_imported_func ... When running with gcc 8 or 9, only 2 tests fail: ... FAIL: gdb.ada/import.exp: gdb_breakpoint: set breakpoint at pkg.imported_func_ada FAIL: gdb.ada/import.exp: gdb_breakpoint: set breakpoint at imported_func_ada ... The test-case passes fully with gcc 10, 11, 12 and 13. Debug info for pragma import seems to not have been supported before gcc 8, so require that version. The two FAILs with gcc 8 and 9 seem to be due to problems in debug info. Add an xfail for these. Tested on x86_64-linux. --- gdb/testsuite/gdb.ada/import.exp | 34 ++++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+) diff --git a/gdb/testsuite/gdb.ada/import.exp b/gdb/testsuite/gdb.ada/import.exp index 90cffa48e9c..73552483463 100644 --- a/gdb/testsuite/gdb.ada/import.exp +++ b/gdb/testsuite/gdb.ada/import.exp @@ -17,6 +17,12 @@ load_lib "ada.exp" require allow_ada_tests +# GCC with commit ff9baa5f1c5 ("DWARF: make it possible to emit debug info for +# declarations only") is required. The commit makes sure that file-scope +# function and variable declarations are emitted in dwarf. This allows the +# description of imported entries, making them available to the debugger. +require {expr [gcc_major_version] >= 8} + standard_ada_testfile prog set cfile "inc" @@ -48,8 +54,36 @@ gdb_test "print pkg.imported_var_ada" " = 42" gdb_test "print pkg.exported_var_ada" " = 99" gdb_test "print exported_var_ada" " = 99" +# This passes with gcc 10 but fails with gcc 9. With gcc 9, we have: +# <1><1659>: Abbrev Number: 4 (DW_TAG_subprogram) +# <165a> DW_AT_external : 1 +# <165a> DW_AT_name : pkg__imported_func_ada +# <165e> DW_AT_decl_file : 2 +# <165f> DW_AT_decl_line : 22 +# <1660> DW_AT_decl_column : 13 +# <1661> DW_AT_linkage_name: imported_func +# <1665> DW_AT_type : <0x1669> +# and with gcc 10 instead: +# <1><1670>: Abbrev Number: 4 (DW_TAG_subprogram) +# <1671> DW_AT_external : 1 +# <1671> DW_AT_name : pkg__imported_func_ada +# <1675> DW_AT_decl_file : 2 +# <1676> DW_AT_decl_line : 22 +# <1677> DW_AT_decl_column : 13 +# <1678> DW_AT_linkage_name: imported_func +# <167c> DW_AT_type : <0x1680> +# <1680> DW_AT_declaration : 1 +# The fact that things start to work when adding the DW_AT_declaration is +# consistent with what is described in commit ff9baa5f1c5, so xfail this +# (without pinpointing it to a specific gcc PR or commit). +if { [gcc_major_version] < 10 } { + setup_xfail *-*-* +} gdb_breakpoint "pkg.imported_func_ada" message gdb_breakpoint "imported_func" message +if { [gcc_major_version] < 10 } { + setup_xfail *-*-* +} gdb_breakpoint "imported_func_ada" message gdb_breakpoint "local_imported_func" message base-commit: f31a5e471e762e0d5507b4fa95d0dd114ef61448 -- 2.35.3