From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by sourceware.org (Postfix) with ESMTPS id 24B0F3857BB3 for ; Mon, 2 Oct 2023 12:50:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 24B0F3857BB3 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 6AD392185A for ; Mon, 2 Oct 2023 12:50:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1696251046; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=m7id4nB/XVog5LTSI7gXQCzu+L36fWwSqkPm5ftP/YY=; b=q9QlEdYbM0Ee0Vuwdu+E++/RqkdqxLrQYPg+vsqRp7lPM+gWRc987uG1YzzohZRVvSBfYg N5BkMIgzWQ9YOPo/ivPPcoQ+U5VSG/bzWjAoL5ySZgUxFebTnuvXQ+npoR+1MROWGYgatt +hKcZwrYfJoAnN97BN462E8E2OghEZE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1696251046; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=m7id4nB/XVog5LTSI7gXQCzu+L36fWwSqkPm5ftP/YY=; b=ad//Lvk/UnPwK6w0Q4wlwMnp7onbzjZq8aOI/paykswcEZrrgyDK07cyDYRUs1QdcSpsJ8 mR7gpdu6MkDkVMAA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 584A213434 for ; Mon, 2 Oct 2023 12:50:46 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id iACNFKa8GmVZMgAAMHmgww (envelope-from ) for ; Mon, 02 Oct 2023 12:50:46 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH 00/13] [gdb/symtab, cc-with-dwz] Fix gdb.cp/breakpoint-locs.exp Date: Mon, 2 Oct 2023 14:50:38 +0200 Message-Id: <20231002125051.29911-1-tdevries@suse.de> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: [ Submitted an earlier RFC version at https://sourceware.org/pipermail/gdb-patches/2023-September/202443.html. ] When running test-case gdb.cp/breakpoint-locs.exp with target board cc-with-dwz, we occasionally run into: ... FAIL: gdb.cp/breakpoint-locs.exp: break N1::C1::baz ... due to the breakpoint having one instead of two locations. This is PR symtab/30728. This series fixes it. The fix is dependent on the fix for PR symtab/30846, which is about incorrect parent entries in the cooked index, due to inter-cu (intra-shard and inter-shard) references. The series consists of three parts: - patches that fix PR symtab/30846. - patches that add two optimizations to the fix for PR symtab/30846 (one preparation patch, and two optimization patches), - the last patch, that fixes PR symtab/30728. The fix for PR symtab/30728 consists of adding entries to the cooked index for DW_TAG_inlined_subroutine DIEs, with correct parent entries. Tested on x86_64-linux, with target boards unix, cc-with-dwz and cc-with-dwz-m. I've split out the two added test-cases into separate patches. Unfortunately the patch "[gdb/symtab] Resolve deferred entries, inter-shard case" is still somewhat large due to moving code about. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30728 Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30846 Tom de Vries (13): [gdb/symtab] Factor out m_die_range_map usage [gdb/symtab] Check effect in parent_map::set_parent [gdb/symtab] Handle nullptr parent in parent_map::set_parent [gdb/symtab] Add parent_map::dump [gdb/symtab] Factor out m_deferred_entries usage [gdb/symtab] Add debug_handle_deferred_entries [gdb/symtab] Resolve deferred entries, inter-shard case [gdb/testsuite] Add gdb.dwarf2/forward-spec-inter-cu.exp [gdb/symtab] Keep track of processed DIEs in shard [gdb/symtab] Resolve deferred entries, intra-shard case [gdb/symtab] Don't defer backward refs, inter-cu intra-shard case [gdb/testsuite] Add gdb.dwarf2/backward-spec-inter-cu.exp [gdb/symtab] Add DW_TAG_inlined_subroutine entries in the cooked index for c++ gdb/addrmap.c | 19 +- gdb/addrmap.h | 7 +- gdb/dwarf2/cooked-index.c | 141 ++++++++++++++ gdb/dwarf2/cooked-index.h | 145 +++++++++++++- gdb/dwarf2/read.c | 178 +++++++++++++----- .../gdb.dwarf2/backward-spec-inter-cu.exp | 111 +++++++++++ .../gdb.dwarf2/forward-spec-inter-cu.exp | 107 +++++++++++ 7 files changed, 657 insertions(+), 51 deletions(-) create mode 100644 gdb/testsuite/gdb.dwarf2/backward-spec-inter-cu.exp create mode 100644 gdb/testsuite/gdb.dwarf2/forward-spec-inter-cu.exp base-commit: 6a6117ab0ffe18ea984abca84869eae799c1b346 -- 2.35.3