From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x136.google.com (mail-il1-x136.google.com [IPv6:2607:f8b0:4864:20::136]) by sourceware.org (Postfix) with ESMTPS id 6B2593858D38 for ; Tue, 3 Oct 2023 17:56:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6B2593858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-il1-x136.google.com with SMTP id e9e14a558f8ab-35135f69de2so4043455ab.2 for ; Tue, 03 Oct 2023 10:56:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1696355786; x=1696960586; darn=sourceware.org; h=to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=hbyj5W9cR+OUWhFufdLUUYfYb8hG5/XvfJmUjjc71rU=; b=Z3p1x1aQQKlLBFelWrK4h0vWRqO26143E9qkEBhwHj9ecABhdQYwN+MB+ct7bPPbtZ J/lbZfELM9L2c225bzUjn2uy6FJGl5MWFJjRXl0S5kTZwKgHIY0z7zCr87UagpSEzhtL Yz0PAlmL2vUMGy/rBAVM9HknQ2Eq+5xlLJeDSlLvJASVzA4sK36SgE9htaDWMX25ctTb IgaMy1RRJQalKmZZHxqpyWIytkw7k4HWtg8Cqa1PSb0e31PjTejHhc10xN6eKFnIwNi2 ZlYzv1LB6YNhvogkfTdinMjqW5/i6ZHaITlisRJTYtd4a04rcbO5p35ImmBKw9/O3jyM UIVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696355786; x=1696960586; h=to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hbyj5W9cR+OUWhFufdLUUYfYb8hG5/XvfJmUjjc71rU=; b=fai6mspYJqm72vL8crpXINNcvGDDJoVLjZII3SDcz7fEYcVaL43JJO+ZfkjZ3GVjCt DntCUOBmQqQPhr4iVPe3j71ilDpjvS+1fvgiXKgJISJA5bIb2ujiceb+mBDYtVb/YaXt 82bzdTqhnIvbQ7sKnAwodTtEE48X5rJyLsU6DpW+q61nmk5T3knkOowhbBDyPjt9puWY 4ij1BjHuwfEjzsmMGU+QufozPZ2h9NArbXW4M4omyuXSEuDnpwEVIz+km4Cp4PxIN7+F rGCFeVicVKN33qT64kh6AHasKAp7no+jI0rqu3R1OUUoDSyd7pzPQ95OiG3/idasw/MT tkWQ== X-Gm-Message-State: AOJu0YxxWMasyRkv7kc6PUHROo/pcrD1XInlnAUGN8LSoevali1tFXqe 4JgMk+05Bd5MV9S2lGflDJlkXuiF1ATOVVq9q9aEYg== X-Google-Smtp-Source: AGHT+IHtO8cKxFdpBP++x+W+7ULjvWChl+T+EA0Dj06H9mntBmkuEGbg5Lu9nEOujs4iTTazZrpvJw== X-Received: by 2002:a05:6e02:13d2:b0:34b:ae9b:d039 with SMTP id v18-20020a056e0213d200b0034bae9bd039mr170943ilj.18.1696355786689; Tue, 03 Oct 2023 10:56:26 -0700 (PDT) Received: from localhost.localdomain (71-211-130-31.hlrn.qwest.net. [71.211.130.31]) by smtp.gmail.com with ESMTPSA id t9-20020a028789000000b0042b326ed1ebsm486965jai.48.2023.10.03.10.56.26 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Oct 2023 10:56:26 -0700 (PDT) From: Tom Tromey Date: Tue, 03 Oct 2023 11:56:22 -0600 Subject: [PATCH 1/3] Minor cleanup in linux_proc_attach_tgid_threads MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20231003-attach-bug-v1-1-f5de2e583c5d@adacore.com> References: <20231003-attach-bug-v1-0-f5de2e583c5d@adacore.com> In-Reply-To: <20231003-attach-bug-v1-0-f5de2e583c5d@adacore.com> To: gdb-patches@sourceware.org X-Mailer: b4 0.12.3 X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: linux_proc_attach_tgid_threads computes a file name, and then re-computes it for a warning. It is better to reuse the already-computed name here. --- gdb/nat/linux-procfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/nat/linux-procfs.c b/gdb/nat/linux-procfs.c index 9c2d1beb91f..95ecae443e4 100644 --- a/gdb/nat/linux-procfs.c +++ b/gdb/nat/linux-procfs.c @@ -287,7 +287,7 @@ linux_proc_attach_tgid_threads (pid_t pid, dir = opendir (pathname); if (dir == NULL) { - warning (_("Could not open /proc/%ld/task."), (long) pid); + warning (_("Could not open %s."), pathname); return; } -- 2.40.1