From: John Baldwin <jhb@FreeBSD.org>
To: gdb-patches@sourceware.org
Cc: Willgerodt, Felix <felix.willgerodt@intel.com>,
George, Jini Susan <JiniSusan.George@amd.com>,
Simon Marchi <simon.marchi@polymtl.ca>
Subject: [RFC 08/13] x86-fbsd-nat: Support fetching TARGET_OBJECT_X86_CPUID objects
Date: Mon, 9 Oct 2023 11:36:10 -0700 [thread overview]
Message-ID: <20231009183617.24862-9-jhb@FreeBSD.org> (raw)
In-Reply-To: <20231009183617.24862-1-jhb@FreeBSD.org>
When probing for the cached XSAVE layout, fetch the CPUID note data
and cache it until needed for a future fetch via ::xfer_partial.
---
gdb/configure.nat | 6 ++++--
gdb/x86-fbsd-nat.c | 37 +++++++++++++++++++++++++++++++++++++
gdb/x86-fbsd-nat.h | 9 +++++++++
3 files changed, 50 insertions(+), 2 deletions(-)
diff --git a/gdb/configure.nat b/gdb/configure.nat
index 1dc4206b69c..4ed71d8619d 100644
--- a/gdb/configure.nat
+++ b/gdb/configure.nat
@@ -165,7 +165,8 @@ case ${gdb_host} in
;;
i386)
# Host: FreeBSD/i386
- NATDEPFILES="${NATDEPFILES} x86-nat.o nat/x86-dregs.o \
+ NATDEPFILES="${NATDEPFILES} x86-nat.o nat/x86-cpuid.o \
+ nat/x86-dregs.o
nat/x86-xstate.o x86-bsd-nat.o x86-fbsd-nat.o i386-fbsd-nat.o \
bsd-kvm.o"
;;
@@ -195,7 +196,8 @@ case ${gdb_host} in
i386)
# Host: FreeBSD/amd64
NATDEPFILES="${NATDEPFILES} amd64-nat.o \
- amd64-fbsd-nat.o bsd-kvm.o x86-nat.o nat/x86-dregs.o \
+ amd64-fbsd-nat.o bsd-kvm.o x86-nat.o nat/x86-cpuid.o \
+ nat/x86-dregs.o \
nat/x86-xstate.o x86-bsd-nat.o x86-fbsd-nat.o"
;;
esac
diff --git a/gdb/x86-fbsd-nat.c b/gdb/x86-fbsd-nat.c
index 240e228976c..14fd323a7fb 100644
--- a/gdb/x86-fbsd-nat.c
+++ b/gdb/x86-fbsd-nat.c
@@ -20,6 +20,7 @@
#include "defs.h"
#include "x86-fbsd-nat.h"
#ifdef PT_GETXSTATE_INFO
+#include "nat/x86-cpuid.h"
#include "nat/x86-xstate.h"
#endif
@@ -48,6 +49,40 @@ x86_fbsd_nat_target::low_new_fork (ptid_t parent, pid_t child)
}
#ifdef PT_GETXSTATE_INFO
+enum target_xfer_status
+x86_fbsd_nat_target::xfer_partial (enum target_object object,
+ const char *annex, gdb_byte *readbuf,
+ const gdb_byte *writebuf,
+ ULONGEST offset, ULONGEST len,
+ ULONGEST *xfered_len)
+{
+ switch (object)
+ {
+ case TARGET_OBJECT_X86_CPUID:
+ if (readbuf)
+ {
+ size_t size = m_cpuid_note_len;
+ if (offset >= size)
+ return TARGET_XFER_EOF;
+ size -= offset;
+ if (size > len)
+ size = len;
+
+ if (size == 0)
+ return TARGET_XFER_EOF;
+
+ memcpy (readbuf, m_cpuid_note.get () + offset, size);
+ *xfered_len = size;
+ return TARGET_XFER_OK;
+ }
+ return TARGET_XFER_E_IO;
+ default:
+ return fbsd_nat_target::xfer_partial (object, annex, readbuf,
+ writebuf, offset, len,
+ xfered_len);
+ }
+}
+
void
x86_fbsd_nat_target::probe_xsave_layout (pid_t pid)
{
@@ -56,6 +91,8 @@ x86_fbsd_nat_target::probe_xsave_layout (pid_t pid)
m_xsave_probed = true;
+ x86_cpuid_note (m_cpuid_note, m_cpuid_note_len);
+
if (ptrace (PT_GETXSTATE_INFO, pid, (PTRACE_TYPE_ARG3) &m_xsave_info,
sizeof (m_xsave_info)) != 0)
return;
diff --git a/gdb/x86-fbsd-nat.h b/gdb/x86-fbsd-nat.h
index 723bb6cf305..71b6ad09916 100644
--- a/gdb/x86-fbsd-nat.h
+++ b/gdb/x86-fbsd-nat.h
@@ -42,6 +42,13 @@ class x86_fbsd_nat_target : public x86bsd_nat_target<fbsd_nat_target>
x86_xsave_layout fetch_x86_xsave_layout () override
{ return m_xsave_layout; }
+ enum target_xfer_status xfer_partial (enum target_object object,
+ const char *annex,
+ gdb_byte *readbuf,
+ const gdb_byte *writebuf,
+ ULONGEST offset, ULONGEST len,
+ ULONGEST *xfered_len) override;
+
protected:
void probe_xsave_layout (pid_t pid);
@@ -49,6 +56,8 @@ class x86_fbsd_nat_target : public x86bsd_nat_target<fbsd_nat_target>
x86_xsave_layout m_xsave_layout;
private:
+ gdb::unique_xmalloc_ptr<gdb_byte> m_cpuid_note;
+ size_t m_cpuid_note_len;
bool m_xsave_probed;
#endif
};
--
2.41.0
next prev parent reply other threads:[~2023-10-09 18:36 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-09 18:36 [RFC 00/13] Proposal for a new NT_X86_CPUID core dump note John Baldwin
2023-10-09 18:36 ` [RFC 01/13] binutils: Support for the " John Baldwin
2023-10-16 9:23 ` Lancelot SIX
2023-10-16 23:23 ` John Baldwin
2023-10-09 18:36 ` [RFC 02/13] i387-tdep: Add function to read XSAVE layout from NT_X86_CPUID John Baldwin
2023-10-12 4:27 ` Simon Marchi
2023-10-16 23:52 ` John Baldwin
2023-10-16 9:17 ` Lancelot SIX
2023-10-17 0:04 ` John Baldwin
2023-10-09 18:36 ` [RFC 03/13] gdb: Use NT_X86_CPUID in x86 FreeBSD architectures to read XSAVE layouts John Baldwin
2023-10-09 18:36 ` [RFC 04/13] " John Baldwin
2023-10-12 4:28 ` Simon Marchi
2023-10-17 0:07 ` John Baldwin
2023-10-09 18:36 ` [RFC 05/13] nat/x86-cpuid.h: Remove non-x86 fallbacks John Baldwin
2023-10-12 4:29 ` Simon Marchi
2023-10-09 18:36 ` [RFC 06/13] nat/x86-cpuid: Add a function to build the contents of a NT_X86_CPUID note John Baldwin
2023-10-12 4:41 ` Simon Marchi
2023-10-17 0:22 ` John Baldwin
2023-10-09 18:36 ` [RFC 07/13] x86_elf_make_cpuid_note: Helper routine to build NT_X86_CPUID ELF note John Baldwin
2023-10-09 18:36 ` John Baldwin [this message]
2023-10-09 18:36 ` [RFC 09/13] fbsd-tdep: Export fbsd_make_corefile_notes John Baldwin
2023-10-09 18:36 ` [RFC 10/13] {amd64,i386}-fbsd-tdep: Include NT_X86_CPUID notes in core dumps from gcore John Baldwin
2023-10-16 9:31 ` [RFC 10/13] {amd64, i386}-fbsd-tdep: " Lancelot SIX
2023-10-17 0:26 ` John Baldwin
2023-10-09 18:36 ` [RFC 11/13] x86-linux-nat: Support fetching TARGET_OBJECT_X86_CPUID objects John Baldwin
2023-10-09 18:36 ` [RFC 12/13] linux-tdep: Export linux_make_corefile_notes John Baldwin
2023-10-09 18:36 ` [RFC 13/13] {amd64,i386}-linux-tdep: Include NT_X86_CPUID notes in core dumps from gcore John Baldwin
2023-10-10 16:30 ` [RFC 00/13] Proposal for a new NT_X86_CPUID core dump note George, Jini Susan
2023-10-12 4:01 ` Simon Marchi
2023-10-12 14:33 ` Simon Marchi
2023-10-12 17:18 ` John Baldwin
2023-10-13 9:38 ` George, Jini Susan
2023-10-17 0:36 ` John Baldwin
2023-10-26 16:18 ` George, Jini Susan
2023-10-27 2:53 ` John Baldwin
2023-10-27 11:11 ` George, Jini Susan
2023-10-31 16:41 ` John Baldwin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231009183617.24862-9-jhb@FreeBSD.org \
--to=jhb@freebsd.org \
--cc=JiniSusan.George@amd.com \
--cc=felix.willgerodt@intel.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).