From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Subject: [PATCH v2 0/4] [gdb/cli] Allow source highlighting to be interrupted
Date: Fri, 13 Oct 2023 14:19:49 +0200 [thread overview]
Message-ID: <20231013121953.25917-1-tdevries@suse.de> (raw)
I wrote this patch series to fix PR cli/30934.
The 1st patch is an unrelated optimization, which I added to this series
because it touches the same code.
The 2nd patch factors out a function.
The 3rd patch adds a means to keep track of styling failures in the
source cache, as suggested here (
https://sourceware.org/pipermail/gdb-patches/2023-October/203164.html ).
The 4th patch fixes the PR cli/30934.
This is v2. Changes since v1:
- fixed a build problem with --disable-source-highlight, reported by the linaro
CI.
- temporarily installs the default_quit_handler to be able to use QUIT
- added a question whether to interrupt highlighting or not
(in the RFC, I had a warning, in v1 I dropped it)
- added "gdb_assert (target_terminal::is_ours ())"
Adding the question was inspired by the v3 patch "gdb/debuginfod: Ctrl-C ask
to cancel further downloads" (
https://sourceware.org/pipermail/gdb-patches/2023-March/197679.html ).
Submission history:
- RFC:
https://sourceware.org/pipermail/gdb-patches/2023-October/203157.html
- v1:
https://sourceware.org/pipermail/gdb-patches/2023-October/203179.html
Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30934
Tom de Vries (4):
[gdb/cli] Skip string copy in source_cache::ensure
[gdb/cli] Factor out try_source_highlight
[gdb/cli] Keep track of styling failures in source_cache
[gdb/cli] Allow source highlighting to be interrupted
gdb/source-cache.c | 173 +++++++++++++++++++++++++++++++++++----------
gdb/source-cache.h | 4 ++
2 files changed, 141 insertions(+), 36 deletions(-)
base-commit: 9326300e4d3dbe943380b30766ed474d98df07ba
--
2.35.3
next reply other threads:[~2023-10-13 12:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-13 12:19 Tom de Vries [this message]
2023-10-13 12:19 ` [PATCH v2 1/4] [gdb/cli] Skip string copy in source_cache::ensure Tom de Vries
2023-10-13 16:34 ` Lancelot SIX
2023-10-16 7:40 ` Tom de Vries
2023-10-13 12:19 ` [PATCH v2 2/4] [gdb/cli] Factor out try_source_highlight Tom de Vries
2023-10-13 16:52 ` Lancelot SIX
2023-10-16 7:07 ` Tom de Vries
2023-10-16 8:25 ` Lancelot SIX
2023-10-13 12:19 ` [PATCH v2 3/4] [gdb/cli] Keep track of styling failures in source_cache Tom de Vries
2023-10-13 12:19 ` [PATCH v2 4/4] [gdb/cli] Allow source highlighting to be interrupted Tom de Vries
2023-10-13 17:00 ` Lancelot SIX
2023-10-16 7:47 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231013121953.25917-1-tdevries@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).