From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lndn.lancelotsix.com (lndn.lancelotsix.com [51.195.220.111]) by sourceware.org (Postfix) with ESMTPS id A8FCF3858CDB for ; Fri, 13 Oct 2023 22:28:37 +0000 (GMT) ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A8FCF3858CDB Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=51.195.220.111 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697236120; cv=none; b=DNT/OLug/jBpfcxlSBejpuT4jD1/wUWnQHJpRSUbf9HmSnpgAyruO1axLG4b3QYyBozBBTYr0FbYUYGJV1SYcFiBzoCHgWvawnCwjXn+18tIFKYmnRY0DbrHzJ1rOETXUXWFkiEN0tYccf7pCVZ2rVCK24y1EZxHWjpSD4rHdHc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697236120; c=relaxed/simple; bh=ieHOoCXV6OkgjI0RL/EymbdTP2AluFnFbTJD8kAzUuo=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=G8erOydwcsHl2bXJufnF8hgKU5VsfL8eIabrxmjyuLx5KwyzITnl7Y560WiqQZ7Aqs6FCzL/kqw7h3PTWicklMEeAUGAGsDPwzhOit7/VyNtS8CsUONeFnnU9mcdaKJ0W5XoQ3Tl8ham1hi7PyfC89Qs689SgyOYwCQ75OC7Uow= ARC-Authentication-Results: i=1; server2.sourceware.org DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A8FCF3858CDB Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=lancelotsix.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=lancelotsix.com Received: from octopus (cust120-dsl54.idnet.net [212.69.54.120]) by lndn.lancelotsix.com (Postfix) with ESMTPSA id 709A38A6AA; Fri, 13 Oct 2023 22:28:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=lancelotsix.com; s=2021; t=1697236116; bh=ieHOoCXV6OkgjI0RL/EymbdTP2AluFnFbTJD8kAzUuo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=g6Ed76PQrYYyvCDvpbPhXfITy4AHyU/BR7XcKAC/rpaSm8z5bx1/dVLkxNzzFTCPn tsyOBcLBZmohc0tHzqFMUOhCJdeVtMgm0lUq1Fy2XRDTnmK6pS1y0mvCh73fs1KBm7 3o/YHK8L9GYxgbBWsfPe5J8N8hGf669zzUuA2koNDdsHZ9cxXc40rA5DPvh4o1W6Kh X92Xg0H3And7YMzWGM2eMeaVhwq1dh5rRvFyJ5sTCcOCo2v68dvpmy1x+aZQAl5Rg6 r2tc70NqHLMGwiU2LeedefKU+5tbJTi7ZTnTqRHAyOsahSUuTp7fYyuqOuzNvQ0waU 6khVOy3fHxdog== Date: Fri, 13 Oct 2023 23:28:30 +0100 From: Lancelot SIX To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 20/24] gdb: make so_list::{so_original_name, so_name} std::strings Message-ID: <20231013222830.d3pi7di7ak4hiw57@octopus> References: <20231010204213.111285-1-simon.marchi@efficios.com> <20231010204213.111285-21-simon.marchi@efficios.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231010204213.111285-21-simon.marchi@efficios.com> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6.2 (lndn.lancelotsix.com [0.0.0.0]); Fri, 13 Oct 2023 22:28:36 +0000 (UTC) X-Spam-Status: No, score=-12.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Simon, On Tue, Oct 10, 2023 at 04:40:15PM -0400, Simon Marchi wrote: > Change these two fields, simplifying memory management and copying. > > Change-Id: If2559284c515721e71e1ef56ada8b64667eebe55 > --- > gdb/break-catch-load.c | 2 +- > gdb/breakpoint.c | 2 +- > gdb/bsd-uthread.c | 8 +++---- > gdb/mi/mi-cmd-file.c | 2 +- > gdb/solib-aix.c | 8 +++---- > gdb/solib-darwin.c | 5 ++--- > gdb/solib-dsbt.c | 5 ++--- > gdb/solib-frv.c | 6 ++---- > gdb/solib-rocm.c | 8 ++----- > gdb/solib-svr4.c | 25 ++++++++++------------ > gdb/solib-target.c | 18 ++++++---------- > gdb/solib.c | 47 +++++++++++++++++++++++------------------- > gdb/solist.h | 4 ++-- > 13 files changed, 63 insertions(+), 77 deletions(-) > > diff --git a/gdb/mi/mi-cmd-file.c b/gdb/mi/mi-cmd-file.c > index 822d3df40005..5f63ce4494cb 100644 > --- a/gdb/mi/mi-cmd-file.c > +++ b/gdb/mi/mi-cmd-file.c > @@ -167,7 +167,7 @@ mi_cmd_file_list_shared_libraries (const char *command, > { > if (so->so_name[0] == '\0') I think this should become "so->so_name.empty ()". > continue; > - if (pattern != NULL && !re_exec (so->so_name)) > + if (pattern != NULL && !re_exec (so->so_name.c_str ())) > continue; > > ui_out_emit_tuple tuple_emitter (uiout, NULL); > diff --git a/gdb/solib.c b/gdb/solib.c > index 6b7f0da0498d..1815b0910208 100644 > --- a/gdb/solib.c > +++ b/gdb/solib.c > @@ -1088,7 +1093,7 @@ info_sharedlibrary_command (const char *pattern, int from_tty) > { > if (so->so_name[0]) Similar here. > { > - if (pattern && ! re_exec (so->so_name)) > + if (pattern && ! re_exec (so->so_name.c_str ())) > continue; > ++nr_libs; > } > @@ -1109,7 +1114,7 @@ info_sharedlibrary_command (const char *pattern, int from_tty) > { > if (! so->so_name[0]) And here it should be "!so->empty ()". > continue; > - if (pattern && ! re_exec (so->so_name)) > + if (pattern && ! re_exec (so->so_name.c_str ())) > continue; > > ui_out_emit_tuple tuple_emitter (uiout, "lib"); I might have missed other patterns, I'll need to get back to it with fresher eyes. Best, Lancelot.