From: Lancelot SIX <lancelot.six@amd.com>
To: Simon Marchi <simon.marchi@efficios.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH 16/24] gdb: make clear_so a method of struct so_list
Date: Thu, 19 Oct 2023 12:08:24 +0100 [thread overview]
Message-ID: <20231019110824.vjuiao3wddrewpv6@khazad-dum> (raw)
In-Reply-To: <20231010204213.111285-17-simon.marchi@efficios.com>
Hi Simon,
On Tue, Oct 10, 2023 at 04:40:11PM -0400, Simon Marchi wrote:
> ... just because it seems to make sense to do so.
>
> Change-Id: Ie283c92d9b90c54e3deee96a43c6a942d8b5910b
> ---
> gdb/solib.c | 35 ++++++++++++++---------------------
> gdb/solist.h | 10 ++++++++++
> 2 files changed, 24 insertions(+), 21 deletions(-)
>
> diff --git a/gdb/solib.c b/gdb/solib.c
> index 5ed223b8dfca..8f5b6e02e71c 100644
> --- a/gdb/solib.c
> +++ b/gdb/solib.c
> @@ -623,39 +623,32 @@ solib_map_sections (so_list &so)
> return 1;
> }
>
> -/* Free symbol-file related contents of SO and reset for possible reloading
> - of SO. If we have opened a BFD for SO, close it. If we have placed SO's
> - sections in some target's section table, the caller is responsible for
> - removing them.
> +/* See solist.h. */
>
> - This function doesn't mess with objfiles at all. If there is an
> - objfile associated with SO that needs to be removed, the caller is
> - responsible for taking care of that. */
> -
> -static void
> -clear_so (so_list &so)
> +void
> +so_list::clear ()
> {
> const target_so_ops *ops = gdbarch_so_ops (current_inferior ()->arch ());
>
> - delete so.sections;
> - so.sections = NULL;
> + delete this->sections;
> + this->sections = NULL;
That's just a nit, but while at touching those lines, the NULL could be
changed to nullptr.
Best,
Lancelot.
>
> - gdb_bfd_unref (so.abfd);
> - so.abfd = NULL;
> + gdb_bfd_unref (this->abfd);
> + this->abfd = NULL;
>
> /* Our caller closed the objfile, possibly via objfile_purge_solibs. */
> - so.symbols_loaded = 0;
> - so.objfile = NULL;
> + this->symbols_loaded = 0;
> + this->objfile = NULL;
>
> - so.addr_low = so.addr_high = 0;
> + this->addr_low = this->addr_high = 0;
>
> /* Restore the target-supplied file name. SO_NAME may be the path
> of the symbol file. */
> - strcpy (so.so_name, so.so_original_name);
> + strcpy (this->so_name, this->so_original_name);
>
> /* Do the same for target-specific data. */
> if (ops->clear_so != NULL)
> - ops->clear_so (so);
> + ops->clear_so (*this);
> }
>
> lm_info::~lm_info () = default;
> @@ -674,7 +667,7 @@ lm_info::~lm_info () = default;
> void
> free_so (so_list &so)
> {
> - clear_so (so);
> + so.clear ();
> delete &so;
> }
>
> @@ -1358,7 +1351,7 @@ reload_shared_libraries_1 (int from_tty)
> && !solib_used (so))
> so->objfile->unlink ();
> current_program_space->remove_target_sections (so);
> - clear_so (*so);
> + so->clear ();
> }
>
> /* If this shared library is now associated with a new symbol
> diff --git a/gdb/solist.h b/gdb/solist.h
> index 5f9090a07c72..75e8e8ad0182 100644
> --- a/gdb/solist.h
> +++ b/gdb/solist.h
> @@ -38,6 +38,16 @@ using lm_info_up = std::unique_ptr<lm_info>;
>
> struct so_list
> {
> + /* Free symbol-file related contents of SO and reset for possible reloading
> + of SO. If we have opened a BFD for SO, close it. If we have placed SO's
> + sections in some target's section table, the caller is responsible for
> + removing them.
> +
> + This function doesn't mess with objfiles at all. If there is an
> + objfile associated with SO that needs to be removed, the caller is
> + responsible for taking care of that. */
> + void clear () ;
> +
> /* The following fields of the structure come directly from the
> dynamic linker's tables in the inferior, and are initialized by
> current_sos. */
>
> --
> 2.42.0
>
next prev parent reply other threads:[~2023-10-19 11:08 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-10 20:39 [PATCH 00/24] C++ification " Simon Marchi
2023-10-10 20:39 ` [PATCH 01/24] gdb: remove empty clear_solib functions Simon Marchi
2023-10-10 20:39 ` [PATCH 02/24] gdb: add program_space parameter to target_so_ops::clear_solib Simon Marchi
2023-10-17 14:57 ` Pedro Alves
2023-10-17 15:19 ` Simon Marchi
2023-10-10 20:39 ` [PATCH 03/24] gdb: make interps_notify work with references Simon Marchi
2023-10-11 8:48 ` Lancelot SIX
2023-10-11 14:18 ` Simon Marchi
2023-10-10 20:39 ` [PATCH 04/24] gdb: replace some so_list parameters to use references Simon Marchi
2023-10-19 11:07 ` [PATCH 4/24] " Lancelot SIX
2023-10-19 14:49 ` Simon Marchi
2023-10-19 15:20 ` Lancelot SIX
2023-10-19 16:07 ` Simon Marchi
2023-10-10 20:40 ` [PATCH 05/24] gdbsupport: use "reference" and "pointer" type aliases in intrusive_list Simon Marchi
2023-10-10 20:40 ` [PATCH 06/24] gdbsupport: make intrusive_list's disposer accept a reference Simon Marchi
2023-10-12 19:05 ` Pedro Alves
2023-10-14 20:12 ` Simon Marchi
2023-10-10 20:40 ` [PATCH 07/24] gdb: make get_cbfd_soname_build_id static Simon Marchi
2023-10-10 20:40 ` [PATCH 08/24] gdb: allocate so_list with new, deallocate with delete Simon Marchi
2023-10-10 20:40 ` [PATCH 09/24] gdb: rename lm_info_base to lm_info Simon Marchi
2023-10-10 20:40 ` [PATCH 10/24] gdb: remove target_so_ops::free_so Simon Marchi
2023-10-10 20:40 ` [PATCH 11/24] gdb: use gdb::checked_static_cast when casting lm_info Simon Marchi
2023-10-10 20:40 ` [PATCH 12/24] gdb: make solib-svr4 not use so_list internally Simon Marchi
2023-10-13 17:52 ` Lancelot SIX
2023-10-14 19:59 ` Simon Marchi
2023-10-19 11:08 ` Lancelot SIX
2023-10-19 14:50 ` Simon Marchi
2023-10-10 20:40 ` [PATCH 13/24] gdb: make solib-rocm " Simon Marchi
2023-10-13 18:35 ` Lancelot SIX
2023-10-14 20:00 ` Simon Marchi
2023-10-17 15:23 ` Pedro Alves
2023-10-17 15:32 ` Simon Marchi
2023-10-10 20:40 ` [PATCH 14/24] gdb: remove lm_info_vector typedef Simon Marchi
2023-10-10 20:40 ` [PATCH 15/24] gdb: make so_list::lm_info a unique_ptr Simon Marchi
2023-10-10 20:40 ` [PATCH 16/24] gdb: make clear_so a method of struct so_list Simon Marchi
2023-10-19 11:08 ` Lancelot SIX [this message]
2023-10-19 14:52 ` Simon Marchi
2023-10-10 20:40 ` [PATCH 17/24] gdb: remove target_section_table typedef Simon Marchi
2023-10-10 20:40 ` [PATCH 18/24] gdb: make so_list::sections not a pointer Simon Marchi
2023-10-10 20:40 ` [PATCH 19/24] gdb: make so_list::abfd a gdb_bfd_ref_ptr Simon Marchi
2023-10-10 20:40 ` [PATCH 20/24] gdb: make so_list::{so_original_name,so_name} std::strings Simon Marchi
2023-10-13 22:28 ` [PATCH 20/24] gdb: make so_list::{so_original_name, so_name} std::strings Lancelot SIX
2023-10-14 20:01 ` Simon Marchi
2023-10-19 11:08 ` [PATCH 20/24] gdb: make so_list::{so_original_name,so_name} std::strings Lancelot SIX
2023-10-19 14:55 ` Simon Marchi
2023-10-10 20:40 ` [PATCH 21/24] gdb: link so_list using intrusive_list Simon Marchi
2023-10-17 19:14 ` Pedro Alves
2023-10-17 19:38 ` Simon Marchi
2023-10-10 20:40 ` [PATCH 22/24] gdb: don't call so_list::clear in free_so Simon Marchi
2023-10-10 20:40 ` [PATCH 23/24] gdb: remove free_so function Simon Marchi
2023-10-10 20:49 ` [PATCH 24/24] gdb: rename struct so_list to so Simon Marchi
2023-10-17 19:20 ` [PATCH 00/24] C++ification of struct so_list Pedro Alves
2023-10-17 19:53 ` Simon Marchi
2023-10-20 14:40 ` Pedro Alves
2023-10-19 11:09 ` [PATCH 0/24] " Lancelot SIX
2023-10-19 14:57 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231019110824.vjuiao3wddrewpv6@khazad-dum \
--to=lancelot.six@amd.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).