From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2089.outbound.protection.outlook.com [40.107.93.89]) by sourceware.org (Postfix) with ESMTPS id 6744C3857354 for ; Thu, 19 Oct 2023 11:08:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6744C3857354 Authentication-Results: sourceware.org; dmarc=fail (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6744C3857354 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.93.89 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1697713733; cv=pass; b=P0NCQkJCq3G+0UE05XPz7FSbCIVZ99E4+kBunXbD812c3VjgLqr3yWfZfv6uX2hpGvgQkXQgmV6gdkWoRkKOyQttZWUeqGFyJE5ngSRoJINLOueMCXJJa+slPgSv+AieBasQIBskNa+Uua0eJKBsKjn5cqLFRRzSWj8jcBSRnzA= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1697713733; c=relaxed/simple; bh=/hLbP26IVJ9tJ8eyLWtc4xa0mCdde/dgpL6fL/tgA60=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=E9D9hb2JowFtk4VRO/YWXK5q2CbdV1YpusIaMUB/4Zfo7cDF2PzNoaXapH5v0otdv/ljgiqKAqAt2nB74A63rDjz7/1sSpHl4xcXhzkZSH64k7Je2IBehvb8Tig48xpvpZgGHG6HlhJt6gYtmyPP+1p/NfUcw3sHy3W2TYN9HF0= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EfKeXhOIQoXeqYYKwGNiRAJLYuAK++Q6Fi+o5MI0Ia/P1s0XscAjigOFav00pktLlqBJ8RuMhJcK04tIapkAFLgCJKq4h0xL6/DNX+7wB0opUpBLb7SJJy318UDCjjST1ic8OmHW0sd6VP3Q4uxA1X8JlPPC3ZSESQWHoMR1q9hw5xTbubmhiQM+AD273ylvOizkmjAu93kjx2d7mKKlwepm7py/8FIxWLYF9vWG7N2H2yRpahGkVD/Loz5/dT8hh1SU8sNvBvMjQd9H+7/bCNbJTajak20lBEd1X51Litz0oVRHj7H61yqFdSzfBKPnxC5nEOw5TNs0e69QizuuaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DfBvVMhQX3DWY7txlQ8iKV13uS/ymcR1R6xzD1Q9SXw=; b=EHJ4d5UIURGTVsvV0hKbv7J3MpA821UgeIqq9xQmTi9yxODM9knlWzK5pwrc3kwW2qxNaLsX+xmpaPyMw0+WlwlfRTQYj/sfASxS02sqV9Z9UmaiwwfJMEwEIfMONLpxUSQ89Q+POJuRht9HMQJyhcSG06Moji2DXrjFgDfjckHJ2M8zlMsC2mGXKX9HNdoRIA2DWMCNzZqY12lGHPxyjXd6S8+46zJSzDPASO9khQDcj535ckFRdxrsvcoMnU4J9bVk5ZSJfVXaiRuoJHTKTuthgCyZA5tu7tmVClAPSMh+dKoUgCiM13n/vDsQiJZQWOft1VBRXnSVaA8EYX0hfw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=efficios.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DfBvVMhQX3DWY7txlQ8iKV13uS/ymcR1R6xzD1Q9SXw=; b=4zEBajX2VeQBz/3K5h74Fn5vmpglaUDbytqB7eL9Xtx3GzhhhFzdGfNjYtgu6NPddCZB4adgM4sZp85zsHr20BW1tc4vdH80GvPuBkOYTBwnHG61Ru5D5Y3yhiKUN7spu3lq38luWXMYH5gjlfBGiiZwReKjs9q7JwzEHjve7EQ= Received: from DS7PR03CA0006.namprd03.prod.outlook.com (2603:10b6:5:3b8::11) by DS7PR12MB5720.namprd12.prod.outlook.com (2603:10b6:8:73::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.41; Thu, 19 Oct 2023 11:08:48 +0000 Received: from DS2PEPF00003448.namprd04.prod.outlook.com (2603:10b6:5:3b8:cafe::ca) by DS7PR03CA0006.outlook.office365.com (2603:10b6:5:3b8::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.21 via Frontend Transport; Thu, 19 Oct 2023 11:08:48 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by DS2PEPF00003448.mail.protection.outlook.com (10.167.17.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6907.20 via Frontend Transport; Thu, 19 Oct 2023 11:08:48 +0000 Received: from khazad-dum (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 19 Oct 2023 06:08:46 -0500 Date: Thu, 19 Oct 2023 12:08:39 +0100 From: Lancelot SIX To: Simon Marchi CC: Subject: Re: [PATCH 20/24] gdb: make so_list::{so_original_name,so_name} std::strings Message-ID: <20231019110839.v4he4o4jw7jnj7i6@khazad-dum> References: <20231010204213.111285-1-simon.marchi@efficios.com> <20231010204213.111285-21-simon.marchi@efficios.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20231010204213.111285-21-simon.marchi@efficios.com> X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS2PEPF00003448:EE_|DS7PR12MB5720:EE_ X-MS-Office365-Filtering-Correlation-Id: 373a7bad-339c-45b0-c62a-08dbd093c4a3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: azOICJIsu41p6xAwmH4HBguo87+pJRvFdMmcpWQZIMpwvxOzxPo4qvOvIVvw4NIDXlZJD2/Nz5l3QgdJn1W/k2qbweRiw44f8JsgoZuye5m7YW7jv+kSL2fCEA4BtkXRttrBin65BiKiQOmSng++quth8oY0PGnvmfIcjqnflRGVktbhFX4KY5JLUztgvx453gphgYjCH54wkiQ+u8PuojPGh1BpnfekaxHCkNqOLLrQLRtdIa+EATcQ9naoPNagW2Hecb8PxXl47yp8xN9b59q+x8s+eFANYli+YTk5sz/ts3ETWU7Q2ixBb7rswRJB8QUT9/1jFXOx4tvpL7QU8UAICFvJ1qx+aLV9E23Y6ykkO6Wh6qbxvltMlcUM0CYFaD188o01sG6loPhNCkRc0LLtSSfIzdYFx+ZlmWBbH51eCUCLKmNZKDR9rm5VXRKee+mHcinffS+GCJPTQuTgi8+6GYxbSwIZAMCv0SobIB4usYpv0iU9b/pLJyRy1xNW1s4TVDOB/Rkyexthgiw9k9Qwi8AIIhJlCUZ8xgbhz1Gka1l9GeNY4fS6VIyMUeI4PHpgUfEe9j54meugXhMsqKVvIGkoNVZ97bzgbcTA/+PFoe1r1QuhFyEFYWZWq7IA970r6rpSgwQgWeEcUjqctIUzrPtReBOft92gI1K9UrlAdKVdTm+VUuNVlg/9Qo8sbKQyaTXIgt88MaNDCa/7onfjQeImp7tWocDwWdFNUjjirxvu+4HIo8t2Z3Vz0X0ucinIpAsHccMI7/z4bmuEYw== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(4636009)(39860400002)(136003)(346002)(396003)(376002)(230922051799003)(1800799009)(64100799003)(451199024)(186009)(82310400011)(36840700001)(40470700004)(46966006)(33716001)(40460700003)(55016003)(47076005)(5660300002)(4326008)(41300700001)(86362001)(2906002)(83380400001)(9686003)(1076003)(82740400003)(16526019)(81166007)(26005)(336012)(426003)(356005)(36860700001)(40480700001)(6666004)(478600001)(8936002)(8676002)(70206006)(70586007)(6916009)(316002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2023 11:08:48.0113 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 373a7bad-339c-45b0-c62a-08dbd093c4a3 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS2PEPF00003448.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB5720 X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Simon, Some other minor NULL -> nullptr possible conversions below. On Tue, Oct 10, 2023 at 04:40:15PM -0400, Simon Marchi wrote: > Change these two fields, simplifying memory management and copying. > > Change-Id: If2559284c515721e71e1ef56ada8b64667eebe55 > --- > gdb/break-catch-load.c | 2 +- > gdb/breakpoint.c | 2 +- > gdb/bsd-uthread.c | 8 +++---- > gdb/mi/mi-cmd-file.c | 2 +- > gdb/solib-aix.c | 8 +++---- > gdb/solib-darwin.c | 5 ++--- > gdb/solib-dsbt.c | 5 ++--- > gdb/solib-frv.c | 6 ++---- > gdb/solib-rocm.c | 8 ++----- > gdb/solib-svr4.c | 25 ++++++++++------------ > gdb/solib-target.c | 18 ++++++---------- > gdb/solib.c | 47 +++++++++++++++++++++++------------------- > gdb/solist.h | 4 ++-- > 13 files changed, 63 insertions(+), 77 deletions(-) > > diff --git a/gdb/break-catch-load.c b/gdb/break-catch-load.c > index 94d8b420d327..999de874d5f6 100644 > --- a/gdb/break-catch-load.c > +++ b/gdb/break-catch-load.c > @@ -120,7 +120,7 @@ solib_catchpoint::check_status (struct bpstat *bs) > for (so_list *iter : current_program_space->added_solibs) > { > if (!regex > - || compiled->exec (iter->so_name, 0, NULL, 0) == 0) > + || compiled->exec (iter->so_name.c_str (), 0, NULL, 0) == 0) While at touching this line, s/NULL/nullptr. > return; > } > } > diff --git a/gdb/mi/mi-cmd-file.c b/gdb/mi/mi-cmd-file.c > index 822d3df40005..5f63ce4494cb 100644 > --- a/gdb/mi/mi-cmd-file.c > +++ b/gdb/mi/mi-cmd-file.c > @@ -167,7 +167,7 @@ mi_cmd_file_list_shared_libraries (const char *command, > { > if (so->so_name[0] == '\0') > continue; > - if (pattern != NULL && !re_exec (so->so_name)) > + if (pattern != NULL && !re_exec (so->so_name.c_str ())) Same. > continue; > > ui_out_emit_tuple tuple_emitter (uiout, NULL); > diff --git a/gdb/solib.c b/gdb/solib.c > index 6b7f0da0498d..1815b0910208 100644 > --- a/gdb/solib.c > +++ b/gdb/solib.c > @@ -705,9 +708,10 @@ solib_read_symbols (so_list &so, symfile_add_flags flags) > section_addr_info sap > = build_section_addr_info_from_section_table (so.sections); > gdb_bfd_ref_ptr tmp_bfd = so.abfd; > - so.objfile = symbol_file_add_from_bfd (tmp_bfd, so.so_name, > - flags, &sap, > - OBJF_SHARED, NULL); > + so.objfile = symbol_file_add_from_bfd (tmp_bfd, > + so.so_name.c_str (), > + flags, &sap, > + OBJF_SHARED, NULL); Same. > so.objfile->addr_low = so.addr_low; > } > Best, Lancelot.