From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2083.outbound.protection.outlook.com [40.107.100.83]) by sourceware.org (Postfix) with ESMTPS id 44DFC3857732 for ; Thu, 19 Oct 2023 11:09:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 44DFC3857732 Authentication-Results: sourceware.org; dmarc=fail (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 44DFC3857732 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.100.83 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1697713759; cv=pass; b=xSBdLecWW7VeMts5zxrCYYVXQKMp1G5PA6rkgDxTy3aoSNsvxzox2NPMPdsUqlrCDP2TO3PPaSdwHnXFGayCORlUSz8f7URn3O7Q1oSoJ4KOFQ8oY8t2zwrJXIIpTUUvlm7wgOeyBdDcePgz3pJZiRnMKtfXe8zzwZSfspDbJqU= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1697713759; c=relaxed/simple; bh=o5qw6KYq52MOn6fmO/jKobT+k+b8nLWZyWLPyZHmz8M=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=NUG3CszSAF+6eMQy17H/MAx0hjFQTwrlUBpPyuyIXJW/YxTsveAKSuJPULuvkQyl0lP0eDZvCZkgS3X+4gXDfN0GYM3+2HYYjlhC2KSQh6rk6NyMRgvVMJoomxNL3/yDu3oUak1a2HpesW+jHwmY/mlooIv8M0+Vt4/Rx2j3dkI= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Qjryj9zC28mlmBRtqy7GWNC994cl0JM7UObRVN9EUDuOKUKvWlrqKoiWjnT69FDDiP9kvr2/6Q9A38YX3fdE3wVF30JZruDyvjHnPJrbMrvzwHmra4mXKPfsuLGHb76qCryooK9eUDtz4glOnWNMKW9KFxqTqDig4CJvmYTDwNr3NKbm5O7RBZzEt6FfXk5YlL/zUkIYt6JEilCaAbwIetxWnFgAKDsn/jSz8NpPmKWWv1amxTFWypqpKIPXMWRfjLQ4rXOooosDCo0hQmrhY6Hq6MQseo90OgXWBaQ1UOg7ens3etfaXwXZz0fek2xf77VqWQ1HjLP+eeVQqOs/xQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=W232nfqZRnh3Aj7TmKzsG4z4AUn+cWwJdG3FtsyIMpo=; b=Mzcs88SuTs+j5E4lXXQsuHxxd4msqxHJtCsxKsfmeNF6WK5g2doXMAlkzgNHcqfUZeGHLxCe//71LTxAj3LJQqdIYWqVcvDbAkMKxNc26/jJwkqpU3TObZDOb0+pmlqfGUMs+rNxu6UnbEsSiDNd6u7wm+rAcQmX+9DzEVZlQiZeoM42HTt8+SvAmqjWFfNGpVTGqRrIlbU//BvdSo4jq/AL+9A+bXxnxHTkSVA2z+KcBauN/RoUSY7nEJ+383pvudeWquCVSRt2k6EALQ8OeXWVjYu1djuez68sLyfeCjqLwp+zxfrnh+MOS+hI7T7Pt4ecO/A1dQHl1NRm9VspBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=efficios.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=W232nfqZRnh3Aj7TmKzsG4z4AUn+cWwJdG3FtsyIMpo=; b=YCqbOB1HVJeZQ3MkHz7//8WbmYBHRvXycy+GjFQGEOSW4zuhP65kapyWuamZGmS3ZjXsqNla5bSCi3nQQQP56wqxVtUzYnwNVqsQs/vFUkik3TdF0A2XwMebtY/whSoSYNyszd6eL1XaAxM1XuZ2HlLagFDYcXCX7uZVH9SkKWY= Received: from DS7PR05CA0033.namprd05.prod.outlook.com (2603:10b6:8:2f::20) by DM4PR12MB5916.namprd12.prod.outlook.com (2603:10b6:8:69::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.35; Thu, 19 Oct 2023 11:09:16 +0000 Received: from DS2PEPF00003442.namprd04.prod.outlook.com (2603:10b6:8:2f:cafe::5d) by DS7PR05CA0033.outlook.office365.com (2603:10b6:8:2f::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.7 via Frontend Transport; Thu, 19 Oct 2023 11:09:15 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by DS2PEPF00003442.mail.protection.outlook.com (10.167.17.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6907.21 via Frontend Transport; Thu, 19 Oct 2023 11:09:15 +0000 Received: from khazad-dum (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 19 Oct 2023 06:09:13 -0500 Date: Thu, 19 Oct 2023 12:09:06 +0100 From: Lancelot SIX To: Simon Marchi CC: Subject: Re: [PATCH 0/24] C++ification of struct so_list Message-ID: <20231019110906.p3osckf6hkbz2dj3@khazad-dum> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20231010204213.111285-1-simon.marchi@efficios.com> X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS2PEPF00003442:EE_|DM4PR12MB5916:EE_ X-MS-Office365-Filtering-Correlation-Id: 454471af-d4e6-4d48-4934-08dbd093d53c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dJsI7ZTyLEgYXMSoUC3lfgTKXRtm71xameYUPq716PJ/K7RaTLGAR3JIG3eq1FnjvT/THCIQPIlH/GklRP93rGMYba01fBp5+tsvDwPporG+kJEzJvXCfnrSXDC8cdOLVbQIi8EJBOGHeo3DcGdoRbIu3xpRRfU79OCwa7L5LRjnfyYQhkf58hBjXA9YZETBeAF3zi4J0dSTg7ks0IXHI9zv7x1sIS+ZVZSrBCdpNe5SVVQxvnv2ek6al7vmcr0kUxvepJHZuGy69pIWP3dNWWgDmjQMvZ+eQUe1iX9lBidG3TE+9T2VNDUegb/rY5Ta9bboMJz0XEr+WFQCxzf9UVXq3P98PqGjfBgAG+lHCHy+HLyjtPWIOZR+ULXcEaFpWnTcu9F2298PVbGeNcq4O+vIgz+SEpRjPGTlb0uUJDuB1K126qQFurLrKNTtMayYEVfWD0hw5EHlxzH4HMu38BUEf2vf06DPMdLRAYh39hTRN1jqvoHPYHGk0NyIcSlD7f4hKETalA+c+uzPp9YAd41ScMzYL6sdV271Dbib8fnRuebGEUdZZgyZ9PI7+PXF0CczM+oEYMGbrUyY/7/Z1VdRTxyCtUNOl48LgOLIi4+0tmKo7/eyvlU06gy0EkbpLjttT+Bcq3Z4WA06fGXVsAsOkIBDUDFz5ZhFjzBH6CuXdfryQmVpUBvizxwqprMyjCnQmxOc771o5UfpK/i+ew== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(4636009)(230922051799003)(1800799009)(82310400011)(186009)(451199024)(46966006)(36840700001)(4744005)(2906002)(55016003)(70586007)(70206006)(316002)(47076005)(36860700001)(81166007)(6666004)(356005)(9686003)(33716001)(6916009)(86362001)(508600001)(426003)(16526019)(26005)(5660300002)(336012)(8936002)(1076003)(8676002)(4326008)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2023 11:09:15.8543 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 454471af-d4e6-4d48-4934-08dbd093d53c X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS2PEPF00003442.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5916 X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Simon, I went through the series again, sent a few extra small remarks, and FWIW, it looks reasonable to me. I do agree with Pedro's point that "struct so" becomes a bit harder to search for, and "shobj" would have less false-positives, but I nevertheless ok with using "so". If it turns out to be a hurdle, we can always change it later. I have tested the AMDGPU part of the series (gdb.rocm/*.exp), both on top of master and downstream ROCgdb. So with the various nits fixed: Reviewed-By: Lancelot Six Thanks for doing this! Lancelot.