From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by sourceware.org (Postfix) with ESMTPS id 1FFB53858CDA for ; Tue, 24 Oct 2023 09:48:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1FFB53858CDA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1FFB53858CDA Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:67c:2178:6::1c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698140928; cv=none; b=ANrr0L8gzo0PXWxqT3ORrUOL2uUlx/PRc0pJU7eBc9P4JDQzQWzxqxWvPGvReR9NVPWVPYSFWddd4DHrZoBNv1B+UyQbO2Ds5vzySQRK8ngqW/2H7ZoMrjt5eaLd1TMWmto6B+ZDfqd9+bWQggJPlyWzKuHKUYFVSNzX/Uu207o= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698140928; c=relaxed/simple; bh=nhOhYOqpj6n6l7d2z4FSqB9gm32OJj0JpAuiEY2egjk=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-Id: MIME-Version; b=g05S+kCWKS8tI370gGQ3bm/dj0Q3UatEbvrnDLnifKTkhHDc24Na1oS1HtIrSVdmiVUgHoxRBpciTEhoDbmb7CcF2Ja4q028BCdBFI8hUEAAZz/wmTJklphrw5ZFXDbapg6ZxRkIgUeIWO6YVIM2o1D1xeb0sF15T5zQR4ARjpk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 4846E21B98 for ; Tue, 24 Oct 2023 09:48:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1698140926; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2QJlaSI1f6cGSGiFhK+WU1HJrnhSOsEAO8Yjzdg022E=; b=LpaYP3ZjM8Z3vIqdiY2D1kizgIHbKe+5Zd516ixcu/fPyL3CLB0qUSpppLrs3zr/7Y6k8N rlbIRA9Vq1vAxe5ORa7X0d8iUks0QULHvgLnycq6Rt8mtrk3Nx5texPojN28ntJCIpE3Em cwZ4LnjE4bkxcvTeOpzYAoY2et+drWM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1698140926; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2QJlaSI1f6cGSGiFhK+WU1HJrnhSOsEAO8Yjzdg022E=; b=48TS9uJMoPBUI1tMv6eoVZZYFxldwysRGfUKW4ydzmWjN/zz4zRvBacA1ptVM4OublAwG/ MiF+vmirgY7U0vAw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 325D613A96 for ; Tue, 24 Oct 2023 09:48:46 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id gPBHC/6SN2UhEQAAMHmgww (envelope-from ) for ; Tue, 24 Oct 2023 09:48:46 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH v5 2/6] [gdb/python] Make python selftest more robust Date: Tue, 24 Oct 2023 11:49:29 +0200 Message-Id: <20231024094933.12009-3-tdevries@suse.de> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20231024094933.12009-1-tdevries@suse.de> References: <20231024094933.12009-1-tdevries@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Authentication-Results: smtp-out1.suse.de; none X-Spam-Level: X-Spam-Score: -1.81 X-Spamd-Result: default: False [-1.81 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; R_MISSING_CHARSET(2.50)[]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; BROKEN_CONTENT_TYPE(1.50)[]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; RCPT_COUNT_ONE(0.00)[1]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_LONG(-3.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; BAYES_HAM(-2.71)[98.74%] X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: When running the python selftest, we call raise directly: ... scoped_restore save_hook = make_scoped_restore (&hook_set_active_ext_lang, []() { raise (SIGINT); }); ... While this tests the signal handling in its natural form, it runs the risk of interference from other signals. Instead: - use signal_handler_selftest to isolate the selftest from user signals, and - use "handle_sigint (SIGINT)" to deliver the signal. Tested on x86_64-linux. --- gdb/python/python.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/gdb/python/python.c b/gdb/python/python.c index d569fb5a3e4..00e8968d3ed 100644 --- a/gdb/python/python.c +++ b/gdb/python/python.c @@ -39,6 +39,7 @@ #if GDB_SELF_TEST #include "gdbsupport/selftest.h" +#include "event-top.h" #endif /* Declared constants and enum for python stack printing. */ @@ -2246,11 +2247,15 @@ test_python () SELF_CHECK (output.empty ()); } + signal_handler_selftest a_signal_handler_selftest; + if (!a_signal_handler_selftest.valid ()) + return; + saw_exception = false; { scoped_restore save_hook = make_scoped_restore (&hook_set_active_ext_lang, - []() { raise (SIGINT); }); + []() { handle_sigint (SIGINT); }); try { CMD (output); -- 2.35.3