From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lndn.lancelotsix.com (lndn.lancelotsix.com [51.195.220.111]) by sourceware.org (Postfix) with ESMTPS id 6E91D3858D20 for ; Thu, 26 Oct 2023 12:46:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6E91D3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=lancelotsix.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=lancelotsix.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6E91D3858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=51.195.220.111 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698324370; cv=none; b=xr+8ItXHhURGBbEYH1BHOZrQ44M+APuHtYFAZcj6unw+yEqymzn39+mu6wZ+hqCk6CD54vFeQm21C0hBy5F9Jw+ueNiJRJqChqTyuzJxmmfDOpJMpGlaaB+SqL3n+gF0/ObweFM/RKMkgQWEGfYUItH+CNmsMgkoZZfw14Qhc5E= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698324370; c=relaxed/simple; bh=MjiByUl2sF53RoUrc9DL9Yt33nlgTn/P//igxUFaebg=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=WotjoTawKsvoXRyc4MAXOjZZ/DxbSt44cG9kAVoJTq8pxYu/YLBYzJJRYBBQzLvh1nWlfaE6kqesjMiBPOElh8ZAY125489iDMlse5p/nSFn0hXtdrRUNZRyWvgP47+MSnZkYOGZp9Lh8yLVIKZDDYSM5ADuNZDWX3qp9RxIk3M= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from octopus (cust120-dsl54.idnet.net [212.69.54.120]) by lndn.lancelotsix.com (Postfix) with ESMTPSA id 2BB868BFD9; Thu, 26 Oct 2023 12:46:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=lancelotsix.com; s=2021; t=1698324366; bh=MjiByUl2sF53RoUrc9DL9Yt33nlgTn/P//igxUFaebg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jGJ+6ApcfiqjWPvVFIM8XLayyjtbSGRWi9wEXUyqreDmAYJOcl4EY5LeOG6bZo4Sq 2OuAlGZ9JhkAPQR4lOEKHShmypp+IGe09mAiLgJst3SDDHvVGjTKq9lRQBhJhGqRlL A3oFzPz9Qu/xPiA87W/gP62hYbFaa3LZX0JEvQvIO86kMxv3pnc75fp6Csp4wn8HcR Gi7RSbD/fuTFMqHMMARKCw17yuWWa/TQMktx4HYsbkqaF8KO30HnZApOB1ymy6mA5O kHrfNfbrIB1i9nplF2ZkQY0l1Cg5F7AJ6bYhxz/MNrcl88BnB3khAuEf+kecx8URVD J+NBPgERRV7Ug== Date: Thu, 26 Oct 2023 13:46:02 +0100 From: Lancelot SIX To: Simon Marchi Cc: Guinevere Larsen , Kevin Buettner , gdb-patches@sourceware.org, eliz@gnu.org, Pedro Alves Subject: Re: [PATCH v5 1/1] [gdb]: add git trailer information on gdb/MAINTAINERS Message-ID: <20231026124540.cy3bw5ibusrw6zxx@octopus> References: <20231005113533.86112-2-blarsen@redhat.com> <20231005113533.86112-3-blarsen@redhat.com> <20231005105530.63d11345@f37-zws-nv> <7993630f-6098-4d81-af02-ad4f73c20f1c@simark.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7993630f-6098-4d81-af02-ad4f73c20f1c@simark.ca> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6.2 (lndn.lancelotsix.com [0.0.0.0]); Thu, 26 Oct 2023 12:46:06 +0000 (UTC) X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Oct 10, 2023 at 11:14:26AM -0400, Simon Marchi wrote: > On 10/9/23 05:59, Guinevere Larsen wrote: > > I understand what you mean, and I see where I may have misunderstood when I said that "Acked-By" worked as partial review in QEMU. > > > > I'm fine with this being the default if everyone agrees with it. To summarize informally, the tags would be like this: > > > > * Acked-By: A maintainer of a certain area looked at the patch description and is fine with its direction. this says nothing about the quality of the code. May be restricted to some areas of the code > > * Reviewed-By: A contributor has looked at the code and thinks it is good, but is not approving it for any reason. May be restricted to some areas of the code. > > * Approved-By: A maintainer has looked at the code and thinks that it is ready for upstreaming. May be restricted to some areas, and may be conditional on receiving a review or ack for some area(s). > > I like this use of Acked-By, it matches the meaning I thought it had, > based on what other projects do. It happens that we say something like > "I gave it a quick look and it looks fine to me", indicating that we did > not do a thorough review, in which case Acked-By is appropriate. > > Simon Hi, For the record, I am fine with this direction. Best, Lancelot.