From: Tom Tromey <tom@tromey.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 15/30] Use read_var_value overload in finish_command_fsm
Date: Sun, 29 Oct 2023 17:23:36 -0600 [thread overview]
Message-ID: <20231029-split-objfile-2023-bound-sym-october-v1-15-612531df2734@tromey.com> (raw)
In-Reply-To: <20231029-split-objfile-2023-bound-sym-october-v1-0-612531df2734@tromey.com>
This changes finish_command_fsm to store a block_symbol, so that the
new read_var_value overload can be used.
---
gdb/infcmd.c | 23 ++++++++++++-----------
1 file changed, 12 insertions(+), 11 deletions(-)
diff --git a/gdb/infcmd.c b/gdb/infcmd.c
index c50d9bcd47d..03e54438686 100644
--- a/gdb/infcmd.c
+++ b/gdb/infcmd.c
@@ -1596,7 +1596,7 @@ struct finish_command_fsm : public thread_fsm
breakpoint_up breakpoint;
/* The function that we're stepping out of. */
- struct symbol *function = nullptr;
+ block_symbol function {};
/* If the FSM finishes successfully, this stores the function's
return value. */
@@ -1629,14 +1629,14 @@ finish_command_fsm::should_stop (struct thread_info *tp)
{
struct return_value_info *rv = &return_value_info;
- if (function != nullptr
+ if (function.symbol != nullptr
&& bpstat_find_breakpoint (tp->control.stop_bpstat,
breakpoint.get ()) != nullptr)
{
/* We're done. */
set_finished ();
- rv->type = function->type ()->target_type ();
+ rv->type = function.symbol->type ()->target_type ();
if (rv->type == nullptr)
internal_error (_("finish_command: function has no target type"));
@@ -1644,13 +1644,13 @@ finish_command_fsm::should_stop (struct thread_info *tp)
{
struct value *func;
- func = read_var_value (function, nullptr, get_current_frame ());
+ func = read_var_value (function, get_current_frame ());
if (return_buf != 0)
/* Retrieve return value from the buffer where it was saved. */
rv->value = value_at (rv->type, return_buf);
else
- rv->value = get_return_value (function, func);
+ rv->value = get_return_value (function.symbol, func);
if (rv->value != nullptr)
rv->value_history_index = rv->value->record_latest ();
@@ -1883,22 +1883,22 @@ finish_command (const char *arg, int from_tty)
/* Find the function we will return from. */
frame_info_ptr callee_frame = get_selected_frame (nullptr);
- sm->function = find_pc_function (get_frame_pc (callee_frame)).symbol;
+ sm->function = find_pc_function (get_frame_pc (callee_frame));
sm->return_buf = 0; /* Initialize buffer address is not available. */
/* Determine the return convention. If it is RETURN_VALUE_STRUCT_CONVENTION,
attempt to determine the address of the return buffer. */
- if (sm->function != nullptr)
+ if (sm->function.symbol != nullptr)
{
enum return_value_convention return_value;
struct gdbarch *gdbarch = get_frame_arch (callee_frame);
struct type * val_type
- = check_typedef (sm->function->type ()->target_type ());
+ = check_typedef (sm->function.symbol->type ()->target_type ());
return_value
= gdbarch_return_value_as_value (gdbarch,
- read_var_value (sm->function, nullptr,
+ read_var_value (sm->function,
callee_frame),
val_type, nullptr, nullptr, nullptr);
@@ -1916,10 +1916,11 @@ finish_command (const char *arg, int from_tty)
gdb_printf (_("Run back to call of "));
else
{
- if (sm->function != nullptr && TYPE_NO_RETURN (sm->function->type ())
+ if (sm->function.symbol != nullptr
+ && TYPE_NO_RETURN (sm->function.symbol->type ())
&& !query (_("warning: Function %s does not return normally.\n"
"Try to finish anyway? "),
- sm->function->print_name ()))
+ sm->function.symbol->print_name ()))
error (_("Not confirmed."));
gdb_printf (_("Run till exit from "));
}
--
2.41.0
next prev parent reply other threads:[~2023-10-29 23:23 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-29 23:23 [PATCH 00/30] Baby step for objfile splitting Tom Tromey
2023-10-29 23:23 ` [PATCH 01/30] Introduce block-symbol.h Tom Tromey
2023-10-29 23:23 ` [PATCH 02/30] Add block_symbol::address Tom Tromey
2023-10-29 23:23 ` [PATCH 03/30] Easy conversions to use block_symbol::address Tom Tromey
2023-10-29 23:23 ` [PATCH 04/30] Use block_symbol::address in ada-tasks.c Tom Tromey
2023-11-03 3:40 ` Simon Marchi
2023-11-05 16:35 ` Tom Tromey
2023-10-29 23:23 ` [PATCH 05/30] Use block_symbol::address in printcmd.c Tom Tromey
2023-11-03 3:42 ` Simon Marchi
2023-11-05 16:35 ` Tom Tromey
2023-10-29 23:23 ` [PATCH 06/30] Use block_symbol::address in tracepoint.c Tom Tromey
2023-10-29 23:23 ` [PATCH 07/30] More use of " Tom Tromey
2023-10-29 23:23 ` [PATCH 08/30] Use block_symbol::address in ax-gdb.c Tom Tromey
2023-10-29 23:23 ` [PATCH 09/30] Use block_symbol::address in linespec.c Tom Tromey
2023-10-29 23:23 ` [PATCH 10/30] Use block_symbol::address in ada-lang.c Tom Tromey
2023-10-29 23:23 ` [PATCH 11/30] Use block_symbol::address in symmisc.c Tom Tromey
2023-10-29 23:23 ` [PATCH 12/30] Introduce read_var_value overload Tom Tromey
2023-10-29 23:23 ` [PATCH 13/30] Use read_var_value in gdb/compile Tom Tromey
2023-10-29 23:23 ` [PATCH 14/30] Return a block_symbol from find_pc_sect_function Tom Tromey
2023-10-29 23:23 ` Tom Tromey [this message]
2023-10-29 23:23 ` [PATCH 16/30] Use block_symbol in overload-handling code Tom Tromey
2023-10-29 23:23 ` [PATCH 17/30] Change evaluate_var_value to accept a block_symbol Tom Tromey
2023-10-29 23:23 ` [PATCH 18/30] Change value_of_variable to take " Tom Tromey
2023-10-29 23:23 ` [PATCH 19/30] Return a block_symbol from get_frame_function Tom Tromey
2023-10-29 23:23 ` [PATCH 20/30] Use read_var_value overload in return_command Tom Tromey
2023-10-29 23:23 ` [PATCH 21/30] Use read_var_value overload in py-finishbreakpoint.c Tom Tromey
2023-10-29 23:23 ` [PATCH 22/30] Use read_var_value overload in py-framefilter.c Tom Tromey
2023-10-29 23:23 ` [PATCH 23/30] Use read_var_value overload in Guile Tom Tromey
2023-10-29 23:23 ` [PATCH 24/30] Use read_var_value in read_frame_arg and read_frame_local Tom Tromey
2023-10-29 23:23 ` [PATCH 25/30] Change print_variable_and_value to take a block_symbol Tom Tromey
2023-10-29 23:23 ` [PATCH 26/30] Change find_frame_funname to return " Tom Tromey
2023-10-29 23:23 ` [PATCH 27/30] Change btrace_function::sym to " Tom Tromey
2023-10-29 23:23 ` [PATCH 28/30] Use read_var_value overload in Python Tom Tromey
2023-10-29 23:23 ` [PATCH 29/30] Remove the old read_var_value Tom Tromey
2023-10-29 23:23 ` [PATCH 30/30] Change language_defn::read_var_value to accept block_symbol Tom Tromey
2023-11-03 3:59 ` [PATCH 00/30] Baby step for objfile splitting Simon Marchi
2023-11-05 16:48 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231029-split-objfile-2023-bound-sym-october-v1-15-612531df2734@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).