From: Tom Tromey <tom@tromey.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tom@tromey.com>
Subject: [PATCH 03/15] Add quick_symbol_functions::compute_main_name
Date: Sun, 29 Oct 2023 11:35:22 -0600 [thread overview]
Message-ID: <20231029173839.471514-4-tom@tromey.com> (raw)
In-Reply-To: <20231029173839.471514-1-tom@tromey.com>
This adds a new compute_main_name method to quick_symbol_functions.
Currently there are no implementations of this, but a subsequent patch
will add one.
---
gdb/objfiles.h | 3 +++
gdb/quick-symbol.h | 9 +++++++++
gdb/symfile-debug.c | 12 ++++++++++++
gdb/symtab.c | 2 ++
4 files changed, 26 insertions(+)
diff --git a/gdb/objfiles.h b/gdb/objfiles.h
index 4b8aa9bfcec..c0ca9de6874 100644
--- a/gdb/objfiles.h
+++ b/gdb/objfiles.h
@@ -601,6 +601,9 @@ struct objfile
void map_symbol_filenames (gdb::function_view<symbol_filename_ftype> fun,
bool need_fullname);
+ /* See quick_symbol_functions. */
+ void compute_main_name ();
+
/* See quick_symbol_functions. */
struct compunit_symtab *find_compunit_symtab_by_address (CORE_ADDR address);
diff --git a/gdb/quick-symbol.h b/gdb/quick-symbol.h
index a7fea2ccb49..49505aef64a 100644
--- a/gdb/quick-symbol.h
+++ b/gdb/quick-symbol.h
@@ -212,6 +212,15 @@ struct quick_symbol_functions
gdb::function_view<symbol_filename_ftype> fun,
bool need_fullname) = 0;
+ /* Compute the name and language of the main function for the given
+ objfile. Normally this is done during symbol reading, but this
+ method exists in case this work is done in a worker thread and
+ must be waited for. The implementation can call
+ set_objfile_main_name if results are found. */
+ virtual void compute_main_name (struct objfile *objfile)
+ {
+ }
+
/* Return true if this class can lazily read the symbols. This may
only return true if there are in fact symbols to be read, because
this is used in the implementation of 'has_partial_symbols'. */
diff --git a/gdb/symfile-debug.c b/gdb/symfile-debug.c
index 850da4147a3..4b27d9eb406 100644
--- a/gdb/symfile-debug.c
+++ b/gdb/symfile-debug.c
@@ -483,6 +483,18 @@ objfile::map_symbol_filenames (gdb::function_view<symbol_filename_ftype> fun,
iter->map_symbol_filenames (this, fun, need_fullname);
}
+void
+objfile::compute_main_name ()
+{
+ if (debug_symfile)
+ gdb_printf (gdb_stdlog,
+ "qf->compute_main_name (%s)\n",
+ objfile_debug_name (this));
+
+ for (const auto &iter : qf_require_partial_symbols ())
+ iter->compute_main_name (this);
+}
+
struct compunit_symtab *
objfile::find_compunit_symtab_by_address (CORE_ADDR address)
{
diff --git a/gdb/symtab.c b/gdb/symtab.c
index 5ec56f4f2af..ea003a4d4c9 100644
--- a/gdb/symtab.c
+++ b/gdb/symtab.c
@@ -6237,6 +6237,8 @@ find_main_name (void)
accurate. */
for (objfile *objfile : current_program_space->objfiles ())
{
+ objfile->compute_main_name ();
+
if (objfile->per_bfd->name_of_main != NULL)
{
set_main_name (pspace,
--
2.41.0
next prev parent reply other threads:[~2023-10-29 17:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-29 17:35 [PATCH 00/15] Index DWARF in the background Tom Tromey
2023-10-29 17:35 ` [PATCH 01/15] Add thread-safety to gdb's BFD wrappers Tom Tromey
2023-10-29 17:35 ` [PATCH 02/15] Refactor complaint thread-safety approach Tom Tromey
2023-10-29 17:35 ` Tom Tromey [this message]
2023-10-29 17:35 ` [PATCH 04/15] Add gdb::task_group Tom Tromey
2023-10-29 17:35 ` [PATCH 05/15] Move cooked_index_storage to cooked-index.h Tom Tromey
2023-10-29 17:35 ` [PATCH 06/15] Add "maint set dwarf synchronous" Tom Tromey
2023-10-29 17:50 ` Eli Zaretskii
[not found] ` <87v89tfz40.fsf@tromey.com>
2023-11-23 6:08 ` Eli Zaretskii
2023-10-29 17:35 ` [PATCH 07/15] Change how cooked index waits for threads Tom Tromey
2023-10-29 17:35 ` [PATCH 08/15] Do more DWARF reading in the background Tom Tromey
2023-10-29 17:35 ` [PATCH 09/15] Simplify the public DWARF API Tom Tromey
2023-10-29 17:35 ` [PATCH 10/15] Remove two quick_symbol_functions methods Tom Tromey
2023-10-29 17:35 ` [PATCH 11/15] Change current_language to be a macro Tom Tromey
2023-10-29 17:35 ` [PATCH 12/15] Lazy language setting Tom Tromey
2023-10-29 17:35 ` [PATCH 13/15] Optimize lookup_minimal_symbol_text Tom Tromey
2023-10-29 17:35 ` [PATCH 14/15] Avoid language-based lookups in startup path Tom Tromey
2023-10-29 17:35 ` [PATCH 15/15] Back out some parallel_for_each features Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231029173839.471514-4-tom@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).