From: Tom Tromey <tromey@adacore.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 0/7] Handle nested functions in DAP
Date: Wed, 01 Nov 2023 11:09:32 -0600 [thread overview]
Message-ID: <20231101-dap-nested-function-v1-0-0b0c3b228ac7@adacore.com> (raw)
DAP doesn't really describe what to do for nested functions. We
discussed it internally a little, and I came up with this series. The
idea here is that variables from the outer scope ought to be visible,
so this series lets Python code follow a frame's static link, and then
changes the DAP frame decorators to use this ability.
At some point I think we'll need a "frame decorator v2", like we added
for pretty-printers. But, I've been putting this off a little and
still haven't done it here.
Regression tested on x86-64 Fedora 36.
---
Tom Tromey (7):
Add two convenience methods to block
Add block::function_block
Move follow_static_link to frame.c
Add gdb.Frame.static_link method
Fix a bug in DAP scopes code
Handle the static link in FrameDecorator
Update gdb.Symbol.is_variable documentation
gdb/NEWS | 3 +
gdb/block.c | 13 +++++
gdb/block.h | 21 +++++++
gdb/doc/python.texi | 14 ++++-
gdb/findvar.c | 64 +++-------------------
gdb/frame.c | 40 ++++++++++++++
gdb/frame.h | 7 +++
gdb/python/lib/gdb/FrameDecorator.py | 64 +++++++++++++++++-----
gdb/python/lib/gdb/dap/scopes.py | 8 ++-
gdb/python/py-frame.c | 26 +++++++++
gdb/testsuite/gdb.dap/ada-nested.exp | 91 +++++++++++++++++++++++++++++++
gdb/testsuite/gdb.dap/ada-nested/prog.adb | 32 +++++++++++
12 files changed, 311 insertions(+), 72 deletions(-)
---
base-commit: 5fbee060e807fbc317aa265eb7e25d1cf94a4dad
change-id: 20231101-dap-nested-function-28a2595863ad
Best regards,
--
Tom Tromey <tromey@adacore.com>
next reply other threads:[~2023-11-01 17:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-01 17:09 Tom Tromey [this message]
2023-11-01 17:09 ` [PATCH 1/7] Add two convenience methods to block Tom Tromey
2023-11-01 17:09 ` [PATCH 2/7] Add block::function_block Tom Tromey
2023-11-01 17:09 ` [PATCH 3/7] Move follow_static_link to frame.c Tom Tromey
2023-11-01 17:09 ` [PATCH 4/7] Add gdb.Frame.static_link method Tom Tromey
2023-11-01 17:17 ` Eli Zaretskii
2023-11-01 17:09 ` [PATCH 5/7] Fix a bug in DAP scopes code Tom Tromey
2023-11-01 17:09 ` [PATCH 6/7] Handle the static link in FrameDecorator Tom Tromey
2023-11-15 12:31 ` Tom de Vries
2023-11-15 13:58 ` Tom Tromey
2023-11-15 14:07 ` Tom de Vries
2023-11-15 14:58 ` Tom Tromey
2023-11-01 17:09 ` [PATCH 7/7] Update gdb.Symbol.is_variable documentation Tom Tromey
2023-11-01 17:15 ` Eli Zaretskii
2023-11-14 15:39 ` [PATCH 0/7] Handle nested functions in DAP Tom Tromey
2023-11-14 16:11 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231101-dap-nested-function-v1-0-0b0c3b228ac7@adacore.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).