From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd32.google.com (mail-io1-xd32.google.com [IPv6:2607:f8b0:4864:20::d32]) by sourceware.org (Postfix) with ESMTPS id 522313858C41 for ; Fri, 3 Nov 2023 16:09:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 522313858C41 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 522313858C41 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::d32 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699027779; cv=none; b=D9drrzZxlZyKFMGrYa+oSFziht4qUhHej2gfd6jE/LPdpbsXvcNQTxVJJ1PspMIiCUjCjJcgsd7jikVYZ6kV9pU6pcfnQhVirbgYtwuoAn+0NPkeWr9XLZPkABc8p4RjuPV05If3PAGFw2pN7OR/bzqmXIHEquUC0K7UPYAiz4k= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699027779; c=relaxed/simple; bh=aslRUCeE+kkltGzCCMzPCuw/Jrv+tSiDoDHEv7OMaZw=; h=DKIM-Signature:From:Date:Subject:MIME-Version:Message-Id:To; b=E05FjVUS/W3UdAolGIILz19GpEA2CGF+OxT3+QyByPgCALPd7kHG4RXJxiBbLQKFhPk1VFBe9Cga+mVG/osluI4lnMpW+HqKNUtZsgQSQ1Mfd9Lp4Yz5u+nRmu3QHFjLief81ZBjF4oR3Ex2FlXErm+TLgj1V8grt4dUqDunyuo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-io1-xd32.google.com with SMTP id ca18e2360f4ac-7a6889f33b9so75643239f.0 for ; Fri, 03 Nov 2023 09:09:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1699027770; x=1699632570; darn=sourceware.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=JM44PxIBjglHV/FoqGMVfKmO8FHk1RLxTl3UweBgghk=; b=XgzHOlJo3OpjJThn4mp6iO5iZr9EuBM4iBRDCcFz9hgsqdGLq/nB8vmaArwturRb19 J5KosqY8Befb/TDzLklLMhXy4iz5cD9IwnOanNSH51j6bqy1cVhvwBqHdqKiS9zba7ia QAxWEfsbjFKB+Mvkix0XC4TPwBf0IkOwTYu5bAyuRJ9JQ4zx2zHvwkMjIuvAQfHNIUjw z7GJvXZuv1yDlu0Esvcr16fxbyGh+C2sEVJNP2+saj67F76Mg2Fe7PNKfGalj0F6lqL0 mbAC739kP3zdnO4PVkcsOxCj1+XguNsSwrRZJXrUvdm7zK33xzf3AzoV+PM9ed9WNlje 79og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699027770; x=1699632570; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JM44PxIBjglHV/FoqGMVfKmO8FHk1RLxTl3UweBgghk=; b=wD+IXFv0r0UcNcHO/xfogqSfKavOFeHGmzOs0+coJiPjuBydT/d2XETn1uSukk4i91 7Vdua+9QvpWVS1Iex2a4FUJrTUKFQyLLKYSFaJzqHwROWq5JLJBj3SHN2DmchrqNfjyK YMzI/JO4a7wHsKehY8YgUF7TfbBrMeHAPFMXZ+KXYOaTX8B9oCXBcPwKdrwRYsHG2h3d g/to5Tnp8yKkf9V+BbXK8b4h5S4IytIrNoa7bVhjvycReBfKoUh5or5lTELi7dFwnjkO 7Y7yy0S6hO9PFlPE+jowfCo1ZSKlFcUwHTGDHsoOqsSLAdxPs7jTHs3tyY8WBP+SfNTX TCrw== X-Gm-Message-State: AOJu0YyQzWB9Kq6h9DjIu9oDze8S0aFJYOMuU/wL9Fx1HXEmylggOuHK vXOFgt8IY3LWMaQAptvqBV+85g== X-Google-Smtp-Source: AGHT+IGZR5hqWXIzCM+mM0YBfU9WWjAtD9G2utDrJbg4y6ZxKhe6JYqj47pq8fss04/Yp4cGTE+AIQ== X-Received: by 2002:a05:6602:341a:b0:79f:d04d:ce5a with SMTP id n26-20020a056602341a00b0079fd04dce5amr27245851ioz.2.1699027770547; Fri, 03 Nov 2023 09:09:30 -0700 (PDT) Received: from localhost.localdomain (97-122-77-73.hlrn.qwest.net. [97.122.77.73]) by smtp.gmail.com with ESMTPSA id gu16-20020a0566382e1000b0042b3dcb1106sm581839jab.47.2023.11.03.09.09.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Nov 2023 09:09:30 -0700 (PDT) From: Tom Tromey Date: Fri, 03 Nov 2023 10:09:26 -0600 Subject: [PATCH v3 4/9] Add field::is_public MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20231103-field-bits-v3-4-273c40bcaf3d@adacore.com> References: <20231103-field-bits-v3-0-273c40bcaf3d@adacore.com> In-Reply-To: <20231103-field-bits-v3-0-273c40bcaf3d@adacore.com> To: gdb-patches@sourceware.org Cc: Simon Marchi , Keith Seitz X-Mailer: b4 0.12.4 X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This adds a field::is_public convenience method, and updates one spot to use it. Acked-By: Simon Marchi Reviewed-by: Keith Seitz --- gdb/gdbtypes.h | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/gdb/gdbtypes.h b/gdb/gdbtypes.h index f5dd2b8076d..b6a693f1316 100644 --- a/gdb/gdbtypes.h +++ b/gdb/gdbtypes.h @@ -686,6 +686,10 @@ struct field enum accessibility accessibility () const { return m_accessibility; } + /* True if this field is 'public'. */ + bool is_public () const + { return m_accessibility == accessibility::PUBLIC; } + /* True if this field is 'private'. */ bool is_private () const { return m_accessibility == accessibility::PRIVATE; } @@ -1964,7 +1968,7 @@ extern void set_type_vptr_basetype (struct type *, struct type *); #define TYPE_BASECLASS_NAME(thistype,index) (thistype->field (index).name ()) #define TYPE_BASECLASS_BITPOS(thistype,index) (thistype->field (index).loc_bitpos ()) #define BASETYPE_VIA_PUBLIC(thistype, index) \ - ((!TYPE_FIELD_PRIVATE(thistype, index)) && (!TYPE_FIELD_PROTECTED(thistype, index))) + ((thistype)->field (index).is_public ()) #define TYPE_CPLUS_DYNAMIC(thistype) TYPE_CPLUS_SPECIFIC (thistype)->is_dynamic #define BASETYPE_VIA_VIRTUAL(thistype, index) \ -- 2.40.1