From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id EEF803858D38 for ; Wed, 8 Nov 2023 05:12:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EEF803858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EEF803858D38 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=132.207.4.11 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699420355; cv=none; b=xQ6nrmsQ6oaF5AUXvBGtYmXSPobMOy185/7lTRYm9ZSF6IsAjByRY7TapiQmltiSQ7Sf5dNNSjAvEVBOHbhSCnLy3Lru/d63i0+c0PkbYV/RjIwWIiVnbzUGDqqbEQu9ZZbUs6za1PBGEZj60UPI3rLBQrSIlsagpOja/ASHM0k= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699420355; c=relaxed/simple; bh=l4Xuu9Rs3oAspptT+JtwgT4eeZns8ZNQj6vbeEo5GVk=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=TUSsRwpnhVzP1kDdqEdFqZWWXeUpO/E5D8MQNNFMtYwzrKv6vEVAmbj6VjhjxsJmWtr18iIjpa7Vha9AVSoluaKzPMSyVGswCeGu3tOtrJ9bg927XT5MJrQoxhOeE1EGKUGqETMv7CryUi9rI3e6hMp+WYjZo5ZLgIEdCENMzmM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 3A85CR8k015322 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 8 Nov 2023 00:12:32 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 3A85CR8k015322 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1699420352; bh=bIquzI6tzyBLSU6Si4tQokvRuXkGgDZUFi/9nBLsvo4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=enb8g0ttpUJhfMGC1hK/IMaYRPgP37COeRiJRvVvJP2NMtb5kJKmArbVoawvAADad ptqZEzaz4MFZUmuSb+ZR3gUPbiP2rQ1SW8CMe8rl3MecWxDO+zLXArqmkG8DbiNfIi o+UHV9rah5xfGh+WMv8kQe4uIBrWwkNT+X6j8Rgs= Received: from simark.localdomain (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 4E41F1E0D2; Wed, 8 Nov 2023 00:12:27 -0500 (EST) From: Simon Marchi To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [PATCH 03/24] gdb: make store_integer take an array_view Date: Wed, 8 Nov 2023 00:00:47 -0500 Message-ID: <20231108051222.1275306-4-simon.marchi@polymtl.ca> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231108051222.1275306-1-simon.marchi@polymtl.ca> References: <20231108051222.1275306-1-simon.marchi@polymtl.ca> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Wed, 8 Nov 2023 05:12:27 +0000 X-Spam-Status: No, score=-3188.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: From: Simon Marchi Change store_integer, store_signed_integer and store_unsigned_integer to accept an array_view. Add some backwards compatibility overloads to avoid changing all callers at once. Change-Id: Ibb1381228ab1cb65fc7e2e4b92cf9ab1047cdc03 --- gdb/defs.h | 39 +++++++++++++++++++++++++++++++-------- gdb/findvar.c | 16 +++++++--------- 2 files changed, 38 insertions(+), 17 deletions(-) diff --git a/gdb/defs.h b/gdb/defs.h index b8612e1ac6d3..8170ec53c87c 100644 --- a/gdb/defs.h +++ b/gdb/defs.h @@ -501,21 +501,44 @@ extern CORE_ADDR extract_typed_address (const gdb_byte *buf, target-format integer at ADDR which is LEN bytes long. */ template> -extern void store_integer (gdb_byte *addr, int len, enum bfd_endian byte_order, - T val); +extern void store_integer (gdb::array_view dst, + bfd_endian byte_order, T val); + +template +static inline void +store_integer (gdb_byte *addr, int len, bfd_endian byte_order, T val) +{ + return store_integer (gdb::make_array_view (addr, len), byte_order, val); +} + +static inline void +store_signed_integer (gdb::array_view dst, bfd_endian byte_order, + LONGEST val) +{ + return store_integer (dst, byte_order, val); +} + +static inline void +store_signed_integer (gdb_byte *addr, int len, bfd_endian byte_order, + LONGEST val) +{ + return store_signed_integer (gdb::make_array_view (addr, len), byte_order, + val); +} static inline void -store_signed_integer (gdb_byte *addr, int len, - enum bfd_endian byte_order, LONGEST val) +store_unsigned_integer (gdb::array_view dst, bfd_endian byte_order, + ULONGEST val) { - return store_integer (addr, len, byte_order, val); + return store_integer (dst, byte_order, val); } static inline void -store_unsigned_integer (gdb_byte *addr, int len, - enum bfd_endian byte_order, ULONGEST val) +store_unsigned_integer (gdb_byte *addr, int len, bfd_endian byte_order, + LONGEST val) { - return store_integer (addr, len, byte_order, val); + return store_unsigned_integer (gdb::make_array_view (addr, len), byte_order, + val); } extern void store_typed_address (gdb_byte *buf, struct type *type, diff --git a/gdb/findvar.c b/gdb/findvar.c index 4e992ecdcc73..edb61fb27317 100644 --- a/gdb/findvar.c +++ b/gdb/findvar.c @@ -160,12 +160,12 @@ extract_typed_address (const gdb_byte *buf, struct type *type) target-format integer at ADDR which is LEN bytes long. */ template void -store_integer (gdb_byte *addr, int len, enum bfd_endian byte_order, +store_integer (gdb::array_view dst, enum bfd_endian byte_order, T val) { gdb_byte *p; - gdb_byte *startaddr = addr; - gdb_byte *endaddr = startaddr + len; + gdb_byte *startaddr = dst.data (); + gdb_byte *endaddr = startaddr + dst.size (); /* Start at the least significant end of the integer, and work towards the most significant. */ @@ -188,13 +188,11 @@ store_integer (gdb_byte *addr, int len, enum bfd_endian byte_order, } /* Explicit instantiations. */ -template void store_integer (gdb_byte *addr, int len, - enum bfd_endian byte_order, - LONGEST val); +template void store_integer (gdb::array_view dst, + bfd_endian byte_order, LONGEST val); -template void store_integer (gdb_byte *addr, int len, - enum bfd_endian byte_order, - ULONGEST val); +template void store_integer (gdb::array_view dst, + bfd_endian byte_order, ULONGEST val); /* Store the address ADDR as a pointer of type TYPE at BUF, in target form. */ -- 2.42.1