From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta40.uswest2.a.cloudfilter.net (omta40.uswest2.a.cloudfilter.net [35.89.44.39]) by sourceware.org (Postfix) with ESMTPS id E802D3858D28 for ; Sun, 12 Nov 2023 20:25:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E802D3858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E802D3858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699820736; cv=none; b=TFfa1Iiqhus6X8MTJA9PaiMHqofCskqtKy/xtycQyNHeeR0wE7f/OIlGvZDpmKv4EjH4It1e9gUb35hJPHsRt4tbqfgArZzYyZGnlwZQTe2nAe0X3NfFBcE75ADagIy9UFsLM3b8tBI9wp9ymJKz09gOIk7PIGR5QwWJaS16r7I= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699820736; c=relaxed/simple; bh=owwJFoC+I6JrjWG0tnT7qQKHM8rGa6uYuT4sQFdMc+k=; h=DKIM-Signature:From:Date:Subject:MIME-Version:Message-Id:To; b=Zs1CcqOPbJFyoXdJNUYeUUgOmwAKSvGv5JedpMp4lXt2dhCpdnEyiT1/dzGgrW1ePN+/WmIt75te0ZWU6ngVAac33QFHQN970k8QTVTC4jsCs8dEWvXggczlbnooITnCerbEWnzpc98I/bUFIedUMvQdl3CgwGFMt7XV/8x1Jn4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6007a.ext.cloudfilter.net ([10.0.30.247]) by cmsmtp with ESMTPS id 2DLXrub57L9Ag2H1RrVwdN; Sun, 12 Nov 2023 20:25:33 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id 2H1QrbWs2qmEo2H1QrIu0k; Sun, 12 Nov 2023 20:25:32 +0000 X-Authority-Analysis: v=2.4 cv=P+8pOwMu c=1 sm=1 tr=0 ts=655134bc a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=IkcTkHD0fZMA:10 a=BNY50KLci1gA:10 a=Qbun_eYptAEA:10 a=LS37jE6c6dNhwMZYAH4A:9 a=QEXdDO2ut3YA:10 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=To:In-Reply-To:References:Message-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:Subject:Date:From:Sender:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=q3JY/BR5ZN7nSbSgGkNak/qvBwXlUJXEBXd1UPSM+G8=; b=OLrZTxauX4vk3+cCHNNFaiMXJC TjsCsmjqauLGJQrip8lfUcu1IodPRl8uEMEzyTDB3LyYiNPDo+leq9iTxUXcN3gCnlK3tYjl4O99y cBUZrWTauhmhGBixT5eyEBYjt; Received: from 97-122-77-73.hlrn.qwest.net ([97.122.77.73]:34540 helo=[192.168.0.21]) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1r2H1P-000cUU-3B for gdb-patches@sourceware.org; Sun, 12 Nov 2023 13:25:32 -0700 From: Tom Tromey Date: Sun, 12 Nov 2023 13:25:40 -0700 Subject: [PATCH v2 03/18] Add a couple of bfd_cache_close calls MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20231112-t-bg-dwarf-reading-v2-3-70fb170012ba@tromey.com> References: <20231112-t-bg-dwarf-reading-v2-0-70fb170012ba@tromey.com> In-Reply-To: <20231112-t-bg-dwarf-reading-v2-0-70fb170012ba@tromey.com> To: gdb-patches@sourceware.org X-Mailer: b4 0.12.4 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.77.73 X-Source-L: No X-Exim-ID: 1r2H1P-000cUU-3B X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-77-73.hlrn.qwest.net ([192.168.0.21]) [97.122.77.73]:34540 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfCW15C9YZtZIkP8AkJCmSd+5D+Msg6hgCm6OUPBF6Er3DcyWAUnINAyacGGk3LqlgMEMGRJt7LCsXGM4B8+CKoD/TI4dnGiPw1Ci0TOioXtzNF381JQP 2ddMhWtRHqXVmvOFJGh9PB3G1wb2YXw4jq+v0YLMaXBqvwmGCfRrPvxYqym2xicYP7Tjl8uX2/xvN5Nc7VBRsgVqTrowLAV6XLk= X-Spam-Status: No, score=-3024.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,JMQ_SPF_NEUTRAL,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This adds a couple of calls to bfd_cache_close at points where a BFD isn't actively needed by gdb. Normally at these points, all the needed section data is already mapped, so we can simply close the file descriptor. This is harmless at worst, because if this is needed after all, the BFD file descriptor cache will reopen it. --- gdb/dwarf2/read.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c index d277c21622f..a83095f8c5d 100644 --- a/gdb/dwarf2/read.c +++ b/gdb/dwarf2/read.c @@ -9187,6 +9187,8 @@ open_and_init_dwo_file (dwarf2_cu *cu, const char *dwo_name, dwarf_read_debug_printf ("DWO file found: %s", dwo_name); + bfd_cache_close (dwo_file->dbfd.get ()); + return dwo_file.release (); } @@ -9479,6 +9481,8 @@ open_and_init_dwp_file (dwarf2_per_objfile *per_objfile) pulongest (dwp_file->cus ? dwp_file->cus->nr_units : 0), pulongest (dwp_file->tus ? dwp_file->tus->nr_units : 0)); + bfd_cache_close (dwp_file->dbfd.get ()); + return dwp_file; } -- 2.41.0