From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 991AA3858D20 for ; Mon, 13 Nov 2023 01:57:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 991AA3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 991AA3858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699840650; cv=none; b=RA1FytStnoSRzZU6OC19IY7vzYY4rQip50dL1fPyWLEHINlScaAUkChpMCG/7r0h0JLx7gWYbEziGfCn+cxNT7kQrf+ziLmmyRo4rM8u+PRm71n+i+G9YSf3YIN1XVuJXDh1yEhNG6C7zune2syICwjBcg2HJNqH8TQmaKWJ+4U= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699840650; c=relaxed/simple; bh=HT/Kqsz9laKnpWmbCR6JFnrvKhWpGWnnyjTDfFvNScQ=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=s9f3nX0w87ddQCyb4YSFzjJvD6cvgjTvXgUzNgn/xGpt9f7YvFNFTk80Mt2VuEq8GYjQGpked3QWmaamU9QWPpGvmKv4O5RgIR6lK8nCkd71vzkdTuDkdw2kFqFd0V6eDAss0HooaBBervsch4TaN8y9XjCVkAoP4NHphKWsmcE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699840649; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ebXeGOubuOfa7EBDDHca09VW7Vi5+XsebwTfS3t+seY=; b=hNIx3q4PK0t7jnQqHg40B6U2f+5otErW1jrxFnzXddT8XQHFGbHl1MTX2IkFm0FNJeRjWU HFsbg62pwdElMcJQGmIhs3yc7RN1fweTWCpnFzIzwvuKjRgZ1NNWzN7cp1e/ITBFShy3XN ItPAoKZ7yC/4BKg3u8M+pjSDHX9gT3w= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-328-6ZWqhWWBOR6Ihqb5-J3qWg-1; Sun, 12 Nov 2023 20:57:25 -0500 X-MC-Unique: 6ZWqhWWBOR6Ihqb5-J3qWg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8C30F29AA384; Mon, 13 Nov 2023 01:57:25 +0000 (UTC) Received: from f39-zbm-nv (unknown [10.22.8.105]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 339DA7AD1; Mon, 13 Nov 2023 01:57:25 +0000 (UTC) Date: Sun, 12 Nov 2023 18:57:23 -0700 From: Kevin Buettner To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Remove declaration of re_comp Message-ID: <20231112185345.5adde092@f39-zbm-nv> In-Reply-To: <20231112234142.4193851-1-tom@tromey.com> References: <20231112234142.4193851-1-tom@tromey.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sun, 12 Nov 2023 16:41:42 -0700 Tom Tromey wrote: > defs.h declares re_comp, but it shouldn't. If this is needed, it > should be picked up from xregex.h via gdb_regex.h. LGTM. Reviewed-by: Kevin Buettner