public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tom@tromey.com>
Subject: [PATCH] Remove declaration of re_comp
Date: Sun, 12 Nov 2023 16:41:42 -0700	[thread overview]
Message-ID: <20231112234142.4193851-1-tom@tromey.com> (raw)

defs.h declares re_comp, but it shouldn't.  If this is needed, it
should be picked up from xregex.h via gdb_regex.h.

Tested by rebuilding.
---
 gdb/defs.h | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/gdb/defs.h b/gdb/defs.h
index b8612e1ac6d..e6dd93e791e 100644
--- a/gdb/defs.h
+++ b/gdb/defs.h
@@ -299,12 +299,6 @@ extern std::string relocate_gdb_directory (const char *initial, bool relocatable
 extern int annotation_level;	/* in stack.c */
 \f
 
-/* From regex.c or libc.  BSD 4.4 declares this with the argument type as
-   "const char *" in unistd.h, so we can't declare the argument
-   as "char *".  */
-
-extern "C" char *re_comp (const char *);
-
 /* From symfile.c */
 
 extern void symbol_file_command (const char *, int);
-- 
2.41.0


             reply	other threads:[~2023-11-12 23:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-12 23:41 Tom Tromey [this message]
2023-11-13  1:57 ` Kevin Buettner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231112234142.4193851-1-tom@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).