* [PATCH] Fix small bug in compile.exp
@ 2023-11-15 19:45 Tom Tromey
2023-11-15 20:08 ` Keith Seitz
0 siblings, 1 reply; 2+ messages in thread
From: Tom Tromey @ 2023-11-15 19:45 UTC (permalink / raw)
To: gdb-patches; +Cc: Tom Tromey
compile.exp generally does not work for me on Fedora 38. However, I
sent a GCC patch to fix the plugin crash. With that patch, I get this
error from one test in compile.exp:
gdb command line:1:22: warning: initialization of 'int (*)(int)' from incompatible pointer type 'int (*)()' [-Wincompatible-pointer-types]
This patch adds a cast to compile.exp. This makes the test pass.
---
gdb/testsuite/gdb.compile/compile.exp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gdb/testsuite/gdb.compile/compile.exp b/gdb/testsuite/gdb.compile/compile.exp
index f2ab4fafa93..86521e99dac 100644
--- a/gdb/testsuite/gdb.compile/compile.exp
+++ b/gdb/testsuite/gdb.compile/compile.exp
@@ -307,7 +307,7 @@ gdb_test "compile code globalvar = func_nodebug (75);" \
"call func_nodebug"
gdb_test "p globalvar" " = -75" "expect -75"
gdb_test \
- "compile code int (*funcp) (int) = func_nodebug; globalvar = funcp (76);" \
+ "compile code int (*funcp) (int) = (int (*) (int)) func_nodebug; globalvar = funcp (76);" \
"warning: function has unknown return type; assuming int" \
"call func_nodebug indirectly"
gdb_test "p globalvar" " = -76" "expect -76"
--
2.41.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Fix small bug in compile.exp
2023-11-15 19:45 [PATCH] Fix small bug in compile.exp Tom Tromey
@ 2023-11-15 20:08 ` Keith Seitz
0 siblings, 0 replies; 2+ messages in thread
From: Keith Seitz @ 2023-11-15 20:08 UTC (permalink / raw)
To: Tom Tromey, gdb-patches
On 11/15/23 11:45, Tom Tromey wrote:
> compile.exp generally does not work for me on Fedora 38. However, I
> sent a GCC patch to fix the plugin crash. With that patch, I get this
> error from one test in compile.exp: >
> gdb command line:1:22: warning: initialization of 'int (*)(int)' from incompatible pointer type 'int (*)()' [-Wincompatible-pointer-types]
>
> This patch adds a cast to compile.exp. This makes the test pass.
Thank you for addressing this. I *may* have it on my TODO to "clean"
some of this up in the not-too-distant future.
> ---
> gdb/testsuite/gdb.compile/compile.exp | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gdb/testsuite/gdb.compile/compile.exp b/gdb/testsuite/gdb.compile/compile.exp
> index f2ab4fafa93..86521e99dac 100644
> --- a/gdb/testsuite/gdb.compile/compile.exp
> +++ b/gdb/testsuite/gdb.compile/compile.exp
> @@ -307,7 +307,7 @@ gdb_test "compile code globalvar = func_nodebug (75);" \
> "call func_nodebug"
> gdb_test "p globalvar" " = -75" "expect -75"
> gdb_test \
> - "compile code int (*funcp) (int) = func_nodebug; globalvar = funcp (76);" \
> + "compile code int (*funcp) (int) = (int (*) (int)) func_nodebug; globalvar = funcp (76);" \
> "warning: function has unknown return type; assuming int" \
> "call func_nodebug indirectly"
> gdb_test "p globalvar" " = -76" "expect -76"
LGTM
Reviewed-by: Keith Seitz <keiths@redhat.com>
Keith
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-11-15 20:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-15 19:45 [PATCH] Fix small bug in compile.exp Tom Tromey
2023-11-15 20:08 ` Keith Seitz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).