From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd29.google.com (mail-io1-xd29.google.com [IPv6:2607:f8b0:4864:20::d29]) by sourceware.org (Postfix) with ESMTPS id E9BC83858D33 for ; Tue, 21 Nov 2023 21:09:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E9BC83858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E9BC83858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::d29 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700600968; cv=none; b=SAQC5r63cz3t/3cuYJfWRkVxVCX3EErbUPjSVv7qXJ1xjq/y3VvTEVCmM+q17Yp6L19T7L8r/s9KZBzG832bN/poEHLwsTNbq5hqvuJN3SJehzYXdm9GJ3BhPYPnqd2mTP2eGo1xuDrzYV2XEx5Q9QGXHhnoiQWlr6KSgBtbfc8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700600968; c=relaxed/simple; bh=kYYmFN9hyb4ZUFoNWnP8KDWEc4lAWMN684DuthxEBE4=; h=DKIM-Signature:From:Subject:Date:Message-Id:MIME-Version:To; b=E/GhR+KSy9x8ozt8PB+Tdhmd8k57Y1mSfwFmQReuPwhkblPrNXvIYuLAR4+QVK3Upv4AHy+wxCyVkP6VLMCKesxmqkBYZ25V7hIqeVu2IfMeyXKdckOTrtFJ3Bp38LFkIIveC+wRAVqujwNn+8Sh+dJ/whzpS5E2ksxh4+miDPM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-io1-xd29.google.com with SMTP id ca18e2360f4ac-7b06844971dso201955039f.2 for ; Tue, 21 Nov 2023 13:09:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1700600966; x=1701205766; darn=sourceware.org; h=to:content-transfer-encoding:mime-version:message-id:date:subject :from:from:to:cc:subject:date:message-id:reply-to; bh=HOrv1pRoViIGaIKro9ot7+i3lC4CD8jNfTN4cdkXhpw=; b=jpP1+a0JmtKrvSJ9jJtcXKbTtGHsHFxjPCRImgUwzc+IOmvtfXxb81IAGd23SLWDmC 7kuwUPnkEOgFwSZ2rmvQM742aO2TOpZYAfs6M+Vadn1inn+Rn0hS4YajrLa2bGs4TVKe 2F0M7R/7q+WVzyyGLimd1+hlIXrwPl1z91KYsWZhEPKT8PBnYqa9QYQyQj2BXDpUOc9b pkC+Gf6hWRY+zz4wXe9TPUWWJ0TiqScASC1k0uOE0n2nc0f+gSuBDBlMLTWD3+iH0VJx Cm8iV2O3wtauQLmvxSNiLYw0tlQ05PeZBBZGHXwwsFUvNu3lLFy+xPbKSmH8Fg3kncrI kdTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700600966; x=1701205766; h=to:content-transfer-encoding:mime-version:message-id:date:subject :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HOrv1pRoViIGaIKro9ot7+i3lC4CD8jNfTN4cdkXhpw=; b=Deuv76fQg9ikche33ZAKiSAtP7Eld37tro9zG1B003Lvt5kAb0DVRkY4y8lDke68h2 OwPPAZZoVQWlF63hV9HFPCjBaq3GsiqBaIAHmR9RAEqDpgQUapgAQQsa1eGzw1mBnDJz 7H2rLX/TzqcUP4PUCsEexn9UY7n+luhN1FdMIPjG1yDDSgjxEAPlxxJyacsYw3zzL+rT PXqhzCLlFwO4X0wQR+BzR/T1Ee1sDnqM3RfrQhfjPgsAMYpMzZhu7oDzXStlyWjaLvly 6CtmSciKUnHCYwePNAR5ZmmscD/amszfjRExxCxsmgl+eQ3aYpoj4ba0gaU3lTgRnDGA 30NA== X-Gm-Message-State: AOJu0Yzg8MmW/aaqxN3m1JMoOkUM3RNdSqAfgmGsgPC1rPE57rD0I/dZ 5oVjRqlKF+aONsqBLZs4xODSbEXsNY4cerPSAF0HAQ== X-Google-Smtp-Source: AGHT+IHCGOHXy3qRfnB6K+yrBG4Sdkpc5yQ1N5Dr/LtNrofTHRZrbzbmrN8K8redb6JdgwUbPL9lJA== X-Received: by 2002:a05:6602:3587:b0:7b3:4d72:9ec0 with SMTP id bi7-20020a056602358700b007b34d729ec0mr134448iob.17.1700600966173; Tue, 21 Nov 2023 13:09:26 -0800 (PST) Received: from localhost.localdomain (97-122-77-73.hlrn.qwest.net. [97.122.77.73]) by smtp.gmail.com with ESMTPSA id l14-20020a6b750e000000b0079f7734a77esm3050242ioh.35.2023.11.21.13.09.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Nov 2023 13:09:25 -0800 (PST) From: Tom Tromey Subject: [PATCH 0/4] Improve Ada name lookup performance Date: Tue, 21 Nov 2023 14:09:24 -0700 Message-Id: <20231121-ada-lookup-perf-v1-0-1efd2d1dbf65@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAIQcXWUC/x3MwQrCMAyA4VcZORuwXdnUVxEP2Zq6oLYlURHG3 t3q8Tv8/wrGKmxw6lZQfotJyQ1u18G8UL4ySmwGv/e9c94hRcJ7KbdXxcqacBhTGOKxH8MhQKu qcpLP/3i+NE9kjJNSnpff50H2ZIVt+wKxj2dXegAAAA== To: gdb-patches@sourceware.org X-Mailer: b4 0.12.4 X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_ASCII_DIVIDERS,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This series started when a user noticed that gdb was very slow to print Ada records in a large program. I tracked this down and fixed it in patch #1. However, then I noticed that, with a little work, an entire method could be removed from quick_symbol_functions. This is desirable because this method was only used by Ada. I regression tested this on x86-64 Fedora 38. I also used regression tested using the .debug_names and .gdb_index target boards. It's also been run through the AdaCore internal test suite. --- Tom Tromey (4): Improve performance of Ada name searches Always use expand_symtabs_matching in ada-lang.c Remove split_style::UNDERSCORE Remove quick_symbol_functions::expand_matching_symbols gdb/ada-lang.c | 111 ++++-------------------- gdb/ada-lang.h | 14 +++- gdb/dwarf2/cooked-index.c | 6 +- gdb/dwarf2/read-debug-names.c | 46 ---------- gdb/dwarf2/read-gdb-index.c | 190 ------------------------------------------ gdb/dwarf2/read.c | 54 ------------ gdb/objfiles.h | 6 -- gdb/psymtab.c | 104 ----------------------- gdb/psymtab.h | 7 -- gdb/quick-symbol.h | 27 ------ gdb/split-name.c | 13 --- gdb/split-name.h | 2 - gdb/symfile-debug.c | 18 ---- gdb/symtab.h | 13 ++- 14 files changed, 40 insertions(+), 571 deletions(-) --- base-commit: 97b29a61f7f001550fe985bf2deea1550e3c20dd change-id: 20231121-ada-lookup-perf-67f46d937484 Best regards, -- Tom Tromey