From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta36.uswest2.a.cloudfilter.net (omta36.uswest2.a.cloudfilter.net [35.89.44.35]) by sourceware.org (Postfix) with ESMTPS id 3362A384CBB4 for ; Thu, 23 Nov 2023 05:32:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3362A384CBB4 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3362A384CBB4 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700717527; cv=none; b=f/MD45KN8hh92By/HL6wuBWGQu5Ksus2YFntIenVi1XaGBnbdQ3KE2YdbqJTonykbpBeECOJY9s04sEHCsiMddKjG8Sx4ig93nlXitVk445epJUyUxs9E56k8n96R8zVUlwGmODnmGd8jyrJe7y/PZoVFwjIfb/Q1kVUZKwlMhU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700717527; c=relaxed/simple; bh=inMecliu5J8TTp43M6XABw5SF9IPQtcLBJzPmOELtOc=; h=DKIM-Signature:From:Date:Subject:MIME-Version:Message-Id:To; b=NHd8Lc9MFNx/Gp/cFD90lnCDF4pzuVftCKbheKr1JTvS+t2OZmtzaCBaIBt4poFl+uubpZRFDl86IehWwYPZT4eWZWe8Zx2O1UzbWMYqCedXzF6QIljSJTCsZh6hG+qtGII0jKdXO5/v74KlX9GPserhmMHYar3k72j92zVvWnk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6002a.ext.cloudfilter.net ([10.0.30.222]) by cmsmtp with ESMTPS id 5v7Mrr37EhqFd62Jnrypak; Thu, 23 Nov 2023 05:32:03 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id 62JmrfBKVM0U262Jnr7V4e; Thu, 23 Nov 2023 05:32:03 +0000 X-Authority-Analysis: v=2.4 cv=BuKOfKb5 c=1 sm=1 tr=0 ts=655ee3d3 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=IkcTkHD0fZMA:10 a=BNY50KLci1gA:10 a=Qbun_eYptAEA:10 a=LS37jE6c6dNhwMZYAH4A:9 a=QEXdDO2ut3YA:10 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=To:In-Reply-To:References:Message-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:Subject:Date:From:Sender:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=YoLm7DxDkF6Q5ieEEhiX1x7qpvqW4vkjnZmznT7auA4=; b=NjEZ+YYJadeywQhNLGj0ZqbtHs UVrXZd5C5ITbjNM4qoChjgR2hkmX9fLFAyJuS3e4HcLuO1eo/2Nhj2OFg+Xtnz/3wEEfnOZ0I4AbM hbU3in/riJJScUgOyHYssZp3B; Received: from 97-122-77-73.hlrn.qwest.net ([97.122.77.73]:46354 helo=[192.168.0.21]) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1r62Jm-003TGR-1P for gdb-patches@sourceware.org; Wed, 22 Nov 2023 22:32:02 -0700 From: Tom Tromey Date: Wed, 22 Nov 2023 22:32:12 -0700 Subject: [PATCH v3 03/18] Add a couple of bfd_cache_close calls MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20231122-t-bg-dwarf-reading-v3-3-fc3180de63c4@tromey.com> References: <20231122-t-bg-dwarf-reading-v3-0-fc3180de63c4@tromey.com> In-Reply-To: <20231122-t-bg-dwarf-reading-v3-0-fc3180de63c4@tromey.com> To: gdb-patches@sourceware.org X-Mailer: b4 0.12.4 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.77.73 X-Source-L: No X-Exim-ID: 1r62Jm-003TGR-1P X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-77-73.hlrn.qwest.net ([192.168.0.21]) [97.122.77.73]:46354 X-Source-Auth: tom+tromey.com X-Email-Count: 5 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfEAaly5R+nbsU0d+v9tdWEbERs6pl0eCq50V0UEZF6R1ElwOl9seWEfYuKJbh8DlFaAQFk39lFlxVpX1vTz3fP/pjDFCv3PhnAvPUDu9gmV3hAc9i5pZ ZDkb5owHXY2C4Ha/S/YzfE8bX6wt/xnACr2018O+qpw5QYG1jtGlJGMxf8HA0nFl0zvJuo+E/gqmNHjOXA2SJb9raDwff1dZR40= X-Spam-Status: No, score=-3024.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,JMQ_SPF_NEUTRAL,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This adds a couple of calls to bfd_cache_close at points where a BFD isn't actively needed by gdb. Normally at these points, all the needed section data is already mapped, so we can simply close the file descriptor. This is harmless at worst, because if this is needed after all, the BFD file descriptor cache will reopen it. --- gdb/dwarf2/read.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c index 1c2f3f62399..6e6609ef86c 100644 --- a/gdb/dwarf2/read.c +++ b/gdb/dwarf2/read.c @@ -9182,6 +9182,8 @@ open_and_init_dwo_file (dwarf2_cu *cu, const char *dwo_name, dwarf_read_debug_printf ("DWO file found: %s", dwo_name); + bfd_cache_close (dwo_file->dbfd.get ()); + return dwo_file.release (); } @@ -9474,6 +9476,8 @@ open_and_init_dwp_file (dwarf2_per_objfile *per_objfile) pulongest (dwp_file->cus ? dwp_file->cus->nr_units : 0), pulongest (dwp_file->tus ? dwp_file->tus->nr_units : 0)); + bfd_cache_close (dwp_file->dbfd.get ()); + return dwp_file; } -- 2.41.0