From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 464A63858D39 for ; Fri, 24 Nov 2023 21:27:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 464A63858D39 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 464A63858D39 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700861221; cv=none; b=hDX8OOEpM0WEUwkpDqzdLY3TXl0biRNGD6Lqi5rYkRQeU8TCCd2i2kZmMtCQhx3CL9NCPvJoY1YBG/VHSkOqtgjuL1JEYgRqxoq67Ak049/OCE/ce60yJDzrfXV+5fls8FwccmBLVCIBd7mSHf/skOl9xeO9UVe0N53WYmaVNUU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700861221; c=relaxed/simple; bh=y/x3iTXnkOr7ujZT2bEDzqNXB61BeV2h8A/Ro4PEbUc=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=Zq4YYopjwIUJvqDFbSrZVIufRCEQiv+2YQuAevKF2V11TEv+TRpj3dyoyheVXnyCji8F3MO5tPxiJMpCz60ZTCc5QLunV4wQKlHKuN+ynIhEnTAGrUY7DAE4TFespjv75oOMCVPX0vPNTwBeUfYOYxgl5pvwBc4sB2vvIPlF260= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from smarchi-efficios.internal.efficios.com (192-222-143-198.qc.cable.ebox.net [192.222.143.198]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 5B51A1E098; Fri, 24 Nov 2023 16:26:59 -0500 (EST) From: Simon Marchi To: gdb-patches@sourceware.org Cc: Luis Machado , John Baldwin , Andrew Burgess , Simon Marchi , John Baldwin Subject: [PATCH v2 01/24] gdb: don't handle i386 k registers as pseudo registers Date: Fri, 24 Nov 2023 16:26:18 -0500 Message-ID: <20231124212656.96801-2-simon.marchi@efficios.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231124212656.96801-1-simon.marchi@efficios.com> References: <20231124212656.96801-1-simon.marchi@efficios.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3496.8 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_NONE,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_SOFTFAIL,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: I think that i386 k registers are raw registers, and therefore shouldn't be handled in the various functions handling pseudo registers. What tipped me off is the code in i386_pseudo_register_read_into_value: else if (i386_k_regnum_p (gdbarch, regnum)) { regnum -= tdep->k0_regnum; /* Extract (always little endian). */ status = regcache->raw_read (tdep->k0_regnum + regnum, raw_buf); We take regnum (the pseudo register number we want to read), subtract k0_regnum, add k0_regnum, and pass the result to raw_read. So we would end up calling raw_read with the same regnum as the function received which is supposedly a pseudo register number. Other hints are: - The command `maint print raw-registers` shows the k registers. - Printing $k0 doesn't cause i386_pseudo_register_read_into_value to be called. - There's code in i387-tdep.c to save/restore the k registers. Remove handling of the k registers from: - i386_pseudo_register_read_into_value - i386_pseudo_register_write - i386_ax_pseudo_register_collect Change-Id: Ic97956ed59af6099fef6d36a0b61464172694562 Reviewed-by: John Baldwin --- gdb/i386-tdep.c | 23 ----------------------- 1 file changed, 23 deletions(-) diff --git a/gdb/i386-tdep.c b/gdb/i386-tdep.c index f5ff55de47ac..7a395cb41f3f 100644 --- a/gdb/i386-tdep.c +++ b/gdb/i386-tdep.c @@ -3464,17 +3464,6 @@ i386_pseudo_register_read_into_value (struct gdbarch *gdbarch, memcpy (buf + size, &upper, size); } } - else if (i386_k_regnum_p (gdbarch, regnum)) - { - regnum -= tdep->k0_regnum; - - /* Extract (always little endian). */ - status = regcache->raw_read (tdep->k0_regnum + regnum, raw_buf); - if (status != REG_VALID) - result_value->mark_bytes_unavailable (0, 8); - else - memcpy (buf, raw_buf, 8); - } else if (i386_zmm_regnum_p (gdbarch, regnum)) { regnum -= tdep->zmm0_regnum; @@ -3656,12 +3645,6 @@ i386_pseudo_register_write (struct gdbarch *gdbarch, struct regcache *regcache, regcache->raw_write (I387_BND0R_REGNUM (tdep) + regnum, raw_buf); } - else if (i386_k_regnum_p (gdbarch, regnum)) - { - regnum -= tdep->k0_regnum; - - regcache->raw_write (tdep->k0_regnum + regnum, buf); - } else if (i386_zmm_regnum_p (gdbarch, regnum)) { regnum -= tdep->zmm0_regnum; @@ -3758,12 +3741,6 @@ i386_ax_pseudo_register_collect (struct gdbarch *gdbarch, ax_reg_mask (ax, I387_BND0R_REGNUM (tdep) + regnum); return 0; } - else if (i386_k_regnum_p (gdbarch, regnum)) - { - regnum -= tdep->k0_regnum; - ax_reg_mask (ax, tdep->k0_regnum + regnum); - return 0; - } else if (i386_zmm_regnum_p (gdbarch, regnum)) { regnum -= tdep->zmm0_regnum; -- 2.43.0