From: Tom Tromey <tromey@adacore.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 1/2] Boolify ada_type_match
Date: Tue, 05 Dec 2023 08:37:12 -0700 [thread overview]
Message-ID: <20231205-ada-overload-v1-1-9d97ac80a60e@adacore.com> (raw)
In-Reply-To: <20231205-ada-overload-v1-0-9d97ac80a60e@adacore.com>
This changes ada_type_match to return bool.
---
gdb/ada-lang.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c
index 1a591567cda..9d5c8d5534b 100644
--- a/gdb/ada-lang.c
+++ b/gdb/ada-lang.c
@@ -3934,7 +3934,7 @@ ada_resolve_variable (struct symbol *sym, const struct block *block,
/* The term "match" here is rather loose. The match is heuristic and
liberal. */
-static int
+static bool
ada_type_match (struct type *ftype, struct type *atype)
{
ftype = ada_check_typedef (ftype);
@@ -3951,11 +3951,11 @@ ada_type_match (struct type *ftype, struct type *atype)
return ftype->code () == atype->code ();
case TYPE_CODE_PTR:
if (atype->code () != TYPE_CODE_PTR)
- return 0;
+ return false;
atype = atype->target_type ();
/* This can only happen if the actual argument is 'null'. */
if (atype->code () == TYPE_CODE_INT && atype->length () == 0)
- return 1;
+ return true;
return ada_type_match (ftype->target_type (), atype);
case TYPE_CODE_INT:
case TYPE_CODE_ENUM:
@@ -3965,9 +3965,9 @@ ada_type_match (struct type *ftype, struct type *atype)
case TYPE_CODE_INT:
case TYPE_CODE_ENUM:
case TYPE_CODE_RANGE:
- return 1;
+ return true;
default:
- return 0;
+ return false;
}
case TYPE_CODE_ARRAY:
--
2.43.0
next prev parent reply other threads:[~2023-12-05 15:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-05 15:37 [PATCH 0/2] Improve Ada overload handling Tom Tromey
2023-12-05 15:37 ` Tom Tromey [this message]
2023-12-05 15:37 ` [PATCH 2/2] Refine Ada overload matching Tom Tromey
2023-12-15 19:34 ` [PATCH 0/2] Improve Ada overload handling Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231205-ada-overload-v1-1-9d97ac80a60e@adacore.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).