From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta36.uswest2.a.cloudfilter.net (omta36.uswest2.a.cloudfilter.net [35.89.44.35]) by sourceware.org (Postfix) with ESMTPS id B4A243858C60 for ; Tue, 5 Dec 2023 21:23:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B4A243858C60 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B4A243858C60 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701811400; cv=none; b=umysKYItWM6eZ0DcmKYaq8MVC7k6CinVS7ZfxSGRZCFWxdRe0kSpULvboXTmFPXpB2N/r7wnzFGdl9ZTuwZPmW9JW4CXnqlIMqtLL3SYNt36Uf/36CXeCYspibEJyoYY7hbiLCZmf6P8oItGd5FDlQwN5q/O8NAhOqubYyUhFnI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701811400; c=relaxed/simple; bh=VyLuQopM0H0jIaEXGxCh0nnggsJhUaHexSf4PeyVLeA=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=nhPdP1lAMSHBUxSqH29ecsfCPNM3vLgZ4sLAexjV6qSGTgC76thL4ukkuLiavmlWWexiSGai364Za+wOc110grCVr6UDecFNcI5QEWnCPowFi0bR3ONAWNOZ50VV4f1QODnqLYAn/3v6y2cjFEvrksh6yHXRuxFn+svXdOuKOYY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6010a.ext.cloudfilter.net ([10.0.30.248]) by cmsmtp with ESMTPS id AZfCruJ3nhqFdAcsvrpoZZ; Tue, 05 Dec 2023 21:23:17 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id AcsurT2aK8vT0Acsvrp6Mq; Tue, 05 Dec 2023 21:23:17 +0000 X-Authority-Analysis: v=2.4 cv=ffi+dmcF c=1 sm=1 tr=0 ts=656f94c5 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=e2cXIFwxEfEA:10 a=Qbun_eYptAEA:10 a=SyyLhFnIg0uYJjmvHjcA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject: Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=FsBYTqPXaex/ppbjsHSid/HL+ChjAd77oN3gD2GHdqk=; b=ynRJHdGLNK6P6GevcC6FtSPrrJ NJakKjrxkJt5ka3cnhUYrFl8Eu4JDM56CEXAqJyBXzMpsauZh3llgfAC+zbyiEm5twql3FkMFTYxe IsuDWeZm0Dx+w/7kMb8Iivc7X; Received: from 97-122-77-73.hlrn.qwest.net ([97.122.77.73]:32976 helo=localhost.localdomain) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rAcsu-001Xn9-1i; Tue, 05 Dec 2023 14:23:16 -0700 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH] Start abbrevs at 1 in DWARF assembler Date: Tue, 5 Dec 2023 14:23:06 -0700 Message-ID: <20231205212306.1438059-1-tom@tromey.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.77.73 X-Source-L: No X-Exim-ID: 1rAcsu-001Xn9-1i X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-77-73.hlrn.qwest.net (localhost.localdomain) [97.122.77.73]:32976 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfDkYQJvvQ79Zl1hwJoGKEF/1xPRXroQO4OsItBK6IVGXyh64pL0x3TrUH+wzQ9ki0rRyEOcvH85OOX4hKWHKNErpSkVgMn2cSZQXrBw5E/rfWZEefkqr 4PTFlTnCjzGCZJhZyDm86JmdBF5rfmcfDXyNGX0C6bVIZ5EJTEjMJSuflImLv4eLg5URoCq4QH3Asl6RHprU7a2NUI/sQi3JqPQ= X-Spam-Status: No, score=-3023.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,JMQ_SPF_NEUTRAL,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: I noticed that the DWARF assembler starts abbrevs at 2. I think 1 should be preferred. --- gdb/testsuite/lib/dwarf.exp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/gdb/testsuite/lib/dwarf.exp b/gdb/testsuite/lib/dwarf.exp index f09da0430ab..19c89c048fe 100644 --- a/gdb/testsuite/lib/dwarf.exp +++ b/gdb/testsuite/lib/dwarf.exp @@ -564,8 +564,8 @@ namespace eval Dwarf { # for Fission. variable _abbrev_section - # The next available abbrev number in the current CU's abbrev - # table. + # The most recently assigned abbrev number in the current CU's + # abbrev table. variable _abbrev_num # The string table for this assembly. The key is the string; the @@ -1485,7 +1485,7 @@ namespace eval Dwarf { set cu_num [incr _cu_count] set my_abbrevs [_compute_label "abbrev${cu_num}_begin"] - set _abbrev_num 1 + set _abbrev_num 0 set _cu_label [_compute_label "cu${cu_num}_begin"] set start_label [_compute_label "cu${cu_num}_start"] @@ -1597,7 +1597,7 @@ namespace eval Dwarf { set cu_num [incr _cu_count] set my_abbrevs [_compute_label "abbrev${cu_num}_begin"] - set _abbrev_num 1 + set _abbrev_num 0 set _cu_label [_compute_label "cu${cu_num}_begin"] set start_label [_compute_label "cu${cu_num}_start"] -- 2.43.0