From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id 7CB7B385C6EC for ; Thu, 7 Dec 2023 03:59:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7CB7B385C6EC Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7CB7B385C6EC Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=140.211.166.183 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701921585; cv=none; b=phl5VZuK6INR/Zlqv6tMYKD/pZt/RzeLrcfvIQB34Hcs1wRQtz74tnT1hzVl1fbXzNmJKlEOdcvW4dhCY3bBObI85i1x6OJoH5rr0YtUvk0PfpxZHiT1cvug+AqZj9OAyBMhkMubFFgqqCdp59TIhunJghvl4HUcYcZu1tqZyM4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701921585; c=relaxed/simple; bh=GB6h2PSj64rlNl2xpeQtJDb2fTTvc1T1fQs1lui8xuE=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=tXXv7j9tQ8K26dhtfZrCKaX40fqgUENtYEePrbjeNZhg4rZxiek6092NBPreXh4GuC6oDasxB2wkDO/DOL78dSaLHhk2s3aH1rBa+CJabM0Ju+c5NWEb8igeZZ6ZMEszZdduqjhS5nwZGR2ay+necEBRh1ko+kRulaDNN2sIvdc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by smtp.gentoo.org (Postfix, from userid 559) id 06BFC335D6E; Thu, 7 Dec 2023 03:59:43 +0000 (UTC) From: Mike Frysinger To: gdb-patches@sourceware.org Subject: [PATCH 03/17] sim: bfin: fix -Wunused-but-set-variable warnings Date: Wed, 6 Dec 2023 20:59:23 -0700 Message-ID: <20231207035937.14920-3-vapier@gentoo.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231207035937.14920-1-vapier@gentoo.org> References: <20231207035937.14920-1-vapier@gentoo.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,GIT_PATCH_0,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE,UNWANTED_LANGUAGE_BODY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --- sim/bfin/bfin-sim.c | 3 ++- sim/bfin/dv-bfin_emac.c | 3 --- sim/bfin/dv-bfin_mmu.c | 4 +--- sim/bfin/dv-bfin_pll.c | 2 -- sim/bfin/dv-bfin_rtc.c | 2 -- sim/bfin/dv-bfin_sic.c | 8 -------- 6 files changed, 3 insertions(+), 19 deletions(-) diff --git a/sim/bfin/bfin-sim.c b/sim/bfin/bfin-sim.c index a9b8fd09220f..12c7827f9ec4 100644 --- a/sim/bfin/bfin-sim.c +++ b/sim/bfin/bfin-sim.c @@ -1592,7 +1592,8 @@ decode_macfunc (SIM_CPU *cpu, int which, int op, int h0, int h1, int src0, if (op != 3) { - bu8 sgn0 = (acc >> 31) & 1; + /* TODO: Figure out how the 32-bit sign is used. */ + ATTRIBUTE_UNUSED bu8 sgn0 = (acc >> 31) & 1; bu8 sgn40 = (acc >> 39) & 1; bu40 nosat_acc; diff --git a/sim/bfin/dv-bfin_emac.c b/sim/bfin/dv-bfin_emac.c index 0288b7404999..1ab7cd63554d 100644 --- a/sim/bfin/dv-bfin_emac.c +++ b/sim/bfin/dv-bfin_emac.c @@ -539,11 +539,8 @@ bfin_emac_tap_init (struct hw *me) { #if WITH_TUN struct bfin_emac *emac = hw_data (me); - const hw_unit *unit; int flags; - unit = hw_unit_address (me); - emac->tap = open ("/dev/net/tun", O_RDWR); if (emac->tap == -1) { diff --git a/sim/bfin/dv-bfin_mmu.c b/sim/bfin/dv-bfin_mmu.c index 71c7176b88bf..c14e2088c1f1 100644 --- a/sim/bfin/dv-bfin_mmu.c +++ b/sim/bfin/dv-bfin_mmu.c @@ -451,7 +451,7 @@ _mmu_check_addr (SIM_CPU *cpu, bu32 addr, bool write, bool inst, int size) { SIM_DESC sd = CPU_STATE (cpu); struct bfin_mmu *mmu; - bu32 *fault_status, *fault_addr, *mem_control, *cplb_addr, *cplb_data; + bu32 *mem_control, *cplb_addr, *cplb_data; bu32 faults; bool supv, do_excp, dag1; int i, hits; @@ -469,8 +469,6 @@ _mmu_check_addr (SIM_CPU *cpu, bu32 addr, bool write, bool inst, int size) } mmu = MMU_STATE (cpu); - fault_status = inst ? &mmu->icplb_fault_status : &mmu->dcplb_fault_status; - fault_addr = inst ? &mmu->icplb_fault_addr : &mmu->dcplb_fault_addr; mem_control = inst ? &mmu->imem_control : &mmu->dmem_control; cplb_addr = inst ? &mmu->icplb_addr[0] : &mmu->dcplb_addr[0]; cplb_data = inst ? &mmu->icplb_data[0] : &mmu->dcplb_data[0]; diff --git a/sim/bfin/dv-bfin_pll.c b/sim/bfin/dv-bfin_pll.c index dd95013f2f49..863b07f49ec3 100644 --- a/sim/bfin/dv-bfin_pll.c +++ b/sim/bfin/dv-bfin_pll.c @@ -56,7 +56,6 @@ bfin_pll_io_write_buffer (struct hw *me, const void *source, bu32 mmr_off; bu32 value; bu16 *value16p; - bu32 *value32p; void *valuep; /* Invalid access mode is higher priority than missing register. */ @@ -71,7 +70,6 @@ bfin_pll_io_write_buffer (struct hw *me, const void *source, mmr_off = addr - pll->base; valuep = (void *)((uintptr_t)pll + mmr_base() + mmr_off); value16p = valuep; - value32p = valuep; HW_TRACE_WRITE (); diff --git a/sim/bfin/dv-bfin_rtc.c b/sim/bfin/dv-bfin_rtc.c index b6ae0a537712..fdb63f3a4f9a 100644 --- a/sim/bfin/dv-bfin_rtc.c +++ b/sim/bfin/dv-bfin_rtc.c @@ -59,7 +59,6 @@ bfin_rtc_io_write_buffer (struct hw *me, const void *source, bu32 mmr_off; bu32 value; bu16 *value16p; - bu32 *value32p; void *valuep; /* Invalid access mode is higher priority than missing register. */ @@ -74,7 +73,6 @@ bfin_rtc_io_write_buffer (struct hw *me, const void *source, mmr_off = addr - rtc->base; valuep = (void *)((uintptr_t)rtc + mmr_base() + mmr_off); value16p = valuep; - value32p = valuep; HW_TRACE_WRITE (); diff --git a/sim/bfin/dv-bfin_sic.c b/sim/bfin/dv-bfin_sic.c index 5210cf0a8eeb..ac302a7f8519 100644 --- a/sim/bfin/dv-bfin_sic.c +++ b/sim/bfin/dv-bfin_sic.c @@ -147,7 +147,6 @@ bfin_sic_52x_io_write_buffer (struct hw *me, const void *source, int space, struct bfin_sic *sic = hw_data (me); bu32 mmr_off; bu32 value; - bu16 *value16p; bu32 *value32p; void *valuep; @@ -162,7 +161,6 @@ bfin_sic_52x_io_write_buffer (struct hw *me, const void *source, int space, mmr_off = addr - sic->base; valuep = (void *)((uintptr_t)sic + mmr_base() + mmr_off); - value16p = valuep; value32p = valuep; HW_TRACE_WRITE (); @@ -261,7 +259,6 @@ bfin_sic_537_io_write_buffer (struct hw *me, const void *source, int space, struct bfin_sic *sic = hw_data (me); bu32 mmr_off; bu32 value; - bu16 *value16p; bu32 *value32p; void *valuep; @@ -276,7 +273,6 @@ bfin_sic_537_io_write_buffer (struct hw *me, const void *source, int space, mmr_off = addr - sic->base; valuep = (void *)((uintptr_t)sic + mmr_base() + mmr_off); - value16p = valuep; value32p = valuep; HW_TRACE_WRITE (); @@ -375,7 +371,6 @@ bfin_sic_54x_io_write_buffer (struct hw *me, const void *source, int space, struct bfin_sic *sic = hw_data (me); bu32 mmr_off; bu32 value; - bu16 *value16p; bu32 *value32p; void *valuep; @@ -390,7 +385,6 @@ bfin_sic_54x_io_write_buffer (struct hw *me, const void *source, int space, mmr_off = addr - sic->base; valuep = (void *)((uintptr_t)sic + mmr_base() + mmr_off); - value16p = valuep; value32p = valuep; HW_TRACE_WRITE (); @@ -482,7 +476,6 @@ bfin_sic_561_io_write_buffer (struct hw *me, const void *source, int space, struct bfin_sic *sic = hw_data (me); bu32 mmr_off; bu32 value; - bu16 *value16p; bu32 *value32p; void *valuep; @@ -497,7 +490,6 @@ bfin_sic_561_io_write_buffer (struct hw *me, const void *source, int space, mmr_off = addr - sic->base; valuep = (void *)((uintptr_t)sic + mmr_base() + mmr_off); - value16p = valuep; value32p = valuep; HW_TRACE_WRITE (); -- 2.43.0