From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta40.uswest2.a.cloudfilter.net (omta40.uswest2.a.cloudfilter.net [35.89.44.39]) by sourceware.org (Postfix) with ESMTPS id 6C4DD3858284 for ; Sun, 10 Dec 2023 16:45:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6C4DD3858284 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6C4DD3858284 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702226711; cv=none; b=I7YYEoSMGqERQkpnc8T/22jQ5kgZUUfxdstBdyP1h9t29/ZIVp4F5As8tw7pWyi1MCfw1Ox/SRKgcltslf79vFK06Tnep/B+kmAd+xlxszGNfDF2MRtrpZbMg8oR1lFEh3mE+CpkY9tERKR6V40q422WIsuQSpN8w3AUfTf7Ayo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702226711; c=relaxed/simple; bh=DY280uxEo1zhb0RZXkC+Kdmgz7QmVDY2u4w4k80ms0A=; h=DKIM-Signature:From:Date:Subject:MIME-Version:Message-Id:To; b=j7gB1i3bdLNofdhdX4oMiaLsvbQIG9HEhVyjcRmarJdsQh0WbQRehNTy4V8Ebg5JEBWG5lHiBNvBKZpBA9nU4kvNlDsRCk/XJldEhO07DG6bim+kwzcX0TEehrVIeJkcBW4I+0Np5W07N9nOhOLDSxSSGRDLiHjFARAehrCYC5g= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5010a.ext.cloudfilter.net ([10.0.29.199]) by cmsmtp with ESMTPS id BrJlr7OrrL9AgCMvRrXN6Q; Sun, 10 Dec 2023 16:45:05 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id CMvQrwfEGhDnyCMvQr8GjB; Sun, 10 Dec 2023 16:45:05 +0000 X-Authority-Analysis: v=2.4 cv=fda+dmcF c=1 sm=1 tr=0 ts=6575eb11 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=IkcTkHD0fZMA:10 a=e2cXIFwxEfEA:10 a=Qbun_eYptAEA:10 a=CCpqsmhAAAAA:8 a=ku71GV4P9AfvSfq13ykA:9 a=QEXdDO2ut3YA:10 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=To:In-Reply-To:References:Message-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:Subject:Date:From:Sender:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=W0ZhSHB9B+EV868NOH3v6a9dz9IctFQjv7Z4SCtXN3Q=; b=Qc6EHz+cwBO6g3IrQzzx2M/q9z 5n7VWBio1TrXC7LGgv2pBEJ28LJkjX/+qRIIlO0UV79LjSsOUfjKMCjIghUb4UDeODwBamnu2yrtW xKZM25H87eWHeVfgb8MOqGlBH; Received: from [198.59.47.65] (port=52394 helo=[192.168.131.83]) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rCMvQ-001rpu-0a for gdb-patches@sourceware.org; Sun, 10 Dec 2023 09:45:04 -0700 From: Tom Tromey Date: Sun, 10 Dec 2023 09:45:00 -0700 Subject: [PATCH 11/17] Empty hash table fix in .debug_names reader MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20231210-debug-names-fix-v1-11-a8f6d2525018@tromey.com> References: <20231210-debug-names-fix-v1-0-a8f6d2525018@tromey.com> In-Reply-To: <20231210-debug-names-fix-v1-0-a8f6d2525018@tromey.com> To: gdb-patches@sourceware.org X-Mailer: b4 0.12.4 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 198.59.47.65 X-Source-L: No X-Exim-ID: 1rCMvQ-001rpu-0a X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.131.83]) [198.59.47.65]:52394 X-Source-Auth: tom+tromey.com X-Email-Count: 12 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfAqdUTy3fZ1/Po4EbFyCTaMW0QrVHivdljSyWCfR86AUiJQei1fYs8bbMNlR1D5jD9FsZR2aodEfz8h3wIXWbU5ID8tOdCNJHrcRNzZsN13nYLSEP6LS ZJqqbZwsL4bHKaSt0yAKXKZ2sTu4JYtXtZKG/FymKLWuJJP2rZAWH6EhEZ80PL4W4kAwCY2il/k61ZDjiLKzv0bNNYJks2oAImU= X-Spam-Status: No, score=-3024.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,JMQ_SPF_NEUTRAL,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: The handling of an empty hash table in the .debug_names reader is slightly wrong. Currently the code assumes there is always an array of hashes. However, section 6.1.1.4.5 Hash Lookup Table says: The optional hash lookup table immediately follows the list of type signatures. and then: The hash lookup table is actually two separate arrays: an array of buckets, followed immediately by an array of hashes. My reading of this is that the hash table as a whole is optional, and so the hashes will not exist in this case. (This also makes sense because the hashes are not useful without the buckets anyway.) Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=25950 --- gdb/dwarf2/read-debug-names.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gdb/dwarf2/read-debug-names.c b/gdb/dwarf2/read-debug-names.c index e912c2a1114..c6b70550f81 100644 --- a/gdb/dwarf2/read-debug-names.c +++ b/gdb/dwarf2/read-debug-names.c @@ -290,7 +290,8 @@ read_debug_names_from_section (struct objfile *objfile, map.bucket_table_reordered = reinterpret_cast (addr); addr += map.bucket_count * 4; map.hash_table_reordered = reinterpret_cast (addr); - addr += map.name_count * 4; + if (map.bucket_count != 0) + addr += map.name_count * 4; /* Name Table */ map.name_table_string_offs_reordered = addr; -- 2.43.0