From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta34.uswest2.a.cloudfilter.net (omta34.uswest2.a.cloudfilter.net [35.89.44.33]) by sourceware.org (Postfix) with ESMTPS id 30C003858298 for ; Sun, 10 Dec 2023 21:41:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 30C003858298 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 30C003858298 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702244486; cv=none; b=FjmcJ6R4jlgoS266ehxkmeIgP2vRpOoGqGSAsQM/eIdNsV2KxCS9Ab4mVfSQDboCf0YiM0x0/UVZUKEPw36UuIyPTk0ZAvDmLdanZTO2fmePKEUXrWA0S12llHgSg/7PFibaEUzV45Il3WS+WLYTueb+hWuFM2PFJ3TAY4BgJ40= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702244486; c=relaxed/simple; bh=BVa92JrrmpW/6ntpXXVveyffDlrJA4dbbExbcqoHvL8=; h=DKIM-Signature:From:Date:Subject:MIME-Version:Message-Id:To; b=QHfcQ+WERikoB15NCLeuJuneBD0oX2lIHfIn1dxIP1HmxRam2ipmIj7lMO8MwAOY4wuyQjBRSDAH3VYWFDKPU+AuSDpOv/Os7Hg02B37YPoAHp1+fvQtCAMfIHCygvY96lB/UxTBCMGiuQu+ijn5kDTfZ+DTGpm62EEJTCB16uA= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5008a.ext.cloudfilter.net ([10.0.29.246]) by cmsmtp with ESMTPS id CEjLr4APd8HteCRY9r9Z7S; Sun, 10 Dec 2023 21:41:21 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id CRY8rSUxFkUbtCRY8r37Mh; Sun, 10 Dec 2023 21:41:20 +0000 X-Authority-Analysis: v=2.4 cv=WpU4jPTv c=1 sm=1 tr=0 ts=65763080 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=IkcTkHD0fZMA:10 a=e2cXIFwxEfEA:10 a=Qbun_eYptAEA:10 a=LS37jE6c6dNhwMZYAH4A:9 a=QEXdDO2ut3YA:10 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=To:In-Reply-To:References:Message-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:Subject:Date:From:Sender:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=TuyYOb9kMXgp1cUOxkmsjcp2ouVdMhbMZpJD5ulRd28=; b=nX+x1pkyLjKjTv5xKAtrot0HMG qfnS5eynYukppwYorilNe3TFBpsiaj9H0e1vZUXPJ/YnBsAPRQWAJOrpesruyX1/S7AC9yUUTz1ge F1gZoLsJif+40Th4XPwxtjPL/; Received: from [198.59.47.65] (port=52450 helo=[192.168.131.83]) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rCRY7-000SHj-2h for gdb-patches@sourceware.org; Sun, 10 Dec 2023 14:41:19 -0700 From: Tom Tromey Date: Sun, 10 Dec 2023 14:41:11 -0700 Subject: [PATCH v4 03/19] Add a couple of bfd_cache_close calls MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20231210-t-bg-dwarf-reading-v4-3-b978c32fd12f@tromey.com> References: <20231210-t-bg-dwarf-reading-v4-0-b978c32fd12f@tromey.com> In-Reply-To: <20231210-t-bg-dwarf-reading-v4-0-b978c32fd12f@tromey.com> To: gdb-patches@sourceware.org X-Mailer: b4 0.12.4 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 198.59.47.65 X-Source-L: No X-Exim-ID: 1rCRY7-000SHj-2h X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.131.83]) [198.59.47.65]:52450 X-Source-Auth: tom+tromey.com X-Email-Count: 5 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfCFIaBPtD11lcfSuf+zIYvz7IPGNp0rf3xkhDxv+vUNucvfT5mLsgkHWHzlaGJwZeuQEHczUu8uqz8Nc4A8pXyl5DE/+6DkUfQ5kx1+UwTWaNA1oLKrc ZmRwYDe1kbegUG0JT+EJcEZMdXpYp8YWVG8DF7dMqLDT9NAdxO0drBpc+0aHvijSOSXHMTyQsZkSrzVUJmK154eXMBrFML9FYiM= X-Spam-Status: No, score=-3024.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,JMQ_SPF_NEUTRAL,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This adds a couple of calls to bfd_cache_close at points where a BFD isn't actively needed by gdb. Normally at these points, all the needed section data is already mapped, so we can simply close the file descriptor. This is harmless at worst, because if this is needed after all, the BFD file descriptor cache will reopen it. --- gdb/dwarf2/read.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c index 9fd61eb0777..ba58dae12bb 100644 --- a/gdb/dwarf2/read.c +++ b/gdb/dwarf2/read.c @@ -9170,6 +9170,8 @@ open_and_init_dwo_file (dwarf2_cu *cu, const char *dwo_name, dwarf_read_debug_printf ("DWO file found: %s", dwo_name); + bfd_cache_close (dwo_file->dbfd.get ()); + return dwo_file.release (); } @@ -9462,6 +9464,8 @@ open_and_init_dwp_file (dwarf2_per_objfile *per_objfile) pulongest (dwp_file->cus ? dwp_file->cus->nr_units : 0), pulongest (dwp_file->tus ? dwp_file->tus->nr_units : 0)); + bfd_cache_close (dwp_file->dbfd.get ()); + return dwp_file; } -- 2.43.0