From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 0808E38582B6 for ; Mon, 18 Dec 2023 20:02:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0808E38582B6 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0808E38582B6 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702929789; cv=none; b=mQVdO0sBu5qbbpKilquTwZdQE3DdgDMurab3MP7IR2ZhMzF1cOXAlLK7wy4GzRSpmKXuLlvIfqv/bipQMlSGCkG0rzzIuTSVghqfyNu6JnikwEWbfWpD6AmJE86Ub87ypS4UkG0CTTnT6qTOZiidEXSzvYulpx/dLeX7V5uTILQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702929789; c=relaxed/simple; bh=mJE7af0iCjKnuhmwNXEfNZV/txwd/sH8HF8JEPIj1tE=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=WG7mBzAXWXCqi37ruwYoEkoH+fZIQF6S+71GXRthLeVR0PdrQsPlY0zzwAZ/eZSy+tmo4p8LxjKC2yrOviIHMxxuPz5aYXnyN3+jF7kP26VOQbL8+ecne9cc8k6Mnwy0mVMzWRUMRYpRYY3n2r/nvP5WBOcbjMnnpOIto8IW8ek= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from smarchi-efficios.internal.efficios.com (192-222-143-198.qc.cable.ebox.net [192.222.143.198]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 0FB241E0AC; Mon, 18 Dec 2023 15:02:57 -0500 (EST) From: Simon Marchi To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [PATCH 1/2] gdb: remove stale comment in value_assign Date: Mon, 18 Dec 2023 15:02:46 -0500 Message-ID: <20231218200256.28489-1-simon.marchi@efficios.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3496.6 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_NONE,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_SOFTFAIL,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This comment is no longer relevant, put_frame_register_bytes now accepts the "next frame". Change-Id: I077933a03f8bdb886f8ba10a98d1202a38bce0a9 --- gdb/valops.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/gdb/valops.c b/gdb/valops.c index 21b010684af1..049314cf7db5 100644 --- a/gdb/valops.c +++ b/gdb/valops.c @@ -1193,13 +1193,6 @@ value_assign (struct value *toval, struct value *fromval) case lval_register: { - /* Figure out which frame this register value is in. The value - holds the frame_id for the next frame, that is the frame this - register value was unwound from. - - Below we will call put_frame_register_bytes which requires that - we pass it the actual frame in which the register value is - valid, i.e. not the next frame. */ frame_info_ptr next_frame = frame_find_by_id (VALUE_NEXT_FRAME_ID (toval)); int value_reg = VALUE_REGNUM (toval); base-commit: 989ea4061f275edb85ab5de8f908be5a273bd05a -- 2.43.0