From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2082.outbound.protection.outlook.com [40.107.7.82]) by sourceware.org (Postfix) with ESMTPS id C14FD3858D38; Tue, 19 Dec 2023 03:09:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C14FD3858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=axis.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=axis.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C14FD3858D38 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.7.82 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1702955351; cv=pass; b=LGgpQN8KAm+GNb2m61y9VyLA5CVEtm8RAuqq5OeqtLB3i+dOGe3+7XhvSFCGIH5tWJkRI4FmGnSrIpYydq51g6aOMxdgW72iXhxZGvgrfze/eeZ9De8Zo+IKay8CTiIWcZGw/U9uvXp7V2866xFzzYB5D6eiEocGR6DzLOeQqPw= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1702955351; c=relaxed/simple; bh=mHKVkPjmF0pFiCdbc8W4kjO2mfOz3kybOw7AjNZgjL0=; h=DKIM-Signature:From:To:Subject:MIME-Version:Message-ID:Date; b=faS0gmZopeo2wJi7s3QRgCx0kOopVt9ok9/4odGuYKjyfKYMD2iVhFbNwrU1cVUPUM6yGFq4yO3S8YfzjOWzL4NsjwAARzPc6REFwhwbkXAGXzGCgt4L+mhnAONP0eziXBD6GtUdi1d+mHa+iBWyZR2+/BNAabubb2yhJazK8MI= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fz+D3l3TsWK1tEFUOwQItUR+j5kfBi+TgIp7bngkvq4zBW0F6QQ8zsn4B0EDQUen/Gy8cs5ZUoj34+Quh1YUwgdVR8AK4cJA3eGCLs4G4lzdPkVZh4E0Ox9gMQ9rKWi/CoCmCUJMSEBcZxdoDHgzwsVhkfQrzz/WPS9qxW4O/bCo9zedgAADojraEYbFF/ZOAruVivbQNsY0QO0xz2QYgI0b2YBGB8F7M7V7vTZrmN48Y+s0EVXAHJrd4lB6XXfGWV31iTaGOHBEyp7q0iHuhK51w9cvG7+0N5lXMULga8ZlQvDWdV05YU1MdfxaD1AiYMRvkLdaMo270OO/je/M7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dviHEU9VHxb3sWYhJRrcu1k5itlxqr04ruQv2BltJ+E=; b=lK/mNzjmbHh0+lkXfwYK3hqFeNjCTakAEdhG9NyQgzaLSLYkH3jBr22Gex2qx6UumqxmsJEQgmXTvDsoau9WDinjLn0nPtu1Yx4USuw1FC4P85B2H/TkQnFfD5muCD7SQGKcowjwHfqU9YQz2DAZ1j3QUoyzAeonOaBB07jgbwmVMoSWAiJq1buY/kqWhTmgmZPfVtOP3B8zqRcxVCqYWT5DXh9E63GMsB+AdtcHFEC4Z/pFfED6unV5w/7tZPOyWT6WA5EWyoDlI+2WfGUZO82uzp5ZbWeSvqQPDGHFF20GS/TFHElgGRpqgFx3FyX0z7H/CDwQ2IrI1Kc7aXmuQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 195.60.68.100) smtp.rcpttodomain=gentoo.org smtp.mailfrom=axis.com; dmarc=fail (p=none sp=none pct=100) action=none header.from=axis.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axis.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dviHEU9VHxb3sWYhJRrcu1k5itlxqr04ruQv2BltJ+E=; b=O2zwic/Zs+tgkvQEGSaV5EY3e2Rxnp80rop+sFqxrUscXEvuXw9LtEjXdtWbicO0NeFCrR80xwWOhs9/uKk73kC9Y78b2icpkQA5LhP9DVEF07FnCh34uyFIyKjENPOga7adyPDgZsjKbmTLNmtuTQHtkHIgiJdteJHOQsxmihk= Received: from DB6PR0301CA0084.eurprd03.prod.outlook.com (2603:10a6:6:30::31) by AS8PR02MB9185.eurprd02.prod.outlook.com (2603:10a6:20b:5b4::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.38; Tue, 19 Dec 2023 03:09:06 +0000 Received: from DB5PEPF00014B8B.eurprd02.prod.outlook.com (2603:10a6:6:30:cafe::c2) by DB6PR0301CA0084.outlook.office365.com (2603:10a6:6:30::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.38 via Frontend Transport; Tue, 19 Dec 2023 03:09:05 +0000 X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 195.60.68.100) smtp.mailfrom=axis.com; dkim=none (message not signed) header.d=none;dmarc=fail action=none header.from=axis.com; Received-SPF: Fail (protection.outlook.com: domain of axis.com does not designate 195.60.68.100 as permitted sender) receiver=protection.outlook.com; client-ip=195.60.68.100; helo=mail.axis.com; Received: from mail.axis.com (195.60.68.100) by DB5PEPF00014B8B.mail.protection.outlook.com (10.167.8.199) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7113.14 via Frontend Transport; Tue, 19 Dec 2023 03:09:05 +0000 Received: from SE-MAILARCH01W.axis.com (10.20.40.15) by se-mail02w.axis.com (10.20.40.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 19 Dec 2023 04:09:04 +0100 Received: from se-mail01w.axis.com (10.20.40.7) by SE-MAILARCH01W.axis.com (10.20.40.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 19 Dec 2023 04:09:04 +0100 Received: from se-intmail01x.se.axis.com (10.0.5.60) by se-mail01w.axis.com (10.20.40.7) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 19 Dec 2023 04:09:04 +0100 Received: from pchp3.se.axis.com (pchp3.se.axis.com [10.88.21.53]) by se-intmail01x.se.axis.com (Postfix) with ESMTP id 97FE01044C; Tue, 19 Dec 2023 04:09:04 +0100 (CET) Received: by pchp3.se.axis.com (Postfix, from userid 171) id BBDFD20425; Tue, 19 Dec 2023 04:09:04 +0100 (CET) From: Hans-Peter Nilsson To: Mike Frysinger CC: , In-Reply-To: <20231219024423.25287-1-vapier@gentoo.org> (message from Mike Frysinger on Mon, 18 Dec 2023 21:44:23 -0500) Subject: Re: [PATCH] cpu: cris: drop some unused vars MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT References: <20231219024423.25287-1-vapier@gentoo.org> Message-ID: <20231219030904.BBDFD20425@pchp3.se.axis.com> Date: Tue, 19 Dec 2023 04:09:04 +0100 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB5PEPF00014B8B:EE_|AS8PR02MB9185:EE_ X-MS-Office365-Filtering-Correlation-Id: 3114899b-ec88-4f75-fb52-08dc003fdc1b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RVZxE0LV3RD0HjFs6Bt9EWXYc+5GrFpxKYUiV5xx1+gDrzSD64zXQn0rDZyShX6VHcrEdx2rciY+Tn0CoxglQiQNbrL3llpIyc+82yHdatsKD36OiNPWDZ73b0dxXu3wS43NcWw+gvjDO3mjv8KXnxRr0xM+bpmbZ2FSFiS40zHLdgMN5L10ddGfvbGyUUUAhEmx/1TRAX80KW42YgGC5x0nJXmlK99bqEqquDCykXzGTwVHHWnXKwGGYgLgdTNWJ91d65ThAYDoYRVoyetjUgLD/gkPO4pFgYR4c4P/btBgxWjGNnxIWdXWHscZjTHB6BGW8MrFR9fLpMuAuUq2FyaZj3VoJtre5dPO1Xh6Hfie1NrNHQI3ldAbZ5nMZSRBRsZBh/djbkzbiYZzkkngr2xneUEtVCbEz92M0aoKqP8qZYThZfKvBloBURnU/9icFriNNg2UxkTKWRA0qeV+g+h97kKJ4S1u5oHrVDHswU3lcg7y2fEoR95LOT4Q9Z53JOvmCq1cGX8Tu3S8DpxBWizDf6Ef6Mi3gYdooGQ2gpj0A9/iyjvXNaSBBV8tZvS6ghhoeMnjPXTShWJSSuT1ejEhrw2+GumSON62HazDsopYNDCgv/cTlP0YQM/JJTztsrpi8WGEZ3dsM+mp1EN2SLLQ0nmjob8ZGPfBJ0iPhtI0DDkvyQSDaXxQaQDnCVd2zfh0kZKNyJ2PHu7Gi8tVPXgIXuOUtUtqd2LxsQGZyZodIzB7HY+Hj1IpNsGXvdGeih7oEpWkk2p8LpisLGtK1GZ/Wh9udRyvW1JYP39mkSQ0kvOV7kF0iG7mR9dUNSs6 X-Forefront-Antispam-Report: CIP:195.60.68.100;CTRY:SE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.axis.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(4636009)(39860400002)(346002)(396003)(136003)(376002)(230173577357003)(230273577357003)(230922051799003)(64100799003)(82310400011)(186009)(1800799012)(451199024)(40470700004)(46966006)(36840700001)(40480700001)(1076003)(426003)(26005)(6266002)(336012)(40460700003)(82740400003)(81166007)(33656002)(47076005)(5660300002)(83380400001)(356005)(8676002)(36860700001)(4326008)(70206006)(8936002)(70586007)(316002)(6916009)(2906002)(42186006)(54906003)(478600001)(41300700001)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: axis.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Dec 2023 03:09:05.4903 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3114899b-ec88-4f75-fb52-08dc003fdc1b X-MS-Exchange-CrossTenant-Id: 78703d3c-b907-432f-b066-88f7af9ca3af X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=78703d3c-b907-432f-b066-88f7af9ca3af;Ip=[195.60.68.100];Helo=[mail.axis.com] X-MS-Exchange-CrossTenant-AuthSource: DB5PEPF00014B8B.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR02MB9185 X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > From: Mike Frysinger > Date: Mon, 18 Dec 2023 21:44:23 -0500 > These fix unused variable warnings in the generated sim. > --- > cpu/cris.cpu | 4 ++-- > sim/cris/semcrisv10f-switch.c | 2 -- > sim/cris/semcrisv32f-switch.c | 2 -- > 3 files changed, 2 insertions(+), 6 deletions(-) > > diff --git a/cpu/cris.cpu b/cpu/cris.cpu > index 97b44581e78b..2e8cb352b2b9 100644 > --- a/cpu/cris.cpu > +++ b/cpu/cris.cpu > @@ -2598,7 +2598,7 @@ > "move ${Ps},${Rd-sfield}" > (+ Ps RFIX_MOVE_S_R MODE_REGISTER SIZE_FIXED Rd-sfield) > (sequence > - ((SI grno) (SI prno) (SI newval)) > + ((SI prno) (SI newval)) > (set prno (regno Ps)) > ; CGEN-FIXME: Can't use the following and then "grno" below because > ; CGEN will emit a "tmp_grno" *also* in decodev32.c:crisv32f_decode 'k, but can you please "move" the removed declaration to the comment? Something like '; CGEN-FIXME: Can't declare (SI grno) and then the following and then use "grno" below because'. Else it'll look even more odd with there being no "grno" at all. If it's not obvious: IIRC, this refers to "(regno Rd-sfield)" which would be more readable "decoded" as "grno". ...well, relatively more readable. > @@ -3837,7 +3837,7 @@ > "$Rs,$Rd" > (+ Rd MODE_REGISTER RFIX_BTST SIZE_FIXED Rs) > (sequence > - ((SI tmpd) (SI cnt)) > + ((SI tmpd)) Either that, or add "(set cnt (sub 31 (and Rs 31))" with the next line replaced by "(set tmpd (sll Rd cnt))". At your discretion. No need to repost if you optionally fix those, commit at your leisure. Thanks! brgds, H-P