From: Mike Frysinger <vapier@gentoo.org>
To: gdb-patches@sourceware.org
Subject: [PATCH/committed 1/3] sim: bfin: clean up astat reg name decode a little
Date: Thu, 21 Dec 2023 00:03:13 -0500 [thread overview]
Message-ID: <20231221050315.23130-1-vapier@gentoo.org> (raw)
The compiler pointed out we checked AZ twice. Sort by name to avoid
that in the future, and to make it clearer that we have coverage of
all the bits. And add the bits we were missing.
The order here doesn't matter as it's just turning a pointer into a
human readable string when store tracing is enabled.
---
sim/bfin/bfin-sim.c | 26 ++++++++++++++------------
1 file changed, 14 insertions(+), 12 deletions(-)
diff --git a/sim/bfin/bfin-sim.c b/sim/bfin/bfin-sim.c
index 4fa5ccc315c7..1a9b499ebb4c 100644
--- a/sim/bfin/bfin-sim.c
+++ b/sim/bfin/bfin-sim.c
@@ -504,6 +504,16 @@ get_store_name (SIM_CPU *cpu, bu32 *p)
return greg_names[4 * 8 + 2];
else if (p == &AWREG (1))
return greg_names[4 * 8 + 3];
+ else if (p == &ASTATREG (ac0))
+ return "ASTAT[ac0]";
+ else if (p == &ASTATREG (ac0_copy))
+ return "ASTAT[ac0_copy]";
+ else if (p == &ASTATREG (ac1))
+ return "ASTAT[ac1]";
+ else if (p == &ASTATREG (an))
+ return "ASTAT[an]";
+ else if (p == &ASTATREG (aq))
+ return "ASTAT[aq]";
else if (p == &ASTATREG (av0))
return "ASTAT[av0]";
else if (p == &ASTATREG (av0s))
@@ -512,22 +522,14 @@ get_store_name (SIM_CPU *cpu, bu32 *p)
return "ASTAT[av1]";
else if (p == &ASTATREG (av1s))
return "ASTAT[av1s]";
+ else if (p == &ASTATREG (az))
+ return "ASTAT[az]";
else if (p == &ASTATREG (v))
return "ASTAT[v]";
- else if (p == &ASTATREG (vs))
- return "ASTAT[vs]";
else if (p == &ASTATREG (v_copy))
return "ASTAT[v_copy]";
- else if (p == &ASTATREG (az))
- return "ASTAT[az]";
- else if (p == &ASTATREG (an))
- return "ASTAT[an]";
- else if (p == &ASTATREG (az))
- return "ASTAT[az]";
- else if (p == &ASTATREG (ac0))
- return "ASTAT[ac0]";
- else if (p == &ASTATREG (ac0_copy))
- return "ASTAT[ac0_copy]";
+ else if (p == &ASTATREG (vs))
+ return "ASTAT[vs]";
else
{
/* Worry about this when we start to STORE() it. */
--
2.43.0
next reply other threads:[~2023-12-21 5:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-21 5:03 Mike Frysinger [this message]
2023-12-21 5:03 ` [PATCH/ccommitted 2/3] sim: mn10300: fix LAST_TIMER_REG typo Mike Frysinger
2023-12-21 5:03 ` [PATCH/committed 3/3] sim: warnings: enable -Wduplicated-cond Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231221050315.23130-1-vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).