From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id E316B3858407 for ; Thu, 21 Dec 2023 06:21:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E316B3858407 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E316B3858407 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:ea4a:1:5054:ff:fec7:86e4 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703139705; cv=none; b=dEMuyRzIK348kQm7arqLImmfVPw+uEKOXGTPc//ZPnibE8eIUcQ+CIzhKQ/99cAzIT8ikc/H2mZiAc2m/5LDPbZwNQFUvBIFFSfGIQQlweerFZXwsHSOWCxwYMaxqEDoa/COOp7w3r+aIs3c0n1LPmtJqchRykVO/vjB9nkv/l0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703139705; c=relaxed/simple; bh=6Py0Qciu7TWcUwFjraOlfhyndsvcLDfjyxCbi6ct1eA=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=LtWCG1P47tPCfnK+6naf7QOgwIl1QpDAk84EZgytEm0D/X4teJsgsAo5+rHZMFXrsU8mFpx0ioBI77hnoWS0jtuaOeEwsVJ88wYjTs0t8SH8j0RatFkha1zOc7y3utP8O0Lfoi9Pgq4d4Y6wVwa4udGZ8nDKwCFBn/WrKhoM1Yc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by smtp.gentoo.org (Postfix, from userid 559) id 3DFD3340BEF; Thu, 21 Dec 2023 06:21:44 +0000 (UTC) From: Mike Frysinger To: gdb-patches@sourceware.org Subject: [PATCH/committed] sim: ppc: phb: add missing break to address decoder Date: Thu, 21 Dec 2023 01:21:42 -0500 Message-ID: <20231221062142.3958-1-vapier@gentoo.org> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00,GIT_PATCH_0,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: I don't know what this emulation does exactly, but it missing a break statement seems kind of obvious based on the 32-bit case above it. --- sim/ppc/hw_phb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sim/ppc/hw_phb.c b/sim/ppc/hw_phb.c index ec1119ee7d9b..06eb29fc5a77 100644 --- a/sim/ppc/hw_phb.c +++ b/sim/ppc/hw_phb.c @@ -652,6 +652,7 @@ hw_phb_unit_decode(device *me, && val != 0x10 && val != 0x18 && val != 0x20) device_error(me, "Register number (0x%lx) invalid in 64bit PCI address %s", val, unit); + break; case ss_config_code: device_error(me, "internal error"); } -- 2.43.0