public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: gdb-patches@sourceware.org
Subject: [PATCH/committed] sim: sh: add missing breaks to bit processing
Date: Thu, 21 Dec 2023 01:46:26 -0500	[thread overview]
Message-ID: <20231221064626.15388-1-vapier@gentoo.org> (raw)

Doesn't seem like we want to cascade in this section when bit processing.
---
 sim/sh/gencode.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/sim/sh/gencode.c b/sim/sh/gencode.c
index 2522ec124f86..1835cf92ff3f 100644
--- a/sim/sh/gencode.c
+++ b/sim/sh/gencode.c
@@ -3359,16 +3359,22 @@ ppi_gensim (void)
   printf ("    {\n");
   printf ("    case 0: /* Carry Mode */\n");
   printf ("      DSR |= carry;\n");
+  printf ("      break;\n");
   printf ("    case 1: /* Negative Value Mode */\n");
   printf ("      DSR |= res_grd >> 7 & 1;\n");
+  printf ("      break;\n");
   printf ("    case 2: /* Zero Value Mode */\n");
   printf ("      DSR |= DSR >> 6 & 1;\n");
+  printf ("      break;\n");
   printf ("    case 3: /* Overflow mode */\n");
   printf ("      DSR |= overflow >> 4;\n");
+  printf ("      break;\n");
   printf ("    case 4: /* Signed Greater Than Mode */\n");
   printf ("      DSR |= DSR >> 7 & 1;\n");
+  printf ("      break;\n");
   printf ("    case 5: /* Signed Greater Than Or Equal Mode */\n");
   printf ("      DSR |= greater_equal >> 7;\n");
+  printf ("      break;\n");
   printf ("    }\n");
   printf (" assign_z:\n");
   printf ("  if (0xa05f >> z & 1)\n");
-- 
2.43.0


                 reply	other threads:[~2023-12-21  6:46 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231221064626.15388-1-vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).