From: Mike Frysinger <vapier@gentoo.org>
To: gdb-patches@sourceware.org
Subject: [PATCH/committed 12/20] sim: mcore: fix Wimplicit-fallthrough warnings
Date: Thu, 21 Dec 2023 02:01:19 -0500 [thread overview]
Message-ID: <20231221070127.19142-12-vapier@gentoo.org> (raw)
In-Reply-To: <20231221070127.19142-1-vapier@gentoo.org>
Seems like these decodes were intended to fallthru.
---
sim/mcore/interp.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sim/mcore/interp.c b/sim/mcore/interp.c
index b0c2cc2b3177..d24af0d94720 100644
--- a/sim/mcore/interp.c
+++ b/sim/mcore/interp.c
@@ -1105,6 +1105,7 @@ step_once (SIM_DESC sd, SIM_CPU *cpu)
fprintf (stderr,
"func call: r2 = %x r3 = %x r4 = %x r5 = %x r6 = %x r7 = %x\n",
gr[2], gr[3], gr[4], gr[5], gr[6], gr[7]);
+ ATTRIBUTE_FALLTHROUGH;
case 0x70: /* jmpi */
pc = rlat ((pc + ((inst & 0xFF) << 2)) & 0xFFFFFFFC);
memops++;
@@ -1192,6 +1193,7 @@ step_once (SIM_DESC sd, SIM_CPU *cpu)
case 0xF8: case 0xF9: case 0xFA: case 0xFB:
case 0xFC: case 0xFD: case 0xFE: case 0xFF: /* bsr */
gr[15] = pc;
+ ATTRIBUTE_FALLTHROUGH;
case 0xF0: case 0xF1: case 0xF2: case 0xF3:
case 0xF4: case 0xF5: case 0xF6: case 0xF7: /* br */
{
--
2.43.0
next prev parent reply other threads:[~2023-12-21 7:01 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-21 7:01 [PATCH/committed 01/20] sim: signal: mark signal callback funcs as noreturn since they don't return Mike Frysinger
2023-12-21 7:01 ` [PATCH/committed 02/20] sim: add ATTRIBUTE_FALLTHROUGH for local code Mike Frysinger
2023-12-21 7:01 ` [PATCH/committed 03/20] sim: common: fix -Wimplicit-fallthrough warnings Mike Frysinger
2023-12-21 7:01 ` [PATCH/committed 04/20] sim: aarch64: " Mike Frysinger
2023-12-21 7:01 ` [PATCH/committed 05/20] sim: arm: " Mike Frysinger
2023-12-21 7:01 ` [PATCH/committed 06/20] sim: avr: " Mike Frysinger
2023-12-21 7:01 ` [PATCH/committed 07/20] sim: bfin: " Mike Frysinger
2023-12-21 7:01 ` [PATCH/committed 08/20] sim: cris: " Mike Frysinger
2023-12-21 7:01 ` [PATCH/committed 09/20] sim: erc32: " Mike Frysinger
2023-12-21 7:01 ` [PATCH/committed 10/20] sim: frv: " Mike Frysinger
2023-12-21 7:01 ` [PATCH/committed 11/20] sim: m68hc11: " Mike Frysinger
2023-12-21 7:01 ` Mike Frysinger [this message]
2023-12-21 7:01 ` [PATCH/committed 13/20] sim: mips: " Mike Frysinger
2023-12-21 7:01 ` [PATCH/committed 14/20] sim: or1k: " Mike Frysinger
2023-12-21 7:01 ` [PATCH/committed 15/20] sim: ppc: " Mike Frysinger
2023-12-21 7:01 ` [PATCH/committed 16/20] sim: riscv: " Mike Frysinger
2023-12-21 7:01 ` [PATCH/committed 17/20] sim: rl78: " Mike Frysinger
2023-12-21 7:01 ` [PATCH/committed 18/20] sim: rx: " Mike Frysinger
2023-12-21 7:01 ` [PATCH/committed 19/20] sim: sh: " Mike Frysinger
2023-12-21 7:01 ` [PATCH/committed 20/20] sim: warnings: enable -Wimplicit-fallthrough=5 Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231221070127.19142-12-vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).