From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id CAA81384DEE1 for ; Thu, 21 Dec 2023 07:01:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CAA81384DEE1 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CAA81384DEE1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:ea4a:1:5054:ff:fec7:86e4 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703142099; cv=none; b=d1gpHuPIJZz9zJORz9OHjW28T45AKAe17C9JNqnjBiQaZZOrKA6ZKYbR9rVNUghesk2K7usXI20zE1tnLvLKNhS2MFu/xF/wKz1E4GC/cs1R+t4pfTW7SyOmcGPAOPzXKHsRdMjeyBiLFyoFMq69jkc2Wj3eTwbX76HzxgCKYuA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703142099; c=relaxed/simple; bh=pKe+CityYpuSdR8yg+6SQ5ElaUbxZlZMzZzmrCdPMD0=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=lD4Ne+dvuQDE8MMAUzavoGOg8T/IEyToc+aC4I3GHOZakMsmo56/jEonPBqnWxyQFuCKRPgrEZcu7nPrG9V2JcdU81T/KpgBs9rh2jofR9DWZLt4ahbgvH5VAVCRAEO8/X2qAE63Clf+uHM7TQjyNYZaKBL5IjwFTWZlTjhd5xk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by smtp.gentoo.org (Postfix, from userid 559) id 62D3E340BEF; Thu, 21 Dec 2023 07:01:37 +0000 (UTC) From: Mike Frysinger To: gdb-patches@sourceware.org Subject: [PATCH/committed 05/20] sim: arm: fix -Wimplicit-fallthrough warnings Date: Thu, 21 Dec 2023 02:01:12 -0500 Message-ID: <20231221070127.19142-5-vapier@gentoo.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231221070127.19142-1-vapier@gentoo.org> References: <20231221070127.19142-1-vapier@gentoo.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00,GIT_PATCH_0,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Replace some fall through comments with the attribute. --- sim/arm/armemu.c | 6 +++--- sim/arm/armos.c | 1 + sim/arm/thumbemu.c | 7 ++++--- sim/arm/wrapper.c | 4 ++-- 4 files changed, 10 insertions(+), 8 deletions(-) diff --git a/sim/arm/armemu.c b/sim/arm/armemu.c index ab7454628ba0..2b8ae007cb56 100644 --- a/sim/arm/armemu.c +++ b/sim/arm/armemu.c @@ -4388,7 +4388,7 @@ check_PMUintr: ARMul_UndefInstr (state, instr); break; } - /* Drop through. */ + ATTRIBUTE_FALLTHROUGH; case 0xc0: /* Store , No WriteBack , Post Dec. */ ARMul_STC (state, instr, LHS); @@ -4435,7 +4435,7 @@ check_PMUintr: ARMul_UndefInstr (state, instr); break; } - /* Drop through. */ + ATTRIBUTE_FALLTHROUGH; case 0xc1: /* Load , No WriteBack , Post Dec. */ ARMul_LDC (state, instr, LHS); @@ -4622,7 +4622,7 @@ check_PMUintr: default: break; } - /* Drop through. */ + ATTRIBUTE_FALLTHROUGH; case 0xe0: case 0xe4: diff --git a/sim/arm/armos.c b/sim/arm/armos.c index 374861d7a5ec..6deb722d204d 100644 --- a/sim/arm/armos.c +++ b/sim/arm/armos.c @@ -832,6 +832,7 @@ ARMul_OSHandleSWI (ARMul_State * state, ARMword number) } break; } + ATTRIBUTE_FALLTHROUGH; default: unhandled = TRUE; diff --git a/sim/arm/thumbemu.c b/sim/arm/thumbemu.c index 6915d23ec4cc..99f51ef34691 100644 --- a/sim/arm/thumbemu.c +++ b/sim/arm/thumbemu.c @@ -308,7 +308,7 @@ handle_T2_insn (ARMul_State * state, * pvalid = t_branch; break; } - /* Fall through. */ + ATTRIBUTE_FALLTHROUGH; case 0x42: case 0x43: case 0x47: @@ -2261,7 +2261,7 @@ ARMul_ThumbDecode (ARMul_State * state, | ((tinstr & 0x0078) >> 3); /* Rd */ break; } - /* Drop through. */ + ATTRIBUTE_FALLTHROUGH; default: case 0x0: /* UNDEFINED */ case 0x4: /* UNDEFINED */ @@ -2415,7 +2415,7 @@ ARMul_ThumbDecode (ARMul_State * state, * ainstr = 0xE1200070 | ((tinstr & 0xf0) << 4) | (tinstr & 0xf); break; } - /* Drop through. */ + ATTRIBUTE_FALLTHROUGH; default: /* Everything else is an undefined instruction. */ handle_v6_thumb_insn (state, tinstr, next_instr, pc, ainstr, & valid); @@ -2601,6 +2601,7 @@ ARMul_ThumbDecode (ARMul_State * state, } /* else we fall through to process the second half of the BL */ pc += 2; /* point the pc at the 2nd half */ + ATTRIBUTE_FALLTHROUGH; case 31: /* BL instruction 2 */ if (state->is_v6) { diff --git a/sim/arm/wrapper.c b/sim/arm/wrapper.c index 52b4dc7d6e09..8d928a6f79f9 100644 --- a/sim/arm/wrapper.c +++ b/sim/arm/wrapper.c @@ -251,7 +251,7 @@ sim_create_inferior (SIM_DESC sd ATTRIBUTE_UNUSED, (sim_callback, "Unknown machine type '%d'; please update sim_create_inferior.\n", mach); - /* fall through */ + ATTRIBUTE_FALLTHROUGH; case 0: /* We wouldn't set the machine type with earlier toolchains, so we @@ -310,7 +310,7 @@ sim_create_inferior (SIM_DESC sd ATTRIBUTE_UNUSED, ARMul_SelectProcessor (state, ARM_v5_Prop | ARM_v5e_Prop | ARM_XScale_Prop); break; } - /* Otherwise drop through. */ + ATTRIBUTE_FALLTHROUGH; case bfd_mach_arm_5T: ARMul_SelectProcessor (state, ARM_v5_Prop); -- 2.43.0