From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id 16C1E3858D1E for ; Sun, 31 Dec 2023 19:57:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 16C1E3858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 16C1E3858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=45.83.234.184 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704052654; cv=none; b=ack9RYUr01G83ajDB9e6fD3P0tE+FhaJWdC7xWtdO7eGEyqyZVrD28ZZfhqAmhxCMoDz2/rjQsLUb4AlDfVi2V5Lf/Aepq5nfs/XJfFatEgmm/XmBnz2fP0cOg3jmxSPOkEEZnNVL64VU4WPVBz6GPvjrBSqTOH4bOat0FmLiu8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704052654; c=relaxed/simple; bh=rgIKUU3rRXi+FD/yt0FE7llttgONItmu7JFXIhsnwqY=; h=Date:From:To:Subject:Message-ID:MIME-Version; b=hOaIyKexgVuQ5VTySb68EUAq+2KYL8A6nZGULxALCkmC5XJ4qbX8jacBirfPBCUunL2qZox+sxL1HlrXnqOdlofrsLVx3ASl2tYIQbK6G5e70tGSXN9MhsIlB8WO+Fl1hajDC5jaz7kLHQ1jfw329V3hSz0gin/51z9k0Cab5r0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by gnu.wildebeest.org (Postfix, from userid 1000) id 0E914302BB42; Sun, 31 Dec 2023 20:57:31 +0100 (CET) Date: Sun, 31 Dec 2023 20:57:31 +0100 From: Mark Wielaard To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Add keywords to TuiWindow.write Message-ID: <20231231195731.GA2262@gnu.wildebeest.org> References: <20231213055315.824821-1-tom@tromey.com> <878r5bcx71.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <878r5bcx71.fsf@tromey.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Tom, On Sat, Dec 30, 2023 at 12:22:26PM -0700, Tom Tromey wrote: > >>>>> "Tom" == Tom Tromey writes: > > Tom> The gdb docs promise that methods with more than two or more arguments > Tom> will accept keywords. However, I found that TuiWindow.write didn't > Tom> allow them. This patch adds the missing support. > > I'm checking this in. This broke the python black checker: https://builder.sourceware.org/buildbot/#/builders/74/builds/6022 --- /home/builder/shared/bb1-2/worker/gdb-fedora-x86_64/binutils-gdb/gdb/testsuite/gdb.python/tui-window.py 2023-12-30 19:45:58.307468+00:00 +++ /home/builder/shared/bb1-2/worker/gdb-fedora-x86_64/binutils-gdb/gdb/testsuite/gdb.python/tui-window.py 2023-12-30 19:51:54.065041+00:00 @@ -30,12 +30,14 @@ def render(self): self.win.erase() w = self.win.width h = self.win.height - self.win.write(string="Test: " + str(self.count) + " " + str(w) + "x" + str(h), - full_window=False) + self.win.write( + string="Test: " + str(self.count) + " " + str(w) + "x" + str(h), + full_window=False, + ) self.count = self.count + 1 # Tries to delete the title attribute. GDB will throw an error. def remove_title(self): del self.win.title would reformat /home/builder/shared/bb1-2/worker/gdb-fedora-x86_64/binutils-gdb/gdb/testsuite/gdb.python/tui-window.py Oh no! 💥 💔 💥 1 file would be reformatted, 149 files would be left unchanged.